[INFO] updating cached repository onelson/advent-of-code-2018 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/onelson/advent-of-code-2018 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/onelson/advent-of-code-2018" "work/ex/clippy-test-run/sources/stable/gh/onelson/advent-of-code-2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/onelson/advent-of-code-2018'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/onelson/advent-of-code-2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/onelson/advent-of-code-2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/onelson/advent-of-code-2018'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 273c429cb9076f6ee901ee8606e9efef28797c4b [INFO] sha for GitHub repo onelson/advent-of-code-2018: 273c429cb9076f6ee901ee8606e9efef28797c4b [INFO] validating manifest of onelson/advent-of-code-2018 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of onelson/advent-of-code-2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing onelson/advent-of-code-2018 [INFO] finished frobbing onelson/advent-of-code-2018 [INFO] frobbed toml for onelson/advent-of-code-2018 written to work/ex/clippy-test-run/sources/stable/gh/onelson/advent-of-code-2018/Cargo.toml [INFO] started frobbing onelson/advent-of-code-2018 [INFO] finished frobbing onelson/advent-of-code-2018 [INFO] frobbed toml for onelson/advent-of-code-2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/onelson/advent-of-code-2018/Cargo.toml [INFO] crate onelson/advent-of-code-2018 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting onelson/advent-of-code-2018 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/onelson/advent-of-code-2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 35aa1cd0fe3e447185e352d19d4e045d1119ddfb01f658aaa040cf6539e4fdac [INFO] running `"docker" "start" "-a" "35aa1cd0fe3e447185e352d19d4e045d1119ddfb01f658aaa040cf6539e4fdac"` [INFO] [stderr] Checking advent-of-code-2018 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/02-checksum.rs:52:19 [INFO] [stderr] | [INFO] [stderr] 52 | const INPUT: &'static str = "aabbcccc"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/bin/01-calibration.rs:9:14 [INFO] [stderr] | [INFO] [stderr] 9 | let fp = env::args().skip(1).next().expect("file path"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: function is never used: `has_exact_count` [INFO] [stderr] --> src/bin/02-checksum.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | fn has_exact_count(count: usize, s: &str, chars: &HashSet) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/bin/02-checksum.rs:25:14 [INFO] [stderr] | [INFO] [stderr] 25 | let fp = env::args().skip(1).next().expect("file path"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/bin/01-calibration.rs:9:14 [INFO] [stderr] | [INFO] [stderr] 9 | let fp = env::args().skip(1).next().expect("file path"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/bin/02-checksum.rs:25:14 [INFO] [stderr] | [INFO] [stderr] 25 | let fp = env::args().skip(1).next().expect("file path"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.36s [INFO] running `"docker" "inspect" "35aa1cd0fe3e447185e352d19d4e045d1119ddfb01f658aaa040cf6539e4fdac"` [INFO] running `"docker" "rm" "-f" "35aa1cd0fe3e447185e352d19d4e045d1119ddfb01f658aaa040cf6539e4fdac"` [INFO] [stdout] 35aa1cd0fe3e447185e352d19d4e045d1119ddfb01f658aaa040cf6539e4fdac