[INFO] updating cached repository olipratt/projecteuler-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/olipratt/projecteuler-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/olipratt/projecteuler-rust" "work/ex/clippy-test-run/sources/stable/gh/olipratt/projecteuler-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/olipratt/projecteuler-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/olipratt/projecteuler-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/olipratt/projecteuler-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/olipratt/projecteuler-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1641324587a7a7340919ac1469f998de9213570b [INFO] sha for GitHub repo olipratt/projecteuler-rust: 1641324587a7a7340919ac1469f998de9213570b [INFO] validating manifest of olipratt/projecteuler-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of olipratt/projecteuler-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing olipratt/projecteuler-rust [INFO] finished frobbing olipratt/projecteuler-rust [INFO] frobbed toml for olipratt/projecteuler-rust written to work/ex/clippy-test-run/sources/stable/gh/olipratt/projecteuler-rust/Cargo.toml [INFO] started frobbing olipratt/projecteuler-rust [INFO] finished frobbing olipratt/projecteuler-rust [INFO] frobbed toml for olipratt/projecteuler-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/olipratt/projecteuler-rust/Cargo.toml [INFO] crate olipratt/projecteuler-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting olipratt/projecteuler-rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/olipratt/projecteuler-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1c22e3d4f69afc75fd13cc947e1b6bf8b23047c1ae27bd79f0f2c8c08f016eb1 [INFO] running `"docker" "start" "-a" "1c22e3d4f69afc75fd13cc947e1b6bf8b23047c1ae27bd79f0f2c8c08f016eb1"` [INFO] [stderr] Checking log v0.4.2 [INFO] [stderr] Checking euler v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:17:18 [INFO] [stderr] | [INFO] [stderr] 17 | let result = mults_of_3 + mults_of_5 - mults_of_15; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:17:18 [INFO] [stderr] | [INFO] [stderr] 17 | let result = mults_of_3 + mults_of_5 - mults_of_15; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:190:20 [INFO] [stderr] | [INFO] [stderr] 190 | assert_eq!(233168, sum_of_mults_of_3_and_5_lt_n(1000)); [INFO] [stderr] | ^^^^^^ help: consider: `233_168` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:195:20 [INFO] [stderr] | [INFO] [stderr] 195 | assert_eq!(4613732, sum_even_fib_terms_less_than(4000001)); [INFO] [stderr] | ^^^^^^^ help: consider: `4_613_732` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:195:58 [INFO] [stderr] | [INFO] [stderr] 195 | assert_eq!(4613732, sum_even_fib_terms_less_than(4000001)); [INFO] [stderr] | ^^^^^^^ help: consider: `4_000_001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:200:47 [INFO] [stderr] | [INFO] [stderr] 200 | assert_eq!(6857, largest_prime_factor(600851475143)); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `600_851_475_143` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:206:13 [INFO] [stderr] | [INFO] [stderr] 206 | 906609, [INFO] [stderr] | ^^^^^^ help: consider: `906_609` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:213:20 [INFO] [stderr] | [INFO] [stderr] 213 | assert_eq!(232792560, evenly_divisible_by_nums_up_to_n(20)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `232_792_560` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:228:20 [INFO] [stderr] | [INFO] [stderr] 228 | assert_eq!(871198282, score_names(names)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `871_198_282` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:234:20 [INFO] [stderr] | [INFO] [stderr] 234 | assert_eq!(125874, multiples_contain_same_digits(2)); [INFO] [stderr] | ^^^^^^ help: consider: `125_874` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:235:20 [INFO] [stderr] | [INFO] [stderr] 235 | assert_eq!(142857, multiples_contain_same_digits(3)); [INFO] [stderr] | ^^^^^^ help: consider: `142_857` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:236:20 [INFO] [stderr] | [INFO] [stderr] 236 | assert_eq!(142857, multiples_contain_same_digits(4)); [INFO] [stderr] | ^^^^^^ help: consider: `142_857` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:237:20 [INFO] [stderr] | [INFO] [stderr] 237 | assert_eq!(142857, multiples_contain_same_digits(5)); [INFO] [stderr] | ^^^^^^ help: consider: `142_857` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:238:20 [INFO] [stderr] | [INFO] [stderr] 238 | assert_eq!(142857, multiples_contain_same_digits(6)); [INFO] [stderr] | ^^^^^^ help: consider: `142_857` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | num = num / 10; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `num /= 10` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:102:25 [INFO] [stderr] | [INFO] [stderr] 102 | for multiple in 2..(num_multiples + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `2..=num_multiples` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:150:14 [INFO] [stderr] | [INFO] [stderr] 150 | for x in 2..(n + 1) { [INFO] [stderr] | ^^^^^^^^^^ help: use: `2..=n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:174:27 [INFO] [stderr] | [INFO] [stderr] 174 | name_total += (letter - b'A' + 1) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(letter - b'A' + 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | num = num / 10; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `num /= 10` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:102:25 [INFO] [stderr] | [INFO] [stderr] 102 | for multiple in 2..(num_multiples + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `2..=num_multiples` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:150:14 [INFO] [stderr] | [INFO] [stderr] 150 | for x in 2..(n + 1) { [INFO] [stderr] | ^^^^^^^^^^ help: use: `2..=n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:174:27 [INFO] [stderr] | [INFO] [stderr] 174 | name_total += (letter - b'A' + 1) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(letter - b'A' + 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.41s [INFO] running `"docker" "inspect" "1c22e3d4f69afc75fd13cc947e1b6bf8b23047c1ae27bd79f0f2c8c08f016eb1"` [INFO] running `"docker" "rm" "-f" "1c22e3d4f69afc75fd13cc947e1b6bf8b23047c1ae27bd79f0f2c8c08f016eb1"` [INFO] [stdout] 1c22e3d4f69afc75fd13cc947e1b6bf8b23047c1ae27bd79f0f2c8c08f016eb1