[INFO] updating cached repository oddish2211/r710-fancontroller-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/oddish2211/r710-fancontroller-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/oddish2211/r710-fancontroller-rust" "work/ex/clippy-test-run/sources/stable/gh/oddish2211/r710-fancontroller-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/oddish2211/r710-fancontroller-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/oddish2211/r710-fancontroller-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/oddish2211/r710-fancontroller-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/oddish2211/r710-fancontroller-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 154b4eb0b05227dbedc9314b73d3de268bccecf2 [INFO] sha for GitHub repo oddish2211/r710-fancontroller-rust: 154b4eb0b05227dbedc9314b73d3de268bccecf2 [INFO] validating manifest of oddish2211/r710-fancontroller-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of oddish2211/r710-fancontroller-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing oddish2211/r710-fancontroller-rust [INFO] finished frobbing oddish2211/r710-fancontroller-rust [INFO] frobbed toml for oddish2211/r710-fancontroller-rust written to work/ex/clippy-test-run/sources/stable/gh/oddish2211/r710-fancontroller-rust/Cargo.toml [INFO] started frobbing oddish2211/r710-fancontroller-rust [INFO] finished frobbing oddish2211/r710-fancontroller-rust [INFO] frobbed toml for oddish2211/r710-fancontroller-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/oddish2211/r710-fancontroller-rust/Cargo.toml [INFO] crate oddish2211/r710-fancontroller-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting oddish2211/r710-fancontroller-rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/oddish2211/r710-fancontroller-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6d87693d8faca0566d7b7160d4374f115fd4e7afa3671867a54f5488c2986df3 [INFO] running `"docker" "start" "-a" "6d87693d8faca0566d7b7160d4374f115fd4e7afa3671867a54f5488c2986df3"` [INFO] [stderr] Checking r710-fancontroller-rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:54:2 [INFO] [stderr] | [INFO] [stderr] 54 | return (min, max, avg); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(min, max, avg)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:54:2 [INFO] [stderr] | [INFO] [stderr] 54 | return (min, max, avg); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(min, max, avg)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/main.rs:22:21 [INFO] [stderr] | [INFO] [stderr] 22 | 0 ... 40 => set_fan_manual(0), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_overlapping_arm)] on by default [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/main.rs:23:21 [INFO] [stderr] | [INFO] [stderr] 23 | 40 ... 55 => set_fan_manual((measurements.1 - 40) as u8), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:43:27 [INFO] [stderr] | [INFO] [stderr] 43 | for line in stdout.split("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/main.rs:22:21 [INFO] [stderr] | [INFO] [stderr] 22 | 0 ... 40 => set_fan_manual(0), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_overlapping_arm)] on by default [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/main.rs:23:21 [INFO] [stderr] | [INFO] [stderr] 23 | 40 ... 55 => set_fan_manual((measurements.1 - 40) as u8), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:43:27 [INFO] [stderr] | [INFO] [stderr] 43 | for line in stdout.split("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.01s [INFO] running `"docker" "inspect" "6d87693d8faca0566d7b7160d4374f115fd4e7afa3671867a54f5488c2986df3"` [INFO] running `"docker" "rm" "-f" "6d87693d8faca0566d7b7160d4374f115fd4e7afa3671867a54f5488c2986df3"` [INFO] [stdout] 6d87693d8faca0566d7b7160d4374f115fd4e7afa3671867a54f5488c2986df3