[INFO] updating cached repository oampo/dosa [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/oampo/dosa [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/oampo/dosa" "work/ex/clippy-test-run/sources/stable/gh/oampo/dosa"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/oampo/dosa'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/oampo/dosa" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/oampo/dosa"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/oampo/dosa'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ab5c6c377af6555c6e8df0bb75f6597e7b6704f4 [INFO] sha for GitHub repo oampo/dosa: ab5c6c377af6555c6e8df0bb75f6597e7b6704f4 [INFO] validating manifest of oampo/dosa on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of oampo/dosa on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing oampo/dosa [INFO] finished frobbing oampo/dosa [INFO] frobbed toml for oampo/dosa written to work/ex/clippy-test-run/sources/stable/gh/oampo/dosa/Cargo.toml [INFO] started frobbing oampo/dosa [INFO] finished frobbing oampo/dosa [INFO] frobbed toml for oampo/dosa written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/oampo/dosa/Cargo.toml [INFO] crate oampo/dosa has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting oampo/dosa against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/oampo/dosa:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6c81c2eeb643c1e027d9df8c7b6a131dc2596dd4747dfcad066bf7abdf1413fb [INFO] running `"docker" "start" "-a" "6c81c2eeb643c1e027d9df8c7b6a131dc2596dd4747dfcad066bf7abdf1413fb"` [INFO] [stderr] Checking libc v0.2.29 [INFO] [stderr] Checking macro-attr v0.2.0 [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking aho-corasick v0.6.3 [INFO] [stderr] Checking regex v0.2.2 [INFO] [stderr] Checking dosa v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/token.rs:18:39 [INFO] [stderr] | [INFO] [stderr] 18 | Ok(Node::Identifier { name: name }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/token.rs:34:33 [INFO] [stderr] | [INFO] [stderr] 34 | Ok(Node::List { values: values }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/token.rs:43:35 [INFO] [stderr] | [INFO] [stderr] 43 | Ok(Node::Number { value: value }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/token.rs:85:48 [INFO] [stderr] | [INFO] [stderr] 85 | Ok(Node::FunctionApplication { arguments: arguments}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arguments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/lexer.rs:18:57 [INFO] [stderr] | [INFO] [stderr] 18 | matches.push(TokenMatch { kind: token_kind, mat: mat }); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `mat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/token.rs:18:39 [INFO] [stderr] | [INFO] [stderr] 18 | Ok(Node::Identifier { name: name }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/token.rs:34:33 [INFO] [stderr] | [INFO] [stderr] 34 | Ok(Node::List { values: values }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/token.rs:43:35 [INFO] [stderr] | [INFO] [stderr] 43 | Ok(Node::Number { value: value }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/token.rs:85:48 [INFO] [stderr] | [INFO] [stderr] 85 | Ok(Node::FunctionApplication { arguments: arguments}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arguments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/lexer.rs:18:57 [INFO] [stderr] | [INFO] [stderr] 18 | matches.push(TokenMatch { kind: token_kind, mat: mat }); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `mat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::iter::Peekable` [INFO] [stderr] --> src/core/parser.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::iter::Peekable; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::iter::Peekable` [INFO] [stderr] --> src/core/parser.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::iter::Peekable; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ast` [INFO] [stderr] --> src/main.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | let ast = parser.parse()?; [INFO] [stderr] | ^^^ help: consider using `_ast` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ast` [INFO] [stderr] --> src/main.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | let ast = parser.parse()?; [INFO] [stderr] | ^^^ help: consider using `_ast` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Lambda` [INFO] [stderr] --> src/core/node.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | Lambda, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Value` [INFO] [stderr] --> src/core/node.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | Value, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BinaryOperator` [INFO] [stderr] --> src/core/node.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | BinaryOperator [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/core/token.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | parser.consume(Some(TokenKind::RightBracket)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/core/token.rs:38:17 [INFO] [stderr] | [INFO] [stderr] 38 | parser.consume(Some(TokenKind::RightParenthesis)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/core/token.rs:84:17 [INFO] [stderr] | [INFO] [stderr] 84 | parser.consume(Some(TokenKind::RightParenthesis)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Lambda` [INFO] [stderr] --> src/core/node.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | Lambda, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Value` [INFO] [stderr] --> src/core/node.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | Value, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BinaryOperator` [INFO] [stderr] --> src/core/node.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | BinaryOperator [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/core/lexer.rs:33:11 [INFO] [stderr] | [INFO] [stderr] 33 | while rest.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!rest.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/core/parser.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | parser.advance(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/core/token.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | parser.consume(Some(TokenKind::RightBracket)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/core/token.rs:38:17 [INFO] [stderr] | [INFO] [stderr] 38 | parser.consume(Some(TokenKind::RightParenthesis)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/core/token.rs:84:17 [INFO] [stderr] | [INFO] [stderr] 84 | parser.consume(Some(TokenKind::RightParenthesis)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/core/lexer.rs:33:11 [INFO] [stderr] | [INFO] [stderr] 33 | while rest.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!rest.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/core/parser.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | parser.advance(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.94s [INFO] running `"docker" "inspect" "6c81c2eeb643c1e027d9df8c7b6a131dc2596dd4747dfcad066bf7abdf1413fb"` [INFO] running `"docker" "rm" "-f" "6c81c2eeb643c1e027d9df8c7b6a131dc2596dd4747dfcad066bf7abdf1413fb"` [INFO] [stdout] 6c81c2eeb643c1e027d9df8c7b6a131dc2596dd4747dfcad066bf7abdf1413fb