[INFO] updating cached repository nyghtly-derek/nth-fib [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nyghtly-derek/nth-fib [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nyghtly-derek/nth-fib" "work/ex/clippy-test-run/sources/stable/gh/nyghtly-derek/nth-fib"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nyghtly-derek/nth-fib'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nyghtly-derek/nth-fib" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nyghtly-derek/nth-fib"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nyghtly-derek/nth-fib'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6c16ca10aad859b01bb2f394b202a0440297a4c2 [INFO] sha for GitHub repo nyghtly-derek/nth-fib: 6c16ca10aad859b01bb2f394b202a0440297a4c2 [INFO] validating manifest of nyghtly-derek/nth-fib on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nyghtly-derek/nth-fib on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nyghtly-derek/nth-fib [INFO] finished frobbing nyghtly-derek/nth-fib [INFO] frobbed toml for nyghtly-derek/nth-fib written to work/ex/clippy-test-run/sources/stable/gh/nyghtly-derek/nth-fib/Cargo.toml [INFO] started frobbing nyghtly-derek/nth-fib [INFO] finished frobbing nyghtly-derek/nth-fib [INFO] frobbed toml for nyghtly-derek/nth-fib written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nyghtly-derek/nth-fib/Cargo.toml [INFO] crate nyghtly-derek/nth-fib has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nyghtly-derek/nth-fib against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nyghtly-derek/nth-fib:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cda66cb3b0bbfdee5d269f9e94e92ffea27d05c0c376907f050f4683e831dce6 [INFO] running `"docker" "start" "-a" "cda66cb3b0bbfdee5d269f9e94e92ffea27d05c0c376907f050f4683e831dce6"` [INFO] [stderr] Checking nth_fib v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | return nth_fib [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `nth_fib` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | return line [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | return nth_fib [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `nth_fib` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | return line [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | / match nth_fib { [INFO] [stderr] 20 | | Some(num) => return *num, [INFO] [stderr] 21 | | _ => (), [INFO] [stderr] 22 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(num) = nth_fib { return *num }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | / match nth_fib { [INFO] [stderr] 20 | | Some(num) => return *num, [INFO] [stderr] 21 | | _ => (), [INFO] [stderr] 22 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(num) = nth_fib { return *num }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.50s [INFO] running `"docker" "inspect" "cda66cb3b0bbfdee5d269f9e94e92ffea27d05c0c376907f050f4683e831dce6"` [INFO] running `"docker" "rm" "-f" "cda66cb3b0bbfdee5d269f9e94e92ffea27d05c0c376907f050f4683e831dce6"` [INFO] [stdout] cda66cb3b0bbfdee5d269f9e94e92ffea27d05c0c376907f050f4683e831dce6