[INFO] updating cached repository nullpo-head/ELVM-Interpreter-in-Rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nullpo-head/ELVM-Interpreter-in-Rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nullpo-head/ELVM-Interpreter-in-Rust" "work/ex/clippy-test-run/sources/stable/gh/nullpo-head/ELVM-Interpreter-in-Rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nullpo-head/ELVM-Interpreter-in-Rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nullpo-head/ELVM-Interpreter-in-Rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nullpo-head/ELVM-Interpreter-in-Rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nullpo-head/ELVM-Interpreter-in-Rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1207c2400cd219e90358ca1367857f9f14dc40bc [INFO] sha for GitHub repo nullpo-head/ELVM-Interpreter-in-Rust: 1207c2400cd219e90358ca1367857f9f14dc40bc [INFO] validating manifest of nullpo-head/ELVM-Interpreter-in-Rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nullpo-head/ELVM-Interpreter-in-Rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nullpo-head/ELVM-Interpreter-in-Rust [INFO] finished frobbing nullpo-head/ELVM-Interpreter-in-Rust [INFO] frobbed toml for nullpo-head/ELVM-Interpreter-in-Rust written to work/ex/clippy-test-run/sources/stable/gh/nullpo-head/ELVM-Interpreter-in-Rust/Cargo.toml [INFO] started frobbing nullpo-head/ELVM-Interpreter-in-Rust [INFO] finished frobbing nullpo-head/ELVM-Interpreter-in-Rust [INFO] frobbed toml for nullpo-head/ELVM-Interpreter-in-Rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nullpo-head/ELVM-Interpreter-in-Rust/Cargo.toml [INFO] crate nullpo-head/ELVM-Interpreter-in-Rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nullpo-head/ELVM-Interpreter-in-Rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nullpo-head/ELVM-Interpreter-in-Rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c939c337127cdba127ed442df318a40ef83dff7a8fb107b79c63c022e3c75962 [INFO] running `"docker" "start" "-a" "c939c337127cdba127ed442df318a40ef83dff7a8fb107b79c63c022e3c75962"` [INFO] [stderr] Checking combine v2.3.1 [INFO] [stderr] Checking rust_elvmi v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:173:69 [INFO] [stderr] | [INFO] [stderr] 173 | let src_info = SourceInfo { line: pos.line, column: pos.column, filename: filename }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:188:69 [INFO] [stderr] | [INFO] [stderr] 188 | let src_info = SourceInfo { line: pos.line, column: pos.column, filename: filename }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:350:38 [INFO] [stderr] | [INFO] [stderr] 350 | let mut env = EvalEnv {mem_pc: pc, text: text, data: data, label_map: label_map, ..Default::default()}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:350:50 [INFO] [stderr] | [INFO] [stderr] 350 | let mut env = EvalEnv {mem_pc: pc, text: text, data: data, label_map: label_map, ..Default::default()}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:350:62 [INFO] [stderr] | [INFO] [stderr] 350 | let mut env = EvalEnv {mem_pc: pc, text: text, data: data, label_map: label_map, ..Default::default()}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `label_map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:173:69 [INFO] [stderr] | [INFO] [stderr] 173 | let src_info = SourceInfo { line: pos.line, column: pos.column, filename: filename }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:188:69 [INFO] [stderr] | [INFO] [stderr] 188 | let src_info = SourceInfo { line: pos.line, column: pos.column, filename: filename }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:350:38 [INFO] [stderr] | [INFO] [stderr] 350 | let mut env = EvalEnv {mem_pc: pc, text: text, data: data, label_map: label_map, ..Default::default()}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:350:50 [INFO] [stderr] | [INFO] [stderr] 350 | let mut env = EvalEnv {mem_pc: pc, text: text, data: data, label_map: label_map, ..Default::default()}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:350:62 [INFO] [stderr] | [INFO] [stderr] 350 | let mut env = EvalEnv {mem_pc: pc, text: text, data: data, label_map: label_map, ..Default::default()}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `label_map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:18:25 [INFO] [stderr] | [INFO] [stderr] 18 | const WORD_MASK : u32 = 0xffffff; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:223:9 [INFO] [stderr] | [INFO] [stderr] 223 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:226:9 [INFO] [stderr] | [INFO] [stderr] 226 | / return match operands[0] { [INFO] [stderr] 227 | | Operand::ImmI(subsec) => subsec, [INFO] [stderr] 228 | | _ => panic_with_errorinfo!(src_info, ".text or .data expects only integer as its operands for subsection") [INFO] [stderr] 229 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 226 | match operands[0] { [INFO] [stderr] 227 | Operand::ImmI(subsec) => subsec, [INFO] [stderr] 228 | _ => panic_with_errorinfo!(src_info, ".text or .data expects only integer as its operands for subsection") [INFO] [stderr] 229 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:18:25 [INFO] [stderr] | [INFO] [stderr] 18 | const WORD_MASK : u32 = 0xffffff; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:223:9 [INFO] [stderr] | [INFO] [stderr] 223 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:226:9 [INFO] [stderr] | [INFO] [stderr] 226 | / return match operands[0] { [INFO] [stderr] 227 | | Operand::ImmI(subsec) => subsec, [INFO] [stderr] 228 | | _ => panic_with_errorinfo!(src_info, ".text or .data expects only integer as its operands for subsection") [INFO] [stderr] 229 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 226 | match operands[0] { [INFO] [stderr] 227 | Operand::ImmI(subsec) => subsec, [INFO] [stderr] 228 | _ => panic_with_errorinfo!(src_info, ".text or .data expects only integer as its operands for subsection") [INFO] [stderr] 229 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:134:28 [INFO] [stderr] | [INFO] [stderr] 134 | .or(uint_literal().map(|i| Operand::ImmI(i))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Operand::ImmI` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:135:30 [INFO] [stderr] | [INFO] [stderr] 135 | .or(string_literal().map(|s| Operand::ImmS(s)))).skip(inline_skipable()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Operand::ImmS` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:38:103 [INFO] [stderr] | [INFO] [stderr] 38 | fn resolve_text_labels(text: &mut Vec, label_map: &HashMap, pos_to_resolve: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:134:28 [INFO] [stderr] | [INFO] [stderr] 134 | .or(uint_literal().map(|i| Operand::ImmI(i))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Operand::ImmI` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:135:30 [INFO] [stderr] | [INFO] [stderr] 135 | .or(string_literal().map(|s| Operand::ImmS(s)))).skip(inline_skipable()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Operand::ImmS` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the Vec [INFO] [stderr] --> src/main.rs:41:31 [INFO] [stderr] | [INFO] [stderr] 41 | for operand in operands.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:44:49 [INFO] [stderr] | [INFO] [stderr] 44 | resolved = Some(label_map.get(symbol).expect(&format!("Reference to an undeclared label: {}", &symbol))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Reference to an undeclared label: {}", &symbol))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:56:100 [INFO] [stderr] | [INFO] [stderr] 56 | fn resolve_data_labels(data: &mut Vec, label_map: &HashMap, labels_to_resolve: &Vec<(String, usize)>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(String, usize)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:38:103 [INFO] [stderr] | [INFO] [stderr] 38 | fn resolve_text_labels(text: &mut Vec, label_map: &HashMap, pos_to_resolve: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:77:25 [INFO] [stderr] | [INFO] [stderr] 77 | fn expect_len(operands: &Vec, len: usize, opcode: &Opcode, src_info: &SourceInfo) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Operand]` [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the Vec [INFO] [stderr] --> src/main.rs:41:31 [INFO] [stderr] | [INFO] [stderr] 41 | for operand in operands.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:44:49 [INFO] [stderr] | [INFO] [stderr] 44 | resolved = Some(label_map.get(symbol).expect(&format!("Reference to an undeclared label: {}", &symbol))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Reference to an undeclared label: {}", &symbol))` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:56:100 [INFO] [stderr] | [INFO] [stderr] 56 | fn resolve_data_labels(data: &mut Vec, label_map: &HashMap, labels_to_resolve: &Vec<(String, usize)>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(String, usize)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:77:25 [INFO] [stderr] | [INFO] [stderr] 77 | fn expect_len(operands: &Vec, len: usize, opcode: &Opcode, src_info: &SourceInfo) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Operand]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:222:10 [INFO] [stderr] | [INFO] [stderr] 222 | if operands.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `operands.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:261:16 [INFO] [stderr] | [INFO] [stderr] 261 | for _ in seg_to_write.len()..(subsection + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `seg_to_write.len()..=subsection` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/main.rs:306:3 [INFO] [stderr] | [INFO] [stderr] 306 | / fn index_mut<'a>(&'a mut self, register: Register) -> &'a mut u32 { [INFO] [stderr] 307 | | match register { [INFO] [stderr] 308 | | Register::A => &mut self.a, [INFO] [stderr] 309 | | Register::B => &mut self.b, [INFO] [stderr] ... | [INFO] [stderr] 314 | | } [INFO] [stderr] 315 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:222:10 [INFO] [stderr] | [INFO] [stderr] 222 | if operands.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `operands.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:368:11 [INFO] [stderr] | [INFO] [stderr] 368 | io::stdout().write(&[src(&operands[0], &env.registers) as u8]).expect("write error"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:261:16 [INFO] [stderr] | [INFO] [stderr] 261 | for _ in seg_to_write.len()..(subsection + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `seg_to_write.len()..=subsection` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/main.rs:372:11 [INFO] [stderr] | [INFO] [stderr] 372 | io::stdin().read(&mut buf).expect("read error"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/main.rs:306:3 [INFO] [stderr] | [INFO] [stderr] 306 | / fn index_mut<'a>(&'a mut self, register: Register) -> &'a mut u32 { [INFO] [stderr] 307 | | match register { [INFO] [stderr] 308 | | Register::A => &mut self.a, [INFO] [stderr] 309 | | Register::B => &mut self.b, [INFO] [stderr] ... | [INFO] [stderr] 314 | | } [INFO] [stderr] 315 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:373:52 [INFO] [stderr] | [INFO] [stderr] 373 | *dst(&operands[0], &mut env.registers) = buf[0] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/main.rs:417:6 [INFO] [stderr] | [INFO] [stderr] 417 | if optparse.free.len() < 1 || optparse.opt_present("h") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `optparse.free.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:368:11 [INFO] [stderr] | [INFO] [stderr] 368 | io::stdout().write(&[src(&operands[0], &env.registers) as u8]).expect("write error"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/main.rs:372:11 [INFO] [stderr] | [INFO] [stderr] 372 | io::stdin().read(&mut buf).expect("read error"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:373:52 [INFO] [stderr] | [INFO] [stderr] 373 | *dst(&operands[0], &mut env.registers) = buf[0] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust_elvmi`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/main.rs:417:6 [INFO] [stderr] | [INFO] [stderr] 417 | if optparse.free.len() < 1 || optparse.opt_present("h") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `optparse.free.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust_elvmi`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "c939c337127cdba127ed442df318a40ef83dff7a8fb107b79c63c022e3c75962"` [INFO] running `"docker" "rm" "-f" "c939c337127cdba127ed442df318a40ef83dff7a8fb107b79c63c022e3c75962"` [INFO] [stdout] c939c337127cdba127ed442df318a40ef83dff7a8fb107b79c63c022e3c75962