[INFO] updating cached repository ntdef/groupby [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ntdef/groupby [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ntdef/groupby" "work/ex/clippy-test-run/sources/stable/gh/ntdef/groupby"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ntdef/groupby'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ntdef/groupby" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ntdef/groupby"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ntdef/groupby'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1a3c86b0bc8d729e58824bcfa162f24a4b91031d [INFO] sha for GitHub repo ntdef/groupby: 1a3c86b0bc8d729e58824bcfa162f24a4b91031d [INFO] validating manifest of ntdef/groupby on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ntdef/groupby on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ntdef/groupby [INFO] finished frobbing ntdef/groupby [INFO] frobbed toml for ntdef/groupby written to work/ex/clippy-test-run/sources/stable/gh/ntdef/groupby/Cargo.toml [INFO] started frobbing ntdef/groupby [INFO] finished frobbing ntdef/groupby [INFO] frobbed toml for ntdef/groupby written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ntdef/groupby/Cargo.toml [INFO] crate ntdef/groupby has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ntdef/groupby against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ntdef/groupby:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8ec7d4c37553a33eeed13c58c394e74911b207264005cd5bda659db61af37315 [INFO] running `"docker" "start" "-a" "8ec7d4c37553a33eeed13c58c394e74911b207264005cd5bda659db61af37315"` [INFO] [stderr] Checking unicode-segmentation v0.1.3 [INFO] [stderr] Checking unicode-width v0.1.3 [INFO] [stderr] Checking vec_map v0.6.0 [INFO] [stderr] Checking threadpool v1.3.2 [INFO] [stderr] Checking term_size v0.2.1 [INFO] [stderr] Checking clap v2.19.2 [INFO] [stderr] Checking groupby v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/process.rs:15:16 [INFO] [stderr] | [INFO] [stderr] 15 | Group {key: key, data: data} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/process.rs:15:26 [INFO] [stderr] | [INFO] [stderr] 15 | Group {key: key, data: data} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/process.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | tx: tx, [INFO] [stderr] | ^^^^^^ help: replace it with: `tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/process.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | rx: rx, [INFO] [stderr] | ^^^^^^ help: replace it with: `rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/process.rs:74:48 [INFO] [stderr] | [INFO] [stderr] 74 | let proc_result = GroupProcResult {idx: idx, key: key, data: Some(bufout)}; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/process.rs:74:58 [INFO] [stderr] | [INFO] [stderr] 74 | let proc_result = GroupProcResult {idx: idx, key: key, data: Some(bufout)}; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ranges.rs:31:44 [INFO] [stderr] | [INFO] [stderr] 31 | if low > 0 { Ok(Range{ low: low, high: MAX - 1}) } else { Err(field) } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `low` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ranges.rs:38:53 [INFO] [stderr] | [INFO] [stderr] 38 | if high > 0 { Ok(Range{ low: 1, high: high}) } else { Err(field) } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `high` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ranges.rs:47:40 [INFO] [stderr] | [INFO] [stderr] 47 | Ok(Range { low: low, high: high }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `low` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ranges.rs:47:50 [INFO] [stderr] | [INFO] [stderr] 47 | Ok(Range { low: low, high: high }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `high` [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/process.rs:15:16 [INFO] [stderr] | [INFO] [stderr] 15 | Group {key: key, data: data} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/process.rs:15:26 [INFO] [stderr] | [INFO] [stderr] 15 | Group {key: key, data: data} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/process.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | tx: tx, [INFO] [stderr] | ^^^^^^ help: replace it with: `tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/process.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | rx: rx, [INFO] [stderr] | ^^^^^^ help: replace it with: `rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/process.rs:74:48 [INFO] [stderr] | [INFO] [stderr] 74 | let proc_result = GroupProcResult {idx: idx, key: key, data: Some(bufout)}; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/process.rs:74:58 [INFO] [stderr] | [INFO] [stderr] 74 | let proc_result = GroupProcResult {idx: idx, key: key, data: Some(bufout)}; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ranges.rs:31:44 [INFO] [stderr] | [INFO] [stderr] 31 | if low > 0 { Ok(Range{ low: low, high: MAX - 1}) } else { Err(field) } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `low` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ranges.rs:38:53 [INFO] [stderr] | [INFO] [stderr] 38 | if high > 0 { Ok(Range{ low: 1, high: high}) } else { Err(field) } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `high` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ranges.rs:47:40 [INFO] [stderr] | [INFO] [stderr] 47 | Ok(Range { low: low, high: high }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `low` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ranges.rs:47:50 [INFO] [stderr] | [INFO] [stderr] 47 | Ok(Range { low: low, high: high }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `high` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ranges.rs:29:35 [INFO] [stderr] | [INFO] [stderr] 29 | (Some(n), Some(m)) if m.len() == 0 => { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `m.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ranges.rs:36:35 [INFO] [stderr] | [INFO] [stderr] 36 | (Some(n), Some(m)) if n.len() == 0 => { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `n.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/main.rs:82:35 [INFO] [stderr] | [INFO] [stderr] 82 | let rdr: Box = match input.as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try this: `input` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:122:20 [INFO] [stderr] | [INFO] [stderr] 122 | if let Err(_) = std::io::stdout() [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 122 | if std::io::stdout() [INFO] [stderr] 123 | .write_fmt(format_args!("{}{}{}\n", p.key, separator, line)).is_err(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ranges.rs:29:35 [INFO] [stderr] | [INFO] [stderr] 29 | (Some(n), Some(m)) if m.len() == 0 => { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `m.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ranges.rs:36:35 [INFO] [stderr] | [INFO] [stderr] 36 | (Some(n), Some(m)) if n.len() == 0 => { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `n.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/main.rs:82:35 [INFO] [stderr] | [INFO] [stderr] 82 | let rdr: Box = match input.as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try this: `input` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:122:20 [INFO] [stderr] | [INFO] [stderr] 122 | if let Err(_) = std::io::stdout() [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 122 | if std::io::stdout() [INFO] [stderr] 123 | .write_fmt(format_args!("{}{}{}\n", p.key, separator, line)).is_err(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.78s [INFO] running `"docker" "inspect" "8ec7d4c37553a33eeed13c58c394e74911b207264005cd5bda659db61af37315"` [INFO] running `"docker" "rm" "-f" "8ec7d4c37553a33eeed13c58c394e74911b207264005cd5bda659db61af37315"` [INFO] [stdout] 8ec7d4c37553a33eeed13c58c394e74911b207264005cd5bda659db61af37315