[INFO] updating cached repository nryaskin/simulator [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nryaskin/simulator [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nryaskin/simulator" "work/ex/clippy-test-run/sources/stable/gh/nryaskin/simulator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nryaskin/simulator'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nryaskin/simulator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nryaskin/simulator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nryaskin/simulator'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f5762c02126635b95f49a334f22da3b10fd3d1fc [INFO] sha for GitHub repo nryaskin/simulator: f5762c02126635b95f49a334f22da3b10fd3d1fc [INFO] validating manifest of nryaskin/simulator on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nryaskin/simulator on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nryaskin/simulator [INFO] finished frobbing nryaskin/simulator [INFO] frobbed toml for nryaskin/simulator written to work/ex/clippy-test-run/sources/stable/gh/nryaskin/simulator/Cargo.toml [INFO] started frobbing nryaskin/simulator [INFO] finished frobbing nryaskin/simulator [INFO] frobbed toml for nryaskin/simulator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nryaskin/simulator/Cargo.toml [INFO] crate nryaskin/simulator has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nryaskin/simulator against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nryaskin/simulator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0709634eb283bd44ff1c8c75e35028d77c4d5e1c9eeb3787d2bf6e9e6f24f468 [INFO] running `"docker" "start" "-a" "0709634eb283bd44ff1c8c75e35028d77c4d5e1c9eeb3787d2bf6e9e6f24f468"` [INFO] [stderr] Checking disassembler v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/chip8/mod.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | let mut file = File::open(file_path).unwrap(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `opcode` [INFO] [stderr] --> src/chip8/cpu.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | opcode : u16, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `index` [INFO] [stderr] --> src/chip8/cpu.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | index: u16, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `registers` [INFO] [stderr] --> src/chip8/cpu.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | registers: [u8; CHIP8_REGISTER_COUNT], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `stack` [INFO] [stderr] --> src/chip8/cpu.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | stack: [u16; CHIP8_STACK_SIZE], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `sp` [INFO] [stderr] --> src/chip8/cpu.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | sp: u16, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `delay_timer` [INFO] [stderr] --> src/chip8/cpu.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | delay_timer: u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `sound_timer` [INFO] [stderr] --> src/chip8/cpu.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | sound_timer: u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `gfx` [INFO] [stderr] --> src/chip8/graphics.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | gfx: [u8; 64 * 32], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `mem_read` [INFO] [stderr] --> src/chip8/memory.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn mem_read(&self, addr: u16) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `mem_size` [INFO] [stderr] --> src/chip8/memory.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn mem_size(&self) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Keypad` [INFO] [stderr] --> src/chip8/keypad.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub struct Keypad { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `cpu` [INFO] [stderr] --> src/chip8/mod.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | cpu: CPU, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `gr` [INFO] [stderr] --> src/chip8/mod.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | gr: Graphics, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_mem` [INFO] [stderr] --> src/chip8/mod.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn get_mem(&self, addr: u16) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `load_game` [INFO] [stderr] --> src/chip8/mod.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn load_game(&mut self, file_path: &String) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/chip8/mod.rs:41:44 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn load_game(&mut self, file_path: &String) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/chip8/mod.rs:48:4 [INFO] [stderr] | [INFO] [stderr] 48 | j = j + 2; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `j += 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/chip8/mod.rs:49:60 [INFO] [stderr] | [INFO] [stderr] 49 | self.memory.mem_write(self.cpu.pc + i as u16, ((msb as u16) << 8) | (lsb as u16)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(msb)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/chip8/mod.rs:49:81 [INFO] [stderr] | [INFO] [stderr] 49 | self.memory.mem_write(self.cpu.pc + i as u16, ((msb as u16) << 8) | (lsb as u16)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(lsb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/chip8/mod.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | let mut file = File::open(file_path).unwrap(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `opcode` [INFO] [stderr] --> src/chip8/cpu.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | opcode : u16, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `index` [INFO] [stderr] --> src/chip8/cpu.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | index: u16, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `registers` [INFO] [stderr] --> src/chip8/cpu.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | registers: [u8; CHIP8_REGISTER_COUNT], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `stack` [INFO] [stderr] --> src/chip8/cpu.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | stack: [u16; CHIP8_STACK_SIZE], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `sp` [INFO] [stderr] --> src/chip8/cpu.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | sp: u16, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `delay_timer` [INFO] [stderr] --> src/chip8/cpu.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | delay_timer: u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `sound_timer` [INFO] [stderr] --> src/chip8/cpu.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | sound_timer: u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `gfx` [INFO] [stderr] --> src/chip8/graphics.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | gfx: [u8; 64 * 32], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `mem_read` [INFO] [stderr] --> src/chip8/memory.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn mem_read(&self, addr: u16) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `mem_size` [INFO] [stderr] --> src/chip8/memory.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn mem_size(&self) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Keypad` [INFO] [stderr] --> src/chip8/keypad.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub struct Keypad { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `cpu` [INFO] [stderr] --> src/chip8/mod.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | cpu: CPU, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `gr` [INFO] [stderr] --> src/chip8/mod.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | gr: Graphics, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_mem` [INFO] [stderr] --> src/chip8/mod.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn get_mem(&self, addr: u16) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `load_game` [INFO] [stderr] --> src/chip8/mod.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn load_game(&mut self, file_path: &String) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/chip8/mod.rs:41:44 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn load_game(&mut self, file_path: &String) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/chip8/mod.rs:48:4 [INFO] [stderr] | [INFO] [stderr] 48 | j = j + 2; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `j += 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/chip8/mod.rs:49:60 [INFO] [stderr] | [INFO] [stderr] 49 | self.memory.mem_write(self.cpu.pc + i as u16, ((msb as u16) << 8) | (lsb as u16)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(msb)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/chip8/mod.rs:49:81 [INFO] [stderr] | [INFO] [stderr] 49 | self.memory.mem_write(self.cpu.pc + i as u16, ((msb as u16) << 8) | (lsb as u16)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(lsb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.59s [INFO] running `"docker" "inspect" "0709634eb283bd44ff1c8c75e35028d77c4d5e1c9eeb3787d2bf6e9e6f24f468"` [INFO] running `"docker" "rm" "-f" "0709634eb283bd44ff1c8c75e35028d77c4d5e1c9eeb3787d2bf6e9e6f24f468"` [INFO] [stdout] 0709634eb283bd44ff1c8c75e35028d77c4d5e1c9eeb3787d2bf6e9e6f24f468