[INFO] updating cached repository nosferatu500/Aurora_VB [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nosferatu500/Aurora_VB [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nosferatu500/Aurora_VB" "work/ex/clippy-test-run/sources/stable/gh/nosferatu500/Aurora_VB"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nosferatu500/Aurora_VB'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nosferatu500/Aurora_VB" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nosferatu500/Aurora_VB"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nosferatu500/Aurora_VB'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 66cdef0445cc54333d6bc3c7b8b3fb4c72f11bfd [INFO] sha for GitHub repo nosferatu500/Aurora_VB: 66cdef0445cc54333d6bc3c7b8b3fb4c72f11bfd [INFO] validating manifest of nosferatu500/Aurora_VB on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nosferatu500/Aurora_VB on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nosferatu500/Aurora_VB [INFO] finished frobbing nosferatu500/Aurora_VB [INFO] frobbed toml for nosferatu500/Aurora_VB written to work/ex/clippy-test-run/sources/stable/gh/nosferatu500/Aurora_VB/Cargo.toml [INFO] started frobbing nosferatu500/Aurora_VB [INFO] finished frobbing nosferatu500/Aurora_VB [INFO] frobbed toml for nosferatu500/Aurora_VB written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nosferatu500/Aurora_VB/Cargo.toml [INFO] crate nosferatu500/Aurora_VB has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nosferatu500/Aurora_VB against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nosferatu500/Aurora_VB:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4df79ddd6b3f596c7fc7ddc1965cf5a6644229c61e4cc1891c7e2696adc5386c [INFO] running `"docker" "start" "-a" "4df79ddd6b3f596c7fc7ddc1965cf5a6644229c61e4cc1891c7e2696adc5386c"` [INFO] [stderr] Checking encoding-index-korean v1.20141219.5 [INFO] [stderr] Checking encoding-index-singlebyte v1.20141219.5 [INFO] [stderr] Checking encoding-index-simpchinese v1.20141219.5 [INFO] [stderr] Checking encoding-index-japanese v1.20141219.5 [INFO] [stderr] Checking encoding-index-tradchinese v1.20141219.5 [INFO] [stderr] Checking encoding v0.2.33 [INFO] [stderr] Checking aurora_vb v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interconnect.rs:9:24 [INFO] [stderr] | [INFO] [stderr] 9 | Interconnect { rom: rom } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rom` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interconnect.rs:9:24 [INFO] [stderr] | [INFO] [stderr] 9 | Interconnect { rom: rom } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rom` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rom.rs:14:29 [INFO] [stderr] | [INFO] [stderr] 14 | const MAX_ROM_SIZE: usize = 16777216; // 16 Mb. [INFO] [stderr] | ^^^^^^^^ help: consider: `16_777_216` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:13:27 [INFO] [stderr] | [INFO] [stderr] 13 | let addr = addr & 0x07ffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x07ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:15:20 [INFO] [stderr] | [INFO] [stderr] 15 | if addr >= 0x07000000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0700_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:28:27 [INFO] [stderr] | [INFO] [stderr] 28 | let addr = addr & 0x07fffffe; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x07ff_fffe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:35:27 [INFO] [stderr] | [INFO] [stderr] 35 | let addr = addr & 0x07ffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x07ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:37:20 [INFO] [stderr] | [INFO] [stderr] 37 | if addr == 0x02000024 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0200_0024` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:47:27 [INFO] [stderr] | [INFO] [stderr] 47 | let addr = addr & 0xfffffffc; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_fffc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | 0b101111 => Opcode::Movhi, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | 0b101000 => Opcode::Movea, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | 0b010000 => Opcode::MovImm, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | 0b110100 => Opcode::Stb, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | 0b000110 => Opcode::Jmp, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | 0b000010 => Opcode::Sub, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | 0b111111 => Opcode::Outw, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/nvc.rs:28:21 [INFO] [stderr] | [INFO] [stderr] 28 | reg_pc: 0xfffffff0, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_fff0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/nvc.rs:118:69 [INFO] [stderr] | [INFO] [stderr] 118 | self.psw_overflow = (((lhs ^ rhs) & !(rhs ^ res)) & 0x80000000) != 0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/nvc.rs:146:33 [INFO] [stderr] | [INFO] [stderr] 146 | self.psw_sign = value & 0x80000000 != 0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:89:22 [INFO] [stderr] | [INFO] [stderr] 89 | let mut cursor = 0xfffffff0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_fff0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rom.rs:14:29 [INFO] [stderr] | [INFO] [stderr] 14 | const MAX_ROM_SIZE: usize = 16777216; // 16 Mb. [INFO] [stderr] | ^^^^^^^^ help: consider: `16_777_216` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:13:27 [INFO] [stderr] | [INFO] [stderr] 13 | let addr = addr & 0x07ffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x07ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:15:20 [INFO] [stderr] | [INFO] [stderr] 15 | if addr >= 0x07000000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0700_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:28:27 [INFO] [stderr] | [INFO] [stderr] 28 | let addr = addr & 0x07fffffe; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x07ff_fffe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:35:27 [INFO] [stderr] | [INFO] [stderr] 35 | let addr = addr & 0x07ffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x07ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:37:20 [INFO] [stderr] | [INFO] [stderr] 37 | if addr == 0x02000024 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0200_0024` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:47:27 [INFO] [stderr] | [INFO] [stderr] 47 | let addr = addr & 0xfffffffc; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_fffc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | 0b101111 => Opcode::Movhi, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | 0b101000 => Opcode::Movea, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | 0b010000 => Opcode::MovImm, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | 0b110100 => Opcode::Stb, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | 0b000110 => Opcode::Jmp, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | 0b000010 => Opcode::Sub, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | 0b111111 => Opcode::Outw, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/nvc.rs:28:21 [INFO] [stderr] | [INFO] [stderr] 28 | reg_pc: 0xfffffff0, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_fff0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/nvc.rs:118:69 [INFO] [stderr] | [INFO] [stderr] 118 | self.psw_overflow = (((lhs ^ rhs) & !(rhs ^ res)) & 0x80000000) != 0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/nvc.rs:146:33 [INFO] [stderr] | [INFO] [stderr] 146 | self.psw_sign = value & 0x80000000 != 0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:89:22 [INFO] [stderr] | [INFO] [stderr] 89 | let mut cursor = 0xfffffff0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_fff0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cycles` [INFO] [stderr] --> src/interconnect.rs:54:30 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn cycles(&mut self, cycles: usize) { [INFO] [stderr] | ^^^^^^ help: consider using `_cycles` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/interconnect.rs:31:10 [INFO] [stderr] | [INFO] [stderr] 31 | ((high_byte as u16) << 8) | (low_byte as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(high_byte)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/interconnect.rs:31:37 [INFO] [stderr] | [INFO] [stderr] 31 | ((high_byte as u16) << 8) | (low_byte as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(low_byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/instruction.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / match self { [INFO] [stderr] 31 | | &Opcode::Movhi => InstructionFormat::V, [INFO] [stderr] 32 | | &Opcode::Movea => InstructionFormat::V, [INFO] [stderr] 33 | | &Opcode::Jmp => InstructionFormat::I, [INFO] [stderr] ... | [INFO] [stderr] 37 | | &Opcode::Stb => InstructionFormat::VI, [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 30 | match *self { [INFO] [stderr] 31 | Opcode::Movhi => InstructionFormat::V, [INFO] [stderr] 32 | Opcode::Movea => InstructionFormat::V, [INFO] [stderr] 33 | Opcode::Jmp => InstructionFormat::I, [INFO] [stderr] 34 | Opcode::Sub => InstructionFormat::I, [INFO] [stderr] 35 | Opcode::MovImm => InstructionFormat::II, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/instruction.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | / match self { [INFO] [stderr] 43 | | &Opcode::Jmp => 3, [INFO] [stderr] 44 | | &Opcode::MovImm => 1, [INFO] [stderr] 45 | | &Opcode::Sub => 1, [INFO] [stderr] ... | [INFO] [stderr] 49 | | &Opcode::Outw => 1, [INFO] [stderr] 50 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 42 | match *self { [INFO] [stderr] 43 | Opcode::Jmp => 3, [INFO] [stderr] 44 | Opcode::MovImm => 1, [INFO] [stderr] 45 | Opcode::Sub => 1, [INFO] [stderr] 46 | Opcode::Movea => 1, [INFO] [stderr] 47 | Opcode::Movhi => 1, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/instruction.rs:56:24 [INFO] [stderr] | [INFO] [stderr] 56 | let mnemonic = match self { [INFO] [stderr] | ________________________^ [INFO] [stderr] 57 | | &Opcode::Sub => "sub", [INFO] [stderr] 58 | | &Opcode::Movhi => "movhi", [INFO] [stderr] 59 | | &Opcode::Movea => "movea", [INFO] [stderr] ... | [INFO] [stderr] 63 | | &Opcode::Stb => "st.b", [INFO] [stderr] 64 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 56 | let mnemonic = match *self { [INFO] [stderr] 57 | Opcode::Sub => "sub", [INFO] [stderr] 58 | Opcode::Movhi => "movhi", [INFO] [stderr] 59 | Opcode::Movea => "movea", [INFO] [stderr] 60 | Opcode::MovImm => "mov", [INFO] [stderr] 61 | Opcode::Jmp => "jmp", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/instruction.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | / match self { [INFO] [stderr] 80 | | &InstructionFormat::I => false, [INFO] [stderr] 81 | | &InstructionFormat::II => false, [INFO] [stderr] 82 | | &InstructionFormat::V => true, [INFO] [stderr] 83 | | &InstructionFormat::VI => true, [INFO] [stderr] 84 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 79 | match *self { [INFO] [stderr] 80 | InstructionFormat::I => false, [INFO] [stderr] 81 | InstructionFormat::II => false, [INFO] [stderr] 82 | InstructionFormat::V => true, [INFO] [stderr] 83 | InstructionFormat::VI => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/nvc.rs:68:29 [INFO] [stderr] | [INFO] [stderr] 68 | (if self.psw_zero { 1 << 0 } else { 0 }) | [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/nvc.rs:126:59 [INFO] [stderr] | [INFO] [stderr] 126 | let res = self.reg_gpr(reg1).wrapping_add((imm16 as u32) << 16); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(imm16)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cycles` [INFO] [stderr] --> src/interconnect.rs:54:30 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn cycles(&mut self, cycles: usize) { [INFO] [stderr] | ^^^^^^ help: consider using `_cycles` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/interconnect.rs:31:10 [INFO] [stderr] | [INFO] [stderr] 31 | ((high_byte as u16) << 8) | (low_byte as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(high_byte)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/interconnect.rs:31:37 [INFO] [stderr] | [INFO] [stderr] 31 | ((high_byte as u16) << 8) | (low_byte as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(low_byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/instruction.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / match self { [INFO] [stderr] 31 | | &Opcode::Movhi => InstructionFormat::V, [INFO] [stderr] 32 | | &Opcode::Movea => InstructionFormat::V, [INFO] [stderr] 33 | | &Opcode::Jmp => InstructionFormat::I, [INFO] [stderr] ... | [INFO] [stderr] 37 | | &Opcode::Stb => InstructionFormat::VI, [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 30 | match *self { [INFO] [stderr] 31 | Opcode::Movhi => InstructionFormat::V, [INFO] [stderr] 32 | Opcode::Movea => InstructionFormat::V, [INFO] [stderr] 33 | Opcode::Jmp => InstructionFormat::I, [INFO] [stderr] 34 | Opcode::Sub => InstructionFormat::I, [INFO] [stderr] 35 | Opcode::MovImm => InstructionFormat::II, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/instruction.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | / match self { [INFO] [stderr] 43 | | &Opcode::Jmp => 3, [INFO] [stderr] 44 | | &Opcode::MovImm => 1, [INFO] [stderr] 45 | | &Opcode::Sub => 1, [INFO] [stderr] ... | [INFO] [stderr] 49 | | &Opcode::Outw => 1, [INFO] [stderr] 50 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 42 | match *self { [INFO] [stderr] 43 | Opcode::Jmp => 3, [INFO] [stderr] 44 | Opcode::MovImm => 1, [INFO] [stderr] 45 | Opcode::Sub => 1, [INFO] [stderr] 46 | Opcode::Movea => 1, [INFO] [stderr] 47 | Opcode::Movhi => 1, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/instruction.rs:56:24 [INFO] [stderr] | [INFO] [stderr] 56 | let mnemonic = match self { [INFO] [stderr] | ________________________^ [INFO] [stderr] 57 | | &Opcode::Sub => "sub", [INFO] [stderr] 58 | | &Opcode::Movhi => "movhi", [INFO] [stderr] 59 | | &Opcode::Movea => "movea", [INFO] [stderr] ... | [INFO] [stderr] 63 | | &Opcode::Stb => "st.b", [INFO] [stderr] 64 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 56 | let mnemonic = match *self { [INFO] [stderr] 57 | Opcode::Sub => "sub", [INFO] [stderr] 58 | Opcode::Movhi => "movhi", [INFO] [stderr] 59 | Opcode::Movea => "movea", [INFO] [stderr] 60 | Opcode::MovImm => "mov", [INFO] [stderr] 61 | Opcode::Jmp => "jmp", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/instruction.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | / match self { [INFO] [stderr] 80 | | &InstructionFormat::I => false, [INFO] [stderr] 81 | | &InstructionFormat::II => false, [INFO] [stderr] 82 | | &InstructionFormat::V => true, [INFO] [stderr] 83 | | &InstructionFormat::VI => true, [INFO] [stderr] 84 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 79 | match *self { [INFO] [stderr] 80 | InstructionFormat::I => false, [INFO] [stderr] 81 | InstructionFormat::II => false, [INFO] [stderr] 82 | InstructionFormat::V => true, [INFO] [stderr] 83 | InstructionFormat::VI => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/nvc.rs:68:29 [INFO] [stderr] | [INFO] [stderr] 68 | (if self.psw_zero { 1 << 0 } else { 0 }) | [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/nvc.rs:126:59 [INFO] [stderr] | [INFO] [stderr] 126 | let res = self.reg_gpr(reg1).wrapping_add((imm16 as u32) << 16); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(imm16)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.47s [INFO] running `"docker" "inspect" "4df79ddd6b3f596c7fc7ddc1965cf5a6644229c61e4cc1891c7e2696adc5386c"` [INFO] running `"docker" "rm" "-f" "4df79ddd6b3f596c7fc7ddc1965cf5a6644229c61e4cc1891c7e2696adc5386c"` [INFO] [stdout] 4df79ddd6b3f596c7fc7ddc1965cf5a6644229c61e4cc1891c7e2696adc5386c