[INFO] updating cached repository nosferatu500/Aurora_R3000 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nosferatu500/Aurora_R3000 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nosferatu500/Aurora_R3000" "work/ex/clippy-test-run/sources/stable/gh/nosferatu500/Aurora_R3000"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nosferatu500/Aurora_R3000'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nosferatu500/Aurora_R3000" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nosferatu500/Aurora_R3000"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nosferatu500/Aurora_R3000'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b26c78ae3b4fa13df25e2b3c847d8ab21f3c78d2 [INFO] sha for GitHub repo nosferatu500/Aurora_R3000: b26c78ae3b4fa13df25e2b3c847d8ab21f3c78d2 [INFO] validating manifest of nosferatu500/Aurora_R3000 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nosferatu500/Aurora_R3000 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nosferatu500/Aurora_R3000 [INFO] finished frobbing nosferatu500/Aurora_R3000 [INFO] frobbed toml for nosferatu500/Aurora_R3000 written to work/ex/clippy-test-run/sources/stable/gh/nosferatu500/Aurora_R3000/Cargo.toml [INFO] started frobbing nosferatu500/Aurora_R3000 [INFO] finished frobbing nosferatu500/Aurora_R3000 [INFO] frobbed toml for nosferatu500/Aurora_R3000 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nosferatu500/Aurora_R3000/Cargo.toml [INFO] crate nosferatu500/Aurora_R3000 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nosferatu500/Aurora_R3000 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nosferatu500/Aurora_R3000:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 36bc736ed24aa04928b4e24b56c3dd017f6b98cdbe1a573c87e3c65d90c8d781 [INFO] running `"docker" "start" "-a" "36bc736ed24aa04928b4e24b56c3dd017f6b98cdbe1a573c87e3c65d90c8d781"` [INFO] [stderr] Checking PSX v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bios.rs:20:23 [INFO] [stderr] | [INFO] [stderr] 20 | Ok(Bios { data: data }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interconnect.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | bios: bios, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bios` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bios.rs:20:23 [INFO] [stderr] | [INFO] [stderr] 20 | Ok(Bios { data: data }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interconnect.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | bios: bios, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bios` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:25:21 [INFO] [stderr] | [INFO] [stderr] 25 | 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:25:33 [INFO] [stderr] | [INFO] [stderr] 25 | 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:25:45 [INFO] [stderr] | [INFO] [stderr] 25 | 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | 0x7fffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | 0x1fffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | 0xffffffff, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:31:21 [INFO] [stderr] | [INFO] [stderr] 31 | 0xffffffff, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:39:35 [INFO] [stderr] | [INFO] [stderr] 39 | pub const BIOS: Range = Range(0x1fc00000, 512 * 1024); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1fc0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:41:34 [INFO] [stderr] | [INFO] [stderr] 41 | pub const RAM: Range = Range(0x00000000, 2 * 1024 * 1024); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:43:42 [INFO] [stderr] | [INFO] [stderr] 43 | pub const MEM_CONTROL: Range = Range(0x1f801000, 36); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1f80_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:45:39 [INFO] [stderr] | [INFO] [stderr] 45 | pub const RAM_SIZE: Range = Range(0x1f801060, 4); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1f80_1060` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:47:44 [INFO] [stderr] | [INFO] [stderr] 47 | pub const CACHE_CONTROL: Range = Range(0xfffe0130, 4); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xfffe_0130` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:49:34 [INFO] [stderr] | [INFO] [stderr] 49 | pub const SPU: Range = Range(0x1f801c00, 640); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1f80_1c00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:51:42 [INFO] [stderr] | [INFO] [stderr] 51 | pub const EXPANSION_1: Range = Range(0x1f000000, 512 * 1024); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1f00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:52:42 [INFO] [stderr] | [INFO] [stderr] 52 | pub const EXPANSION_2: Range = Range(0x1f802000, 66); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1f80_2000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:54:48 [INFO] [stderr] | [INFO] [stderr] 54 | pub const INTERRUPT_CONTROL: Range = Range(0x1f801070, 8); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1f80_1070` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:56:37 [INFO] [stderr] | [INFO] [stderr] 56 | pub const TIMERS: Range = Range(0x1f801100, 48); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1f80_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:58:34 [INFO] [stderr] | [INFO] [stderr] 58 | pub const DMA: Range = Range(0x1f801080, 128); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1f80_1080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:60:34 [INFO] [stderr] | [INFO] [stderr] 60 | pub const GPU: Range = Range(0x1f801810, 8); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1f80_1810` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:178:34 [INFO] [stderr] | [INFO] [stderr] 178 | 0 => if value != 0x1f000000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1f00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:181:34 [INFO] [stderr] | [INFO] [stderr] 181 | 4 => if value != 0x1f802000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1f80_2000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:266:22 [INFO] [stderr] | [INFO] [stderr] 266 | 4 => 0x1c000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1c00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:347:41 [INFO] [stderr] | [INFO] [stderr] 347 | let mut addr = channel.base() & 0x1ffffc; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001f_fffc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:363:37 [INFO] [stderr] | [INFO] [stderr] 363 | addr = (addr + 4) & 0x1ffffc; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001f_fffc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:372:25 [INFO] [stderr] | [INFO] [stderr] 372 | if header & 0x800000 != 0 { [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0080_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:376:29 [INFO] [stderr] | [INFO] [stderr] 376 | addr = header & 0x1ffffc; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001f_fffc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:398:42 [INFO] [stderr] | [INFO] [stderr] 398 | let current_address = addr & 0x1ffffc; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001f_fffc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:412:34 [INFO] [stderr] | [INFO] [stderr] 412 | 1 => 0xffffff, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:413:57 [INFO] [stderr] | [INFO] [stderr] 413 | _ => addr.wrapping_sub(4) & 0x1fffff, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001f_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:31:25 [INFO] [stderr] | [INFO] [stderr] 31 | let mut regs = [0xdeadbeef; 32]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:35:18 [INFO] [stderr] | [INFO] [stderr] 35 | let pc = 0xbfc00000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xbfc0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | hi: 0xdeadbeef, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | lo: 0xdeadbeef, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:52:25 [INFO] [stderr] | [INFO] [stderr] 52 | current_pc: 0xdeadbeef, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:54:20 [INFO] [stderr] | [INFO] [stderr] 54 | cause: 0xdeadbeef, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:56:18 [INFO] [stderr] | [INFO] [stderr] 56 | epc: 0xdeadbeef, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | 0b000000 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:140:21 [INFO] [stderr] | [INFO] [stderr] 140 | 0b000000 => self.op_sll(sa, rt, rd), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:141:21 [INFO] [stderr] | [INFO] [stderr] 141 | 0b000010 => self.op_srl(sa, rt, rd), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:142:21 [INFO] [stderr] | [INFO] [stderr] 142 | 0b000011 => self.op_sra(sa, rt, rd), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:143:21 [INFO] [stderr] | [INFO] [stderr] 143 | 0b000100 => self.op_sllv(rs, rt, rd), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:144:21 [INFO] [stderr] | [INFO] [stderr] 144 | 0b000110 => self.op_srlv(rs, rt, rd), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:145:21 [INFO] [stderr] | [INFO] [stderr] 145 | 0b000111 => self.op_srav(rs, rt, rd), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:146:21 [INFO] [stderr] | [INFO] [stderr] 146 | 0b001000 => self.op_jr(rs), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:147:21 [INFO] [stderr] | [INFO] [stderr] 147 | 0b001001 => self.op_jalr(rs, rd), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:148:21 [INFO] [stderr] | [INFO] [stderr] 148 | 0b001100 => self.op_syscall(), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:149:21 [INFO] [stderr] | [INFO] [stderr] 149 | 0b001101 => self.op_break(), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:150:21 [INFO] [stderr] | [INFO] [stderr] 150 | 0b010000 => self.op_mfhi(rd), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:151:21 [INFO] [stderr] | [INFO] [stderr] 151 | 0b010001 => self.op_mthi(rs), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:152:21 [INFO] [stderr] | [INFO] [stderr] 152 | 0b010010 => self.op_mflo(rd), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:153:21 [INFO] [stderr] | [INFO] [stderr] 153 | 0b010011 => self.op_mtlo(rs), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:154:21 [INFO] [stderr] | [INFO] [stderr] 154 | 0b011000 => self.op_mult(rs, rt), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:155:21 [INFO] [stderr] | [INFO] [stderr] 155 | 0b011001 => self.op_multu(rs, rt), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:156:21 [INFO] [stderr] | [INFO] [stderr] 156 | 0b011010 => self.op_div(rs, rt), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:157:21 [INFO] [stderr] | [INFO] [stderr] 157 | 0b011011 => self.op_divu(rs, rt), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:158:21 [INFO] [stderr] | [INFO] [stderr] 158 | 0b100000 => self.op_add(rs, rt, rd), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:159:21 [INFO] [stderr] | [INFO] [stderr] 159 | 0b100010 => self.op_sub(rs, rt, rd), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:160:21 [INFO] [stderr] | [INFO] [stderr] 160 | 0b100100 => self.op_and(rs, rt, rd), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:161:21 [INFO] [stderr] | [INFO] [stderr] 161 | 0b101011 => self.op_sltu(rs, rt, rd), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:162:21 [INFO] [stderr] | [INFO] [stderr] 162 | 0b100001 => self.op_addu(rs, rt, rd), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:163:21 [INFO] [stderr] | [INFO] [stderr] 163 | 0b100011 => self.op_subu(rs, rt, rd), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:164:21 [INFO] [stderr] | [INFO] [stderr] 164 | 0b100101 => self.op_or(rs, rt, rd), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:165:21 [INFO] [stderr] | [INFO] [stderr] 165 | 0b100110 => self.op_xor(rs, rt, rd), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:166:21 [INFO] [stderr] | [INFO] [stderr] 166 | 0b100111 => self.op_nor(rs, rt, rd), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:167:21 [INFO] [stderr] | [INFO] [stderr] 167 | 0b101010 => self.op_slt(rs, rt, rd), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | 0b000001 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:180:13 [INFO] [stderr] | [INFO] [stderr] 180 | 0b010000 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:182:21 [INFO] [stderr] | [INFO] [stderr] 182 | 0b000000 => self.op_mfc0(rt, rd), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:183:21 [INFO] [stderr] | [INFO] [stderr] 183 | 0b000100 => self.op_mtc0(rt, rd), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:184:21 [INFO] [stderr] | [INFO] [stderr] 184 | 0b010000 => self.op_rfe(instruction.data), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:185:21 [INFO] [stderr] | [INFO] [stderr] 185 | 0b010001 => self.op_cop1(), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:186:21 [INFO] [stderr] | [INFO] [stderr] 186 | 0b010010 => self.op_cop2(instruction.data), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:187:21 [INFO] [stderr] | [INFO] [stderr] 187 | 0b010011 => self.op_cop3(), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:191:13 [INFO] [stderr] | [INFO] [stderr] 191 | 0b000010 => self.op_j(target), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:192:13 [INFO] [stderr] | [INFO] [stderr] 192 | 0b000011 => self.op_jal(target), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:193:13 [INFO] [stderr] | [INFO] [stderr] 193 | 0b000100 => self.op_beq(rs, rt, imm_se), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:194:13 [INFO] [stderr] | [INFO] [stderr] 194 | 0b000101 => self.op_bne(rs, rt, imm_se), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:195:13 [INFO] [stderr] | [INFO] [stderr] 195 | 0b000110 => self.op_blez(rs, rt, imm_se), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | 0b000111 => self.op_bgtz(rs, rt, imm_se), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:197:13 [INFO] [stderr] | [INFO] [stderr] 197 | 0b001000 => self.op_addi(rs, rt, imm_se), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:198:13 [INFO] [stderr] | [INFO] [stderr] 198 | 0b001001 => self.op_addiu(rs, rt, imm_se), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:199:13 [INFO] [stderr] | [INFO] [stderr] 199 | 0b001010 => self.op_slti(rs, rt, imm_se), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:200:13 [INFO] [stderr] | [INFO] [stderr] 200 | 0b001011 => self.op_sltiu(rs, rt, imm_se), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:201:13 [INFO] [stderr] | [INFO] [stderr] 201 | 0b001100 => self.op_andi(rs, rt, imm), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:202:13 [INFO] [stderr] | [INFO] [stderr] 202 | 0b001101 => self.op_ori(rs, rt, imm), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:203:13 [INFO] [stderr] | [INFO] [stderr] 203 | 0b001110 => self.op_xori(rs, rt, imm), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:204:13 [INFO] [stderr] | [INFO] [stderr] 204 | 0b001111 => self.op_lui(rt, imm), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:205:13 [INFO] [stderr] | [INFO] [stderr] 205 | 0b100000 => self.op_lb(rs, rt, imm_se), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:206:13 [INFO] [stderr] | [INFO] [stderr] 206 | 0b100001 => self.op_lh(rs, rt, imm_se), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:207:13 [INFO] [stderr] | [INFO] [stderr] 207 | 0b100010 => self.op_lwl(rs, rt, imm_se), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:208:13 [INFO] [stderr] | [INFO] [stderr] 208 | 0b100011 => self.op_lw(rs, rt, imm_se), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:209:13 [INFO] [stderr] | [INFO] [stderr] 209 | 0b100100 => self.op_lbu(rs, rt, imm_se), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:210:13 [INFO] [stderr] | [INFO] [stderr] 210 | 0b100101 => self.op_lhu(rs, rt, imm_se), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:211:13 [INFO] [stderr] | [INFO] [stderr] 211 | 0b100110 => self.op_lwr(rs, rt, imm_se), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:212:13 [INFO] [stderr] | [INFO] [stderr] 212 | 0b101000 => self.op_sb(rs, rt, imm_se), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:213:13 [INFO] [stderr] | [INFO] [stderr] 213 | 0b101001 => self.op_sh(rs, rt, imm_se), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:214:13 [INFO] [stderr] | [INFO] [stderr] 214 | 0b101010 => self.op_swl(rs, rt, imm_se), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:215:13 [INFO] [stderr] | [INFO] [stderr] 215 | 0b101110 => self.op_swr(rs, rt, imm_se), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:216:13 [INFO] [stderr] | [INFO] [stderr] 216 | 0b101011 => self.op_sw(rs, rt, imm_se), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:217:13 [INFO] [stderr] | [INFO] [stderr] 217 | 0b110000 => self.op_lwc0(), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:218:13 [INFO] [stderr] | [INFO] [stderr] 218 | 0b110001 => self.op_lwc1(), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:219:13 [INFO] [stderr] | [INFO] [stderr] 219 | 0b110010 => self.op_lwc2(instruction.data), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:220:13 [INFO] [stderr] | [INFO] [stderr] 220 | 0b110011 => self.op_lwc3(), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:221:13 [INFO] [stderr] | [INFO] [stderr] 221 | 0b111000 => self.op_swc0(), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:222:13 [INFO] [stderr] | [INFO] [stderr] 222 | 0b111001 => self.op_swc1(), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:223:13 [INFO] [stderr] | [INFO] [stderr] 223 | 0b111010 => self.op_swc2(instruction.data), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:224:13 [INFO] [stderr] | [INFO] [stderr] 224 | 0b111011 => self.op_swc3(), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:382:27 [INFO] [stderr] | [INFO] [stderr] 382 | self.lo = 0xffffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:386:31 [INFO] [stderr] | [INFO] [stderr] 386 | } else if n as u32 == 0x80000000 && d == -1 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:388:23 [INFO] [stderr] | [INFO] [stderr] 388 | self.lo = 0x80000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:401:23 [INFO] [stderr] | [INFO] [stderr] 401 | self.lo = 0xffffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:475:27 [INFO] [stderr] | [INFO] [stderr] 475 | if data & 0x3f != 0b010000 { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:510:49 [INFO] [stderr] | [INFO] [stderr] 510 | self.next_pc = target << 2 | (self.pc & 0xf0000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xf000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:518:49 [INFO] [stderr] | [INFO] [stderr] 518 | self.next_pc = target << 2 | (self.pc & 0xf0000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xf000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:721:35 [INFO] [stderr] | [INFO] [stderr] 721 | 0 => (current_value & 0x00ffffff) | (aligned_word << 24), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:722:35 [INFO] [stderr] | [INFO] [stderr] 722 | 1 => (current_value & 0x0000ffff) | (aligned_word << 16), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:723:35 [INFO] [stderr] | [INFO] [stderr] 723 | 2 => (current_value & 0x000000ff) | (aligned_word << 8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00ff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:724:35 [INFO] [stderr] | [INFO] [stderr] 724 | 3 => (current_value & 0x00000000) | (aligned_word << 0), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:740:35 [INFO] [stderr] | [INFO] [stderr] 740 | 0 => (current_value & 0xffffff00) | (aligned_word >> 24), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ff00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:741:35 [INFO] [stderr] | [INFO] [stderr] 741 | 1 => (current_value & 0xffff0000) | (aligned_word >> 16), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:742:35 [INFO] [stderr] | [INFO] [stderr] 742 | 2 => (current_value & 0xff000000) | (aligned_word >> 8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xff00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:743:35 [INFO] [stderr] | [INFO] [stderr] 743 | 3 => (current_value & 0x00000000) | (aligned_word >> 0), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:759:35 [INFO] [stderr] | [INFO] [stderr] 759 | 0 => (current_value & 0x00000000) | (aligned_word >> 0), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:760:35 [INFO] [stderr] | [INFO] [stderr] 760 | 1 => (current_value & 0x000000ff) | (aligned_word >> 8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00ff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:761:35 [INFO] [stderr] | [INFO] [stderr] 761 | 2 => (current_value & 0x0000ffff) | (aligned_word >> 16), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:762:35 [INFO] [stderr] | [INFO] [stderr] 762 | 3 => (current_value & 0x00ffffff) | (aligned_word >> 24), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:778:35 [INFO] [stderr] | [INFO] [stderr] 778 | 0 => (current_value & 0x00000000) | (aligned_word << 0), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:779:35 [INFO] [stderr] | [INFO] [stderr] 779 | 1 => (current_value & 0x000000ff) | (aligned_word << 8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00ff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:780:35 [INFO] [stderr] | [INFO] [stderr] 780 | 2 => (current_value & 0x0000ffff) | (aligned_word << 16), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:781:35 [INFO] [stderr] | [INFO] [stderr] 781 | 3 => (current_value & 0x00ffffff) | (aligned_word << 24), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:846:21 [INFO] [stderr] | [INFO] [stderr] 846 | true => 0xfbc00180, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xfbc0_0180` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:847:22 [INFO] [stderr] | [INFO] [stderr] 847 | false => 0x80000080, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction.rs:53:21 [INFO] [stderr] | [INFO] [stderr] 53 | self.data & 0x3ffffff [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x03ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dma.rs:21:22 [INFO] [stderr] | [INFO] [stderr] 21 | control: 0x07654321, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0765_4321` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/channel.rs:44:29 [INFO] [stderr] | [INFO] [stderr] 44 | self.base = value & 0xffffff [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: All variants have the same postfix: `Bit` [INFO] [stderr] --> src/gpu.rs:496:1 [INFO] [stderr] | [INFO] [stderr] 496 | / enum TextureDepth { [INFO] [stderr] 497 | | T4Bit = 0, [INFO] [stderr] 498 | | T8Bit = 1, [INFO] [stderr] 499 | | T15Bit = 2, [INFO] [stderr] 500 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:25:21 [INFO] [stderr] | [INFO] [stderr] 25 | 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:25:33 [INFO] [stderr] | [INFO] [stderr] 25 | 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:25:45 [INFO] [stderr] | [INFO] [stderr] 25 | 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | 0x7fffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | 0x1fffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | 0xffffffff, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:31:21 [INFO] [stderr] | [INFO] [stderr] 31 | 0xffffffff, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:39:35 [INFO] [stderr] | [INFO] [stderr] 39 | pub const BIOS: Range = Range(0x1fc00000, 512 * 1024); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1fc0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:41:34 [INFO] [stderr] | [INFO] [stderr] 41 | pub const RAM: Range = Range(0x00000000, 2 * 1024 * 1024); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:43:42 [INFO] [stderr] | [INFO] [stderr] 43 | pub const MEM_CONTROL: Range = Range(0x1f801000, 36); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1f80_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:45:39 [INFO] [stderr] | [INFO] [stderr] 45 | pub const RAM_SIZE: Range = Range(0x1f801060, 4); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1f80_1060` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:47:44 [INFO] [stderr] | [INFO] [stderr] 47 | pub const CACHE_CONTROL: Range = Range(0xfffe0130, 4); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xfffe_0130` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:49:34 [INFO] [stderr] | [INFO] [stderr] 49 | pub const SPU: Range = Range(0x1f801c00, 640); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1f80_1c00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:51:42 [INFO] [stderr] | [INFO] [stderr] 51 | pub const EXPANSION_1: Range = Range(0x1f000000, 512 * 1024); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1f00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:52:42 [INFO] [stderr] | [INFO] [stderr] 52 | pub const EXPANSION_2: Range = Range(0x1f802000, 66); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1f80_2000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:54:48 [INFO] [stderr] | [INFO] [stderr] 54 | pub const INTERRUPT_CONTROL: Range = Range(0x1f801070, 8); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1f80_1070` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:56:37 [INFO] [stderr] | [INFO] [stderr] 56 | pub const TIMERS: Range = Range(0x1f801100, 48); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1f80_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:58:34 [INFO] [stderr] | [INFO] [stderr] 58 | pub const DMA: Range = Range(0x1f801080, 128); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1f80_1080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:60:34 [INFO] [stderr] | [INFO] [stderr] 60 | pub const GPU: Range = Range(0x1f801810, 8); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1f80_1810` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:178:34 [INFO] [stderr] | [INFO] [stderr] 178 | 0 => if value != 0x1f000000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1f00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:181:34 [INFO] [stderr] | [INFO] [stderr] 181 | 4 => if value != 0x1f802000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1f80_2000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:266:22 [INFO] [stderr] | [INFO] [stderr] 266 | 4 => 0x1c000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1c00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:347:41 [INFO] [stderr] | [INFO] [stderr] 347 | let mut addr = channel.base() & 0x1ffffc; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001f_fffc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:363:37 [INFO] [stderr] | [INFO] [stderr] 363 | addr = (addr + 4) & 0x1ffffc; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001f_fffc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:372:25 [INFO] [stderr] | [INFO] [stderr] 372 | if header & 0x800000 != 0 { [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0080_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:376:29 [INFO] [stderr] | [INFO] [stderr] 376 | addr = header & 0x1ffffc; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001f_fffc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:398:42 [INFO] [stderr] | [INFO] [stderr] 398 | let current_address = addr & 0x1ffffc; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001f_fffc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:412:34 [INFO] [stderr] | [INFO] [stderr] 412 | 1 => 0xffffff, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interconnect.rs:413:57 [INFO] [stderr] | [INFO] [stderr] 413 | _ => addr.wrapping_sub(4) & 0x1fffff, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001f_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:31:25 [INFO] [stderr] | [INFO] [stderr] 31 | let mut regs = [0xdeadbeef; 32]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:35:18 [INFO] [stderr] | [INFO] [stderr] 35 | let pc = 0xbfc00000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xbfc0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | hi: 0xdeadbeef, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | lo: 0xdeadbeef, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:52:25 [INFO] [stderr] | [INFO] [stderr] 52 | current_pc: 0xdeadbeef, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:54:20 [INFO] [stderr] | [INFO] [stderr] 54 | cause: 0xdeadbeef, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:56:18 [INFO] [stderr] | [INFO] [stderr] 56 | epc: 0xdeadbeef, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | 0b000000 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:140:21 [INFO] [stderr] | [INFO] [stderr] 140 | 0b000000 => self.op_sll(sa, rt, rd), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:141:21 [INFO] [stderr] | [INFO] [stderr] 141 | 0b000010 => self.op_srl(sa, rt, rd), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:142:21 [INFO] [stderr] | [INFO] [stderr] 142 | 0b000011 => self.op_sra(sa, rt, rd), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:143:21 [INFO] [stderr] | [INFO] [stderr] 143 | 0b000100 => self.op_sllv(rs, rt, rd), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:144:21 [INFO] [stderr] | [INFO] [stderr] 144 | 0b000110 => self.op_srlv(rs, rt, rd), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:145:21 [INFO] [stderr] | [INFO] [stderr] 145 | 0b000111 => self.op_srav(rs, rt, rd), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:146:21 [INFO] [stderr] | [INFO] [stderr] 146 | 0b001000 => self.op_jr(rs), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:147:21 [INFO] [stderr] | [INFO] [stderr] 147 | 0b001001 => self.op_jalr(rs, rd), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:148:21 [INFO] [stderr] | [INFO] [stderr] 148 | 0b001100 => self.op_syscall(), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:149:21 [INFO] [stderr] | [INFO] [stderr] 149 | 0b001101 => self.op_break(), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:150:21 [INFO] [stderr] | [INFO] [stderr] 150 | 0b010000 => self.op_mfhi(rd), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:151:21 [INFO] [stderr] | [INFO] [stderr] 151 | 0b010001 => self.op_mthi(rs), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:152:21 [INFO] [stderr] | [INFO] [stderr] 152 | 0b010010 => self.op_mflo(rd), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:153:21 [INFO] [stderr] | [INFO] [stderr] 153 | 0b010011 => self.op_mtlo(rs), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:154:21 [INFO] [stderr] | [INFO] [stderr] 154 | 0b011000 => self.op_mult(rs, rt), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:155:21 [INFO] [stderr] | [INFO] [stderr] 155 | 0b011001 => self.op_multu(rs, rt), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:156:21 [INFO] [stderr] | [INFO] [stderr] 156 | 0b011010 => self.op_div(rs, rt), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:157:21 [INFO] [stderr] | [INFO] [stderr] 157 | 0b011011 => self.op_divu(rs, rt), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:158:21 [INFO] [stderr] | [INFO] [stderr] 158 | 0b100000 => self.op_add(rs, rt, rd), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:159:21 [INFO] [stderr] | [INFO] [stderr] 159 | 0b100010 => self.op_sub(rs, rt, rd), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:160:21 [INFO] [stderr] | [INFO] [stderr] 160 | 0b100100 => self.op_and(rs, rt, rd), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:161:21 [INFO] [stderr] | [INFO] [stderr] 161 | 0b101011 => self.op_sltu(rs, rt, rd), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:162:21 [INFO] [stderr] | [INFO] [stderr] 162 | 0b100001 => self.op_addu(rs, rt, rd), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:163:21 [INFO] [stderr] | [INFO] [stderr] 163 | 0b100011 => self.op_subu(rs, rt, rd), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:164:21 [INFO] [stderr] | [INFO] [stderr] 164 | 0b100101 => self.op_or(rs, rt, rd), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:165:21 [INFO] [stderr] | [INFO] [stderr] 165 | 0b100110 => self.op_xor(rs, rt, rd), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:166:21 [INFO] [stderr] | [INFO] [stderr] 166 | 0b100111 => self.op_nor(rs, rt, rd), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:167:21 [INFO] [stderr] | [INFO] [stderr] 167 | 0b101010 => self.op_slt(rs, rt, rd), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | 0b000001 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:180:13 [INFO] [stderr] | [INFO] [stderr] 180 | 0b010000 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:182:21 [INFO] [stderr] | [INFO] [stderr] 182 | 0b000000 => self.op_mfc0(rt, rd), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:183:21 [INFO] [stderr] | [INFO] [stderr] 183 | 0b000100 => self.op_mtc0(rt, rd), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:184:21 [INFO] [stderr] | [INFO] [stderr] 184 | 0b010000 => self.op_rfe(instruction.data), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:185:21 [INFO] [stderr] | [INFO] [stderr] 185 | 0b010001 => self.op_cop1(), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:186:21 [INFO] [stderr] | [INFO] [stderr] 186 | 0b010010 => self.op_cop2(instruction.data), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:187:21 [INFO] [stderr] | [INFO] [stderr] 187 | 0b010011 => self.op_cop3(), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:191:13 [INFO] [stderr] | [INFO] [stderr] 191 | 0b000010 => self.op_j(target), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:192:13 [INFO] [stderr] | [INFO] [stderr] 192 | 0b000011 => self.op_jal(target), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:193:13 [INFO] [stderr] | [INFO] [stderr] 193 | 0b000100 => self.op_beq(rs, rt, imm_se), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:194:13 [INFO] [stderr] | [INFO] [stderr] 194 | 0b000101 => self.op_bne(rs, rt, imm_se), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:195:13 [INFO] [stderr] | [INFO] [stderr] 195 | 0b000110 => self.op_blez(rs, rt, imm_se), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | 0b000111 => self.op_bgtz(rs, rt, imm_se), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:197:13 [INFO] [stderr] | [INFO] [stderr] 197 | 0b001000 => self.op_addi(rs, rt, imm_se), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:198:13 [INFO] [stderr] | [INFO] [stderr] 198 | 0b001001 => self.op_addiu(rs, rt, imm_se), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:199:13 [INFO] [stderr] | [INFO] [stderr] 199 | 0b001010 => self.op_slti(rs, rt, imm_se), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:200:13 [INFO] [stderr] | [INFO] [stderr] 200 | 0b001011 => self.op_sltiu(rs, rt, imm_se), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:201:13 [INFO] [stderr] | [INFO] [stderr] 201 | 0b001100 => self.op_andi(rs, rt, imm), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:202:13 [INFO] [stderr] | [INFO] [stderr] 202 | 0b001101 => self.op_ori(rs, rt, imm), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:203:13 [INFO] [stderr] | [INFO] [stderr] 203 | 0b001110 => self.op_xori(rs, rt, imm), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:204:13 [INFO] [stderr] | [INFO] [stderr] 204 | 0b001111 => self.op_lui(rt, imm), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:205:13 [INFO] [stderr] | [INFO] [stderr] 205 | 0b100000 => self.op_lb(rs, rt, imm_se), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:206:13 [INFO] [stderr] | [INFO] [stderr] 206 | 0b100001 => self.op_lh(rs, rt, imm_se), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:207:13 [INFO] [stderr] | [INFO] [stderr] 207 | 0b100010 => self.op_lwl(rs, rt, imm_se), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:208:13 [INFO] [stderr] | [INFO] [stderr] 208 | 0b100011 => self.op_lw(rs, rt, imm_se), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:209:13 [INFO] [stderr] | [INFO] [stderr] 209 | 0b100100 => self.op_lbu(rs, rt, imm_se), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:210:13 [INFO] [stderr] | [INFO] [stderr] 210 | 0b100101 => self.op_lhu(rs, rt, imm_se), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:211:13 [INFO] [stderr] | [INFO] [stderr] 211 | 0b100110 => self.op_lwr(rs, rt, imm_se), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:212:13 [INFO] [stderr] | [INFO] [stderr] 212 | 0b101000 => self.op_sb(rs, rt, imm_se), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:213:13 [INFO] [stderr] | [INFO] [stderr] 213 | 0b101001 => self.op_sh(rs, rt, imm_se), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:214:13 [INFO] [stderr] | [INFO] [stderr] 214 | 0b101010 => self.op_swl(rs, rt, imm_se), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:215:13 [INFO] [stderr] | [INFO] [stderr] 215 | 0b101110 => self.op_swr(rs, rt, imm_se), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:216:13 [INFO] [stderr] | [INFO] [stderr] 216 | 0b101011 => self.op_sw(rs, rt, imm_se), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:217:13 [INFO] [stderr] | [INFO] [stderr] 217 | 0b110000 => self.op_lwc0(), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:218:13 [INFO] [stderr] | [INFO] [stderr] 218 | 0b110001 => self.op_lwc1(), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:219:13 [INFO] [stderr] | [INFO] [stderr] 219 | 0b110010 => self.op_lwc2(instruction.data), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:220:13 [INFO] [stderr] | [INFO] [stderr] 220 | 0b110011 => self.op_lwc3(), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:221:13 [INFO] [stderr] | [INFO] [stderr] 221 | 0b111000 => self.op_swc0(), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:222:13 [INFO] [stderr] | [INFO] [stderr] 222 | 0b111001 => self.op_swc1(), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:223:13 [INFO] [stderr] | [INFO] [stderr] 223 | 0b111010 => self.op_swc2(instruction.data), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:224:13 [INFO] [stderr] | [INFO] [stderr] 224 | 0b111011 => self.op_swc3(), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:382:27 [INFO] [stderr] | [INFO] [stderr] 382 | self.lo = 0xffffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:386:31 [INFO] [stderr] | [INFO] [stderr] 386 | } else if n as u32 == 0x80000000 && d == -1 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:388:23 [INFO] [stderr] | [INFO] [stderr] 388 | self.lo = 0x80000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:401:23 [INFO] [stderr] | [INFO] [stderr] 401 | self.lo = 0xffffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:475:27 [INFO] [stderr] | [INFO] [stderr] 475 | if data & 0x3f != 0b010000 { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:510:49 [INFO] [stderr] | [INFO] [stderr] 510 | self.next_pc = target << 2 | (self.pc & 0xf0000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xf000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:518:49 [INFO] [stderr] | [INFO] [stderr] 518 | self.next_pc = target << 2 | (self.pc & 0xf0000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xf000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:721:35 [INFO] [stderr] | [INFO] [stderr] 721 | 0 => (current_value & 0x00ffffff) | (aligned_word << 24), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:722:35 [INFO] [stderr] | [INFO] [stderr] 722 | 1 => (current_value & 0x0000ffff) | (aligned_word << 16), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:723:35 [INFO] [stderr] | [INFO] [stderr] 723 | 2 => (current_value & 0x000000ff) | (aligned_word << 8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00ff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:724:35 [INFO] [stderr] | [INFO] [stderr] 724 | 3 => (current_value & 0x00000000) | (aligned_word << 0), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:740:35 [INFO] [stderr] | [INFO] [stderr] 740 | 0 => (current_value & 0xffffff00) | (aligned_word >> 24), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ff00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:741:35 [INFO] [stderr] | [INFO] [stderr] 741 | 1 => (current_value & 0xffff0000) | (aligned_word >> 16), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:742:35 [INFO] [stderr] | [INFO] [stderr] 742 | 2 => (current_value & 0xff000000) | (aligned_word >> 8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xff00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:743:35 [INFO] [stderr] | [INFO] [stderr] 743 | 3 => (current_value & 0x00000000) | (aligned_word >> 0), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:759:35 [INFO] [stderr] | [INFO] [stderr] 759 | 0 => (current_value & 0x00000000) | (aligned_word >> 0), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:760:35 [INFO] [stderr] | [INFO] [stderr] 760 | 1 => (current_value & 0x000000ff) | (aligned_word >> 8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00ff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:761:35 [INFO] [stderr] | [INFO] [stderr] 761 | 2 => (current_value & 0x0000ffff) | (aligned_word >> 16), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:762:35 [INFO] [stderr] | [INFO] [stderr] 762 | 3 => (current_value & 0x00ffffff) | (aligned_word >> 24), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:778:35 [INFO] [stderr] | [INFO] [stderr] 778 | 0 => (current_value & 0x00000000) | (aligned_word << 0), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:779:35 [INFO] [stderr] | [INFO] [stderr] 779 | 1 => (current_value & 0x000000ff) | (aligned_word << 8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00ff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:780:35 [INFO] [stderr] | [INFO] [stderr] 780 | 2 => (current_value & 0x0000ffff) | (aligned_word << 16), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:781:35 [INFO] [stderr] | [INFO] [stderr] 781 | 3 => (current_value & 0x00ffffff) | (aligned_word << 24), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:846:21 [INFO] [stderr] | [INFO] [stderr] 846 | true => 0xfbc00180, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xfbc0_0180` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:847:22 [INFO] [stderr] | [INFO] [stderr] 847 | false => 0x80000080, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction.rs:53:21 [INFO] [stderr] | [INFO] [stderr] 53 | self.data & 0x3ffffff [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x03ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dma.rs:21:22 [INFO] [stderr] | [INFO] [stderr] 21 | control: 0x07654321, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0765_4321` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/channel.rs:44:29 [INFO] [stderr] | [INFO] [stderr] 44 | self.base = value & 0xffffff [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: All variants have the same postfix: `Bit` [INFO] [stderr] --> src/gpu.rs:496:1 [INFO] [stderr] | [INFO] [stderr] 496 | / enum TextureDepth { [INFO] [stderr] 497 | | T4Bit = 0, [INFO] [stderr] 498 | | T8Bit = 1, [INFO] [stderr] 499 | | T15Bit = 2, [INFO] [stderr] 500 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rt` [INFO] [stderr] --> src/cpu.rs:537:36 [INFO] [stderr] | [INFO] [stderr] 537 | fn op_bgtz(&mut self, rs: u32, rt: u32, imm_se: u32) { [INFO] [stderr] | ^^ help: consider using `_rt` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rt` [INFO] [stderr] --> src/cpu.rs:545:36 [INFO] [stderr] | [INFO] [stderr] 545 | fn op_bltz(&mut self, rs: u32, rt: u32, imm_se: u32) { [INFO] [stderr] | ^^ help: consider using `_rt` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rt` [INFO] [stderr] --> src/cpu.rs:553:36 [INFO] [stderr] | [INFO] [stderr] 553 | fn op_bgez(&mut self, rs: u32, rt: u32, imm_se: u32) { [INFO] [stderr] | ^^ help: consider using `_rt` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rt` [INFO] [stderr] --> src/cpu.rs:561:38 [INFO] [stderr] | [INFO] [stderr] 561 | fn op_bltzal(&mut self, rs: u32, rt: u32, imm_se: u32) { [INFO] [stderr] | ^^ help: consider using `_rt` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rt` [INFO] [stderr] --> src/cpu.rs:572:38 [INFO] [stderr] | [INFO] [stderr] 572 | fn op_bgezal(&mut self, rs: u32, rt: u32, imm_se: u32) { [INFO] [stderr] | ^^ help: consider using `_rt` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rt` [INFO] [stderr] --> src/cpu.rs:583:36 [INFO] [stderr] | [INFO] [stderr] 583 | fn op_blez(&mut self, rs: u32, rt: u32, imm_se: u32) { [INFO] [stderr] | ^^ help: consider using `_rt` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `res` [INFO] [stderr] --> src/cpu.rs:595:13 [INFO] [stderr] | [INFO] [stderr] 595 | let res = match reg.checked_add(imm) { [INFO] [stderr] | ^^^ help: consider using `_res` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `width` [INFO] [stderr] --> src/gpu.rs:258:13 [INFO] [stderr] | [INFO] [stderr] 258 | let width = res & 0xffff; [INFO] [stderr] | ^^^^^ help: consider using `_width` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `height` [INFO] [stderr] --> src/gpu.rs:259:13 [INFO] [stderr] | [INFO] [stderr] 259 | let height = res >> 16; [INFO] [stderr] | ^^^^^^ help: consider using `_height` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `n` [INFO] [stderr] --> src/gpu.rs:306:13 [INFO] [stderr] | [INFO] [stderr] 306 | n => panic!("Unhandled texture Depth"), [INFO] [stderr] | ^ help: consider using `_n` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `value` [INFO] [stderr] --> src/gpu.rs:356:29 [INFO] [stderr] | [INFO] [stderr] 356 | fn gp1_reset(&mut self, value: u32) { [INFO] [stderr] | ^^^^^ help: consider using `_value` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rt` [INFO] [stderr] --> src/cpu.rs:537:36 [INFO] [stderr] | [INFO] [stderr] 537 | fn op_bgtz(&mut self, rs: u32, rt: u32, imm_se: u32) { [INFO] [stderr] | ^^ help: consider using `_rt` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rt` [INFO] [stderr] --> src/cpu.rs:545:36 [INFO] [stderr] | [INFO] [stderr] 545 | fn op_bltz(&mut self, rs: u32, rt: u32, imm_se: u32) { [INFO] [stderr] | ^^ help: consider using `_rt` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rt` [INFO] [stderr] --> src/cpu.rs:553:36 [INFO] [stderr] | [INFO] [stderr] 553 | fn op_bgez(&mut self, rs: u32, rt: u32, imm_se: u32) { [INFO] [stderr] | ^^ help: consider using `_rt` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rt` [INFO] [stderr] --> src/cpu.rs:561:38 [INFO] [stderr] | [INFO] [stderr] 561 | fn op_bltzal(&mut self, rs: u32, rt: u32, imm_se: u32) { [INFO] [stderr] | ^^ help: consider using `_rt` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rt` [INFO] [stderr] --> src/cpu.rs:572:38 [INFO] [stderr] | [INFO] [stderr] 572 | fn op_bgezal(&mut self, rs: u32, rt: u32, imm_se: u32) { [INFO] [stderr] | ^^ help: consider using `_rt` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rt` [INFO] [stderr] --> src/cpu.rs:583:36 [INFO] [stderr] | [INFO] [stderr] 583 | fn op_blez(&mut self, rs: u32, rt: u32, imm_se: u32) { [INFO] [stderr] | ^^ help: consider using `_rt` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `res` [INFO] [stderr] --> src/cpu.rs:595:13 [INFO] [stderr] | [INFO] [stderr] 595 | let res = match reg.checked_add(imm) { [INFO] [stderr] | ^^^ help: consider using `_res` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `width` [INFO] [stderr] --> src/gpu.rs:258:13 [INFO] [stderr] | [INFO] [stderr] 258 | let width = res & 0xffff; [INFO] [stderr] | ^^^^^ help: consider using `_width` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `height` [INFO] [stderr] --> src/gpu.rs:259:13 [INFO] [stderr] | [INFO] [stderr] 259 | let height = res >> 16; [INFO] [stderr] | ^^^^^^ help: consider using `_height` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `n` [INFO] [stderr] --> src/gpu.rs:306:13 [INFO] [stderr] | [INFO] [stderr] 306 | n => panic!("Unhandled texture Depth"), [INFO] [stderr] | ^ help: consider using `_n` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `value` [INFO] [stderr] --> src/gpu.rs:356:29 [INFO] [stderr] | [INFO] [stderr] 356 | fn gp1_reset(&mut self, value: u32) { [INFO] [stderr] | ^^^^^ help: consider using `_value` instead [INFO] [stderr] [INFO] [stderr] warning: method is never used: `load16` [INFO] [stderr] --> src/bios.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn load16(&self, offset: u32) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `block_control` [INFO] [stderr] --> src/channel.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | pub fn block_control(&self) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `status` [INFO] [stderr] --> src/gpu.rs:140:5 [INFO] [stderr] | [INFO] [stderr] 140 | pub fn status(&self) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `read` [INFO] [stderr] --> src/gpu.rs:428:5 [INFO] [stderr] | [INFO] [stderr] 428 | pub fn read(&self) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Bottom` [INFO] [stderr] --> src/gpu.rs:505:5 [INFO] [stderr] | [INFO] [stderr] 505 | Bottom = 0, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `into_status` [INFO] [stderr] --> src/gpu.rs:543:5 [INFO] [stderr] | [INFO] [stderr] 543 | fn into_status(self) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: crate `PSX` should have a snake case name such as `psx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/bios.rs:33:18 [INFO] [stderr] | [INFO] [stderr] 33 | let b0 = self.data[offset + 0] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.data[offset + 0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `offset` [INFO] [stderr] --> src/bios.rs:33:28 [INFO] [stderr] | [INFO] [stderr] 33 | let b0 = self.data[offset + 0] as u16; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/bios.rs:34:18 [INFO] [stderr] | [INFO] [stderr] 34 | let b1 = self.data[offset + 1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.data[offset + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bios.rs:42:18 [INFO] [stderr] | [INFO] [stderr] 42 | let b0 = self.data[offset + 0] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.data[offset + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `offset` [INFO] [stderr] --> src/bios.rs:42:28 [INFO] [stderr] | [INFO] [stderr] 42 | let b0 = self.data[offset + 0] as u32; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bios.rs:43:18 [INFO] [stderr] | [INFO] [stderr] 43 | let b1 = self.data[offset + 1] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.data[offset + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bios.rs:44:18 [INFO] [stderr] | [INFO] [stderr] 44 | let b2 = self.data[offset + 2] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.data[offset + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bios.rs:45:18 [INFO] [stderr] | [INFO] [stderr] 45 | let b3 = self.data[offset + 3] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.data[offset + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:355:17 [INFO] [stderr] | [INFO] [stderr] 355 | let a = (self.reg(rs) as i32) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from((self.reg(rs) as i32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:356:17 [INFO] [stderr] | [INFO] [stderr] 356 | let b = (self.reg(rt) as i32) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from((self.reg(rt) as i32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:365:17 [INFO] [stderr] | [INFO] [stderr] 365 | let a = self.reg(rs) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.reg(rs))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:366:17 [INFO] [stderr] | [INFO] [stderr] 366 | let b = self.reg(rt) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.reg(rt))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: method is never used: `load16` [INFO] [stderr] --> src/bios.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn load16(&self, offset: u32) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `block_control` [INFO] [stderr] --> src/channel.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | pub fn block_control(&self) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `status` [INFO] [stderr] --> src/gpu.rs:140:5 [INFO] [stderr] | [INFO] [stderr] 140 | pub fn status(&self) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `read` [INFO] [stderr] --> src/gpu.rs:428:5 [INFO] [stderr] | [INFO] [stderr] 428 | pub fn read(&self) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Bottom` [INFO] [stderr] --> src/gpu.rs:505:5 [INFO] [stderr] | [INFO] [stderr] 505 | Bottom = 0, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `into_status` [INFO] [stderr] --> src/gpu.rs:543:5 [INFO] [stderr] | [INFO] [stderr] 543 | fn into_status(self) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: crate `PSX` should have a snake case name such as `psx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let res =` [INFO] [stderr] --> src/cpu.rs:595:9 [INFO] [stderr] | [INFO] [stderr] 595 | / let res = match reg.checked_add(imm) { [INFO] [stderr] 596 | | Some(res) => self.set_reg(rt, res as u32), [INFO] [stderr] 597 | | None => self.exception(Exception::Overflow), [INFO] [stderr] 598 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:678:26 [INFO] [stderr] | [INFO] [stderr] 678 | self.load = (rt, value as u32); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:691:26 [INFO] [stderr] | [INFO] [stderr] 691 | self.load = (rt, value as u32); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/cpu.rs:724:18 [INFO] [stderr] | [INFO] [stderr] 724 | 3 => (current_value & 0x00000000) | (aligned_word << 0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::erasing_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `aligned_word` [INFO] [stderr] --> src/cpu.rs:724:49 [INFO] [stderr] | [INFO] [stderr] 724 | 3 => (current_value & 0x00000000) | (aligned_word << 0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/cpu.rs:743:18 [INFO] [stderr] | [INFO] [stderr] 743 | 3 => (current_value & 0x00000000) | (aligned_word >> 0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/bios.rs:33:18 [INFO] [stderr] | [INFO] [stderr] 33 | let b0 = self.data[offset + 0] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.data[offset + 0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `aligned_word` [INFO] [stderr] --> src/cpu.rs:743:49 [INFO] [stderr] | [INFO] [stderr] 743 | 3 => (current_value & 0x00000000) | (aligned_word >> 0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `offset` [INFO] [stderr] --> src/bios.rs:33:28 [INFO] [stderr] | [INFO] [stderr] 33 | let b0 = self.data[offset + 0] as u16; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/bios.rs:34:18 [INFO] [stderr] | [INFO] [stderr] 34 | let b1 = self.data[offset + 1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.data[offset + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/cpu.rs:759:18 [INFO] [stderr] | [INFO] [stderr] 759 | 0 => (current_value & 0x00000000) | (aligned_word >> 0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `aligned_word` [INFO] [stderr] --> src/cpu.rs:759:49 [INFO] [stderr] | [INFO] [stderr] 759 | 0 => (current_value & 0x00000000) | (aligned_word >> 0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bios.rs:42:18 [INFO] [stderr] | [INFO] [stderr] 42 | let b0 = self.data[offset + 0] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.data[offset + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `offset` [INFO] [stderr] --> src/bios.rs:42:28 [INFO] [stderr] | [INFO] [stderr] 42 | let b0 = self.data[offset + 0] as u32; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bios.rs:43:18 [INFO] [stderr] | [INFO] [stderr] 43 | let b1 = self.data[offset + 1] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.data[offset + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bios.rs:44:18 [INFO] [stderr] | [INFO] [stderr] 44 | let b2 = self.data[offset + 2] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.data[offset + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bios.rs:45:18 [INFO] [stderr] | [INFO] [stderr] 45 | let b3 = self.data[offset + 3] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.data[offset + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/cpu.rs:778:18 [INFO] [stderr] | [INFO] [stderr] 778 | 0 => (current_value & 0x00000000) | (aligned_word << 0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `aligned_word` [INFO] [stderr] --> src/cpu.rs:778:49 [INFO] [stderr] | [INFO] [stderr] 778 | 0 => (current_value & 0x00000000) | (aligned_word << 0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/cpu.rs:845:23 [INFO] [stderr] | [INFO] [stderr] 845 | let handler = match self.sr & (1 << 22) != 0 { [INFO] [stderr] | _______________________^ [INFO] [stderr] 846 | | true => 0xfbc00180, [INFO] [stderr] 847 | | false => 0x80000080, [INFO] [stderr] 848 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.sr & (1 << 22) != 0 { 0xfbc00180 } else { 0x80000080 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ram.rs:19:18 [INFO] [stderr] | [INFO] [stderr] 19 | let b0 = self.data[offset + 0] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.data[offset + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `offset` [INFO] [stderr] --> src/ram.rs:19:28 [INFO] [stderr] | [INFO] [stderr] 19 | let b0 = self.data[offset + 0] as u16; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ram.rs:20:18 [INFO] [stderr] | [INFO] [stderr] 20 | let b1 = self.data[offset + 1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.data[offset + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ram.rs:28:18 [INFO] [stderr] | [INFO] [stderr] 28 | let b0 = self.data[offset + 0] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.data[offset + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `offset` [INFO] [stderr] --> src/ram.rs:28:28 [INFO] [stderr] | [INFO] [stderr] 28 | let b0 = self.data[offset + 0] as u32; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ram.rs:29:18 [INFO] [stderr] | [INFO] [stderr] 29 | let b1 = self.data[offset + 1] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.data[offset + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ram.rs:30:18 [INFO] [stderr] | [INFO] [stderr] 30 | let b2 = self.data[offset + 2] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.data[offset + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ram.rs:31:18 [INFO] [stderr] | [INFO] [stderr] 31 | let b3 = self.data[offset + 3] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.data[offset + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `offset` [INFO] [stderr] --> src/ram.rs:46:19 [INFO] [stderr] | [INFO] [stderr] 46 | self.data[offset + 0] = b0; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `offset` [INFO] [stderr] --> src/ram.rs:58:19 [INFO] [stderr] | [INFO] [stderr] 58 | self.data[offset + 0] = b0; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/dma.rs:45:14 [INFO] [stderr] | [INFO] [stderr] 45 | r |= self.irq_dummy as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.irq_dummy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/dma.rs:47:14 [INFO] [stderr] | [INFO] [stderr] 47 | r |= (self.channel_irq_en as u32) << 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.channel_irq_en)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/dma.rs:49:14 [INFO] [stderr] | [INFO] [stderr] 49 | r |= (self.channel_irq_flags as u32) << 24; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.channel_irq_flags)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/channel.rs:48:18 [INFO] [stderr] | [INFO] [stderr] 48 | let bs = self.block_size as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.block_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/channel.rs:49:18 [INFO] [stderr] | [INFO] [stderr] 49 | let bc = self.block_count as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.block_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(self.direction as u32)` [INFO] [stderr] --> src/channel.rs:71:14 [INFO] [stderr] | [INFO] [stderr] 71 | r |= (self.direction as u32) << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/channel.rs:75:14 [INFO] [stderr] | [INFO] [stderr] 75 | r |= (self.chop_dma_size as u32) << 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.chop_dma_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/channel.rs:76:14 [INFO] [stderr] | [INFO] [stderr] 76 | r |= (self.chop_cpu_size as u32) << 20; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.chop_cpu_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/channel.rs:79:14 [INFO] [stderr] | [INFO] [stderr] 79 | r |= (self.dummy as u32) << 29; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.dummy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/channel.rs:85:26 [INFO] [stderr] | [INFO] [stderr] 85 | self.direction = match value & 1 != 0 { [INFO] [stderr] | __________________________^ [INFO] [stderr] 86 | | true => Direction::FromRam, [INFO] [stderr] 87 | | false => Direction::ToRam, [INFO] [stderr] 88 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if value & 1 != 0 { Direction::FromRam } else { Direction::ToRam }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/channel.rs:90:21 [INFO] [stderr] | [INFO] [stderr] 90 | self.step = match (value >> 1) & 1 != 0 { [INFO] [stderr] | _____________________^ [INFO] [stderr] 91 | | true => Step::Decrement, [INFO] [stderr] 92 | | false => Step::Increment, [INFO] [stderr] 93 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if (value >> 1) & 1 != 0 { Step::Decrement } else { Step::Increment }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/channel.rs:125:18 [INFO] [stderr] | [INFO] [stderr] 125 | let bs = self.block_size as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.block_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/channel.rs:126:18 [INFO] [stderr] | [INFO] [stderr] 126 | let bc = self.block_count as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.block_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(self.page_base_x as u32)` [INFO] [stderr] --> src/gpu.rs:143:14 [INFO] [stderr] | [INFO] [stderr] 143 | r |= (self.page_base_x as u32) << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/gpu.rs:143:14 [INFO] [stderr] | [INFO] [stderr] 143 | r |= (self.page_base_x as u32) << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.page_base_x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/gpu.rs:144:14 [INFO] [stderr] | [INFO] [stderr] 144 | r |= (self.page_base_y as u32) << 4; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.page_base_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/gpu.rs:145:14 [INFO] [stderr] | [INFO] [stderr] 145 | r |= (self.semi_transparency as u32) << 5; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.semi_transparency)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:355:17 [INFO] [stderr] | [INFO] [stderr] 355 | let a = (self.reg(rs) as i32) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from((self.reg(rs) as i32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:356:17 [INFO] [stderr] | [INFO] [stderr] 356 | let b = (self.reg(rt) as i32) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from((self.reg(rt) as i32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:365:17 [INFO] [stderr] | [INFO] [stderr] 365 | let a = self.reg(rs) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.reg(rs))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:366:17 [INFO] [stderr] | [INFO] [stderr] 366 | let b = self.reg(rt) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.reg(rt))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gpu.rs:442:21 [INFO] [stderr] | [INFO] [stderr] 442 | self.vres = match value & 0x4 != 0 { [INFO] [stderr] | _____________________^ [INFO] [stderr] 443 | | false => VerticalRes::Y240Lines, [INFO] [stderr] 444 | | true => VerticalRes::Y480Lines, [INFO] [stderr] 445 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if value & 0x4 != 0 { VerticalRes::Y480Lines } else { VerticalRes::Y240Lines }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gpu.rs:447:22 [INFO] [stderr] | [INFO] [stderr] 447 | self.vmode = match value & 0x8 != 0 { [INFO] [stderr] | ______________________^ [INFO] [stderr] 448 | | false => VMode::NTSC, [INFO] [stderr] 449 | | true => VMode::PAL, [INFO] [stderr] 450 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if value & 0x8 != 0 { VMode::PAL } else { VMode::NTSC }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gpu.rs:452:30 [INFO] [stderr] | [INFO] [stderr] 452 | self.display_depth = match value & 0x10 != 0 { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 453 | | false => DisplayDepth::D24Bits, [INFO] [stderr] 454 | | true => DisplayDepth::D15Bits, [INFO] [stderr] 455 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if value & 0x10 != 0 { DisplayDepth::D15Bits } else { DisplayDepth::D24Bits }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/gpu.rs:545:9 [INFO] [stderr] | [INFO] [stderr] 545 | (hr as u32) << 16 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(hr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/gpu.rs:576:5 [INFO] [stderr] | [INFO] [stderr] 576 | / fn index<'a>(&'a self, index: usize) -> &'a u32 { [INFO] [stderr] 577 | | if index >= self.length as usize { [INFO] [stderr] 578 | | panic!("Command buffer index out of range"); [INFO] [stderr] 579 | | } [INFO] [stderr] 580 | | [INFO] [stderr] 581 | | &self.buffer[index] [INFO] [stderr] 582 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let res =` [INFO] [stderr] --> src/cpu.rs:595:9 [INFO] [stderr] | [INFO] [stderr] 595 | / let res = match reg.checked_add(imm) { [INFO] [stderr] 596 | | Some(res) => self.set_reg(rt, res as u32), [INFO] [stderr] 597 | | None => self.exception(Exception::Overflow), [INFO] [stderr] 598 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:678:26 [INFO] [stderr] | [INFO] [stderr] 678 | self.load = (rt, value as u32); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:691:26 [INFO] [stderr] | [INFO] [stderr] 691 | self.load = (rt, value as u32); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/cpu.rs:724:18 [INFO] [stderr] | [INFO] [stderr] 724 | 3 => (current_value & 0x00000000) | (aligned_word << 0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::erasing_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `aligned_word` [INFO] [stderr] --> src/cpu.rs:724:49 [INFO] [stderr] | [INFO] [stderr] 724 | 3 => (current_value & 0x00000000) | (aligned_word << 0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/cpu.rs:743:18 [INFO] [stderr] | [INFO] [stderr] 743 | 3 => (current_value & 0x00000000) | (aligned_word >> 0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `aligned_word` [INFO] [stderr] --> src/cpu.rs:743:49 [INFO] [stderr] | [INFO] [stderr] 743 | 3 => (current_value & 0x00000000) | (aligned_word >> 0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/cpu.rs:759:18 [INFO] [stderr] | [INFO] [stderr] 759 | 0 => (current_value & 0x00000000) | (aligned_word >> 0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `aligned_word` [INFO] [stderr] --> src/cpu.rs:759:49 [INFO] [stderr] | [INFO] [stderr] 759 | 0 => (current_value & 0x00000000) | (aligned_word >> 0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/cpu.rs:778:18 [INFO] [stderr] | [INFO] [stderr] 778 | 0 => (current_value & 0x00000000) | (aligned_word << 0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `aligned_word` [INFO] [stderr] --> src/cpu.rs:778:49 [INFO] [stderr] | [INFO] [stderr] 778 | 0 => (current_value & 0x00000000) | (aligned_word << 0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: Could not compile `PSX`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/cpu.rs:845:23 [INFO] [stderr] | [INFO] [stderr] 845 | let handler = match self.sr & (1 << 22) != 0 { [INFO] [stderr] | _______________________^ [INFO] [stderr] 846 | | true => 0xfbc00180, [INFO] [stderr] 847 | | false => 0x80000080, [INFO] [stderr] 848 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.sr & (1 << 22) != 0 { 0xfbc00180 } else { 0x80000080 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ram.rs:19:18 [INFO] [stderr] | [INFO] [stderr] 19 | let b0 = self.data[offset + 0] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.data[offset + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `offset` [INFO] [stderr] --> src/ram.rs:19:28 [INFO] [stderr] | [INFO] [stderr] 19 | let b0 = self.data[offset + 0] as u16; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ram.rs:20:18 [INFO] [stderr] | [INFO] [stderr] 20 | let b1 = self.data[offset + 1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.data[offset + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ram.rs:28:18 [INFO] [stderr] | [INFO] [stderr] 28 | let b0 = self.data[offset + 0] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.data[offset + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `offset` [INFO] [stderr] --> src/ram.rs:28:28 [INFO] [stderr] | [INFO] [stderr] 28 | let b0 = self.data[offset + 0] as u32; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ram.rs:29:18 [INFO] [stderr] | [INFO] [stderr] 29 | let b1 = self.data[offset + 1] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.data[offset + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ram.rs:30:18 [INFO] [stderr] | [INFO] [stderr] 30 | let b2 = self.data[offset + 2] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.data[offset + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ram.rs:31:18 [INFO] [stderr] | [INFO] [stderr] 31 | let b3 = self.data[offset + 3] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.data[offset + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `offset` [INFO] [stderr] --> src/ram.rs:46:19 [INFO] [stderr] | [INFO] [stderr] 46 | self.data[offset + 0] = b0; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `offset` [INFO] [stderr] --> src/ram.rs:58:19 [INFO] [stderr] | [INFO] [stderr] 58 | self.data[offset + 0] = b0; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/dma.rs:45:14 [INFO] [stderr] | [INFO] [stderr] 45 | r |= self.irq_dummy as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.irq_dummy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/dma.rs:47:14 [INFO] [stderr] | [INFO] [stderr] 47 | r |= (self.channel_irq_en as u32) << 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.channel_irq_en)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/dma.rs:49:14 [INFO] [stderr] | [INFO] [stderr] 49 | r |= (self.channel_irq_flags as u32) << 24; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.channel_irq_flags)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/channel.rs:48:18 [INFO] [stderr] | [INFO] [stderr] 48 | let bs = self.block_size as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.block_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/channel.rs:49:18 [INFO] [stderr] | [INFO] [stderr] 49 | let bc = self.block_count as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.block_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(self.direction as u32)` [INFO] [stderr] --> src/channel.rs:71:14 [INFO] [stderr] | [INFO] [stderr] 71 | r |= (self.direction as u32) << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/channel.rs:75:14 [INFO] [stderr] | [INFO] [stderr] 75 | r |= (self.chop_dma_size as u32) << 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.chop_dma_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/channel.rs:76:14 [INFO] [stderr] | [INFO] [stderr] 76 | r |= (self.chop_cpu_size as u32) << 20; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.chop_cpu_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/channel.rs:79:14 [INFO] [stderr] | [INFO] [stderr] 79 | r |= (self.dummy as u32) << 29; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.dummy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/channel.rs:85:26 [INFO] [stderr] | [INFO] [stderr] 85 | self.direction = match value & 1 != 0 { [INFO] [stderr] | __________________________^ [INFO] [stderr] 86 | | true => Direction::FromRam, [INFO] [stderr] 87 | | false => Direction::ToRam, [INFO] [stderr] 88 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if value & 1 != 0 { Direction::FromRam } else { Direction::ToRam }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/channel.rs:90:21 [INFO] [stderr] | [INFO] [stderr] 90 | self.step = match (value >> 1) & 1 != 0 { [INFO] [stderr] | _____________________^ [INFO] [stderr] 91 | | true => Step::Decrement, [INFO] [stderr] 92 | | false => Step::Increment, [INFO] [stderr] 93 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if (value >> 1) & 1 != 0 { Step::Decrement } else { Step::Increment }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/channel.rs:125:18 [INFO] [stderr] | [INFO] [stderr] 125 | let bs = self.block_size as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.block_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/channel.rs:126:18 [INFO] [stderr] | [INFO] [stderr] 126 | let bc = self.block_count as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.block_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(self.page_base_x as u32)` [INFO] [stderr] --> src/gpu.rs:143:14 [INFO] [stderr] | [INFO] [stderr] 143 | r |= (self.page_base_x as u32) << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/gpu.rs:143:14 [INFO] [stderr] | [INFO] [stderr] 143 | r |= (self.page_base_x as u32) << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.page_base_x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/gpu.rs:144:14 [INFO] [stderr] | [INFO] [stderr] 144 | r |= (self.page_base_y as u32) << 4; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.page_base_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/gpu.rs:145:14 [INFO] [stderr] | [INFO] [stderr] 145 | r |= (self.semi_transparency as u32) << 5; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.semi_transparency)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gpu.rs:442:21 [INFO] [stderr] | [INFO] [stderr] 442 | self.vres = match value & 0x4 != 0 { [INFO] [stderr] | _____________________^ [INFO] [stderr] 443 | | false => VerticalRes::Y240Lines, [INFO] [stderr] 444 | | true => VerticalRes::Y480Lines, [INFO] [stderr] 445 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if value & 0x4 != 0 { VerticalRes::Y480Lines } else { VerticalRes::Y240Lines }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gpu.rs:447:22 [INFO] [stderr] | [INFO] [stderr] 447 | self.vmode = match value & 0x8 != 0 { [INFO] [stderr] | ______________________^ [INFO] [stderr] 448 | | false => VMode::NTSC, [INFO] [stderr] 449 | | true => VMode::PAL, [INFO] [stderr] 450 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if value & 0x8 != 0 { VMode::PAL } else { VMode::NTSC }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gpu.rs:452:30 [INFO] [stderr] | [INFO] [stderr] 452 | self.display_depth = match value & 0x10 != 0 { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 453 | | false => DisplayDepth::D24Bits, [INFO] [stderr] 454 | | true => DisplayDepth::D15Bits, [INFO] [stderr] 455 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if value & 0x10 != 0 { DisplayDepth::D15Bits } else { DisplayDepth::D24Bits }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/gpu.rs:545:9 [INFO] [stderr] | [INFO] [stderr] 545 | (hr as u32) << 16 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(hr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/gpu.rs:576:5 [INFO] [stderr] | [INFO] [stderr] 576 | / fn index<'a>(&'a self, index: usize) -> &'a u32 { [INFO] [stderr] 577 | | if index >= self.length as usize { [INFO] [stderr] 578 | | panic!("Command buffer index out of range"); [INFO] [stderr] 579 | | } [INFO] [stderr] 580 | | [INFO] [stderr] 581 | | &self.buffer[index] [INFO] [stderr] 582 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `PSX`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "36bc736ed24aa04928b4e24b56c3dd017f6b98cdbe1a573c87e3c65d90c8d781"` [INFO] running `"docker" "rm" "-f" "36bc736ed24aa04928b4e24b56c3dd017f6b98cdbe1a573c87e3c65d90c8d781"` [INFO] [stdout] 36bc736ed24aa04928b4e24b56c3dd017f6b98cdbe1a573c87e3c65d90c8d781