[INFO] updating cached repository noirotm/fishr [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/noirotm/fishr [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/noirotm/fishr" "work/ex/clippy-test-run/sources/stable/gh/noirotm/fishr"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/noirotm/fishr'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/noirotm/fishr" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/noirotm/fishr"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/noirotm/fishr'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 43943ee709835577f601d81e8f94eb02f6182bbf [INFO] sha for GitHub repo noirotm/fishr: 43943ee709835577f601d81e8f94eb02f6182bbf [INFO] validating manifest of noirotm/fishr on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of noirotm/fishr on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing noirotm/fishr [INFO] finished frobbing noirotm/fishr [INFO] frobbed toml for noirotm/fishr written to work/ex/clippy-test-run/sources/stable/gh/noirotm/fishr/Cargo.toml [INFO] started frobbing noirotm/fishr [INFO] finished frobbing noirotm/fishr [INFO] frobbed toml for noirotm/fishr written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/noirotm/fishr/Cargo.toml [INFO] crate noirotm/fishr has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting noirotm/fishr against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/noirotm/fishr:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ba7ec197a1368710211864572e978dbf1fbfe21ef1d628f90ef6de5bd1c78f0b [INFO] running `"docker" "start" "-a" "ba7ec197a1368710211864572e978dbf1fbfe21ef1d628f90ef6de5bd1c78f0b"` [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking clap v2.30.0 [INFO] [stderr] Checking serde_json v1.0.9 [INFO] [stderr] Checking fishr v0.1.0 (/opt/crater/workdir) [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/val.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | assert_eq!(val.to_f64(), 15.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/val.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | assert_eq!(val.to_f64(), 15.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/stack.rs:502:13 [INFO] [stderr] | [INFO] [stderr] 502 | let _ = s.top().switch_register().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/stack.rs:503:13 [INFO] [stderr] | [INFO] [stderr] 503 | let _ = s.push_stack(1).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/stack.rs:519:13 [INFO] [stderr] | [INFO] [stderr] 519 | let _ = s.push_stack(2).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/stack.rs:520:13 [INFO] [stderr] | [INFO] [stderr] 520 | let _ = s.top().switch_register().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/stack.rs:536:13 [INFO] [stderr] | [INFO] [stderr] 536 | let _ = s.top().switch_register().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `fishr`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "ba7ec197a1368710211864572e978dbf1fbfe21ef1d628f90ef6de5bd1c78f0b"` [INFO] running `"docker" "rm" "-f" "ba7ec197a1368710211864572e978dbf1fbfe21ef1d628f90ef6de5bd1c78f0b"` [INFO] [stdout] ba7ec197a1368710211864572e978dbf1fbfe21ef1d628f90ef6de5bd1c78f0b