[INFO] updating cached repository nkoehring/blob [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nkoehring/blob [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nkoehring/blob" "work/ex/clippy-test-run/sources/stable/gh/nkoehring/blob"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nkoehring/blob'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nkoehring/blob" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nkoehring/blob"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nkoehring/blob'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 46016fabf6f812658c5599b7539ac2686758fc17 [INFO] sha for GitHub repo nkoehring/blob: 46016fabf6f812658c5599b7539ac2686758fc17 [INFO] validating manifest of nkoehring/blob on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nkoehring/blob on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nkoehring/blob [INFO] finished frobbing nkoehring/blob [INFO] frobbed toml for nkoehring/blob written to work/ex/clippy-test-run/sources/stable/gh/nkoehring/blob/Cargo.toml [INFO] started frobbing nkoehring/blob [INFO] finished frobbing nkoehring/blob [INFO] frobbed toml for nkoehring/blob written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nkoehring/blob/Cargo.toml [INFO] crate nkoehring/blob has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nkoehring/blob against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nkoehring/blob:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] beca29c718bd4b3cd3fdca1633362c6e645e27a1806929221240027fbe6844ce [INFO] running `"docker" "start" "-a" "beca29c718bd4b3cd3fdca1633362c6e645e27a1806929221240027fbe6844ce"` [INFO] [stderr] Checking thread_local v0.3.2 [INFO] [stderr] Checking aho-corasick v0.6.1 [INFO] [stderr] Checking regex v0.2.1 [INFO] [stderr] Checking blob v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:40:36 [INFO] [stderr] | [INFO] [stderr] 40 | let parts: Vec<&str> = l.split(",").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:179:13 [INFO] [stderr] | [INFO] [stderr] 179 | let ids = match ids_path.ends_with(".csv") { [INFO] [stderr] | _____________^ [INFO] [stderr] 180 | | true => read_csv(ids_path), [INFO] [stderr] 181 | | false => read_ids(ids_path), [INFO] [stderr] 182 | | }; [INFO] [stderr] | |___^ help: consider using an if/else expression: `if ids_path.ends_with(".csv") { read_csv(ids_path) } else { read_ids(ids_path) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:40:36 [INFO] [stderr] | [INFO] [stderr] 40 | let parts: Vec<&str> = l.split(",").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:179:13 [INFO] [stderr] | [INFO] [stderr] 179 | let ids = match ids_path.ends_with(".csv") { [INFO] [stderr] | _____________^ [INFO] [stderr] 180 | | true => read_csv(ids_path), [INFO] [stderr] 181 | | false => read_ids(ids_path), [INFO] [stderr] 182 | | }; [INFO] [stderr] | |___^ help: consider using an if/else expression: `if ids_path.ends_with(".csv") { read_csv(ids_path) } else { read_ids(ids_path) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.10s [INFO] running `"docker" "inspect" "beca29c718bd4b3cd3fdca1633362c6e645e27a1806929221240027fbe6844ce"` [INFO] running `"docker" "rm" "-f" "beca29c718bd4b3cd3fdca1633362c6e645e27a1806929221240027fbe6844ce"` [INFO] [stdout] beca29c718bd4b3cd3fdca1633362c6e645e27a1806929221240027fbe6844ce