[INFO] updating cached repository ninjapenguin/marky [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ninjapenguin/marky [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ninjapenguin/marky" "work/ex/clippy-test-run/sources/stable/gh/ninjapenguin/marky"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ninjapenguin/marky'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ninjapenguin/marky" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ninjapenguin/marky"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ninjapenguin/marky'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fedf8ddc7ea152a9830a1d4051b9dc809551921b [INFO] sha for GitHub repo ninjapenguin/marky: fedf8ddc7ea152a9830a1d4051b9dc809551921b [INFO] validating manifest of ninjapenguin/marky on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ninjapenguin/marky on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ninjapenguin/marky [INFO] finished frobbing ninjapenguin/marky [INFO] frobbed toml for ninjapenguin/marky written to work/ex/clippy-test-run/sources/stable/gh/ninjapenguin/marky/Cargo.toml [INFO] started frobbing ninjapenguin/marky [INFO] finished frobbing ninjapenguin/marky [INFO] frobbed toml for ninjapenguin/marky written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ninjapenguin/marky/Cargo.toml [INFO] crate ninjapenguin/marky has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ninjapenguin/marky against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ninjapenguin/marky:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f15ebb9c7cad3903ba635fd518ea728cdd1f10a6747500005b38afaa9fae7f9a [INFO] running `"docker" "start" "-a" "f15ebb9c7cad3903ba635fd518ea728cdd1f10a6747500005b38afaa9fae7f9a"` [INFO] [stderr] Checking rand_core v0.1.0 [INFO] [stderr] Checking rand v0.5.0-pre.1 [INFO] [stderr] Checking markov v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:59:12 [INFO] [stderr] | [INFO] [stderr] 59 | if last.is_empty() == false && last_plus.is_empty() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!last.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:59:40 [INFO] [stderr] | [INFO] [stderr] 59 | if last.is_empty() == false && last_plus.is_empty() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!last_plus.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/main.rs:74:14 [INFO] [stderr] | [INFO] [stderr] 74 | fn run_chain<'a>(chain: HashMap<(&str, &str), Vec<&str>>, config: Config) -> String { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:98:36 [INFO] [stderr] | [INFO] [stderr] 98 | if picked.contains(".") || picked.contains("!") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:98:60 [INFO] [stderr] | [INFO] [stderr] 98 | if picked.contains(".") || picked.contains("!") { [INFO] [stderr] | ^^^ help: try using a char instead: `'!'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:59:12 [INFO] [stderr] | [INFO] [stderr] 59 | if last.is_empty() == false && last_plus.is_empty() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!last.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:59:40 [INFO] [stderr] | [INFO] [stderr] 59 | if last.is_empty() == false && last_plus.is_empty() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!last_plus.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/main.rs:74:14 [INFO] [stderr] | [INFO] [stderr] 74 | fn run_chain<'a>(chain: HashMap<(&str, &str), Vec<&str>>, config: Config) -> String { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:98:36 [INFO] [stderr] | [INFO] [stderr] 98 | if picked.contains(".") || picked.contains("!") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:98:60 [INFO] [stderr] | [INFO] [stderr] 98 | if picked.contains(".") || picked.contains("!") { [INFO] [stderr] | ^^^ help: try using a char instead: `'!'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.39s [INFO] running `"docker" "inspect" "f15ebb9c7cad3903ba635fd518ea728cdd1f10a6747500005b38afaa9fae7f9a"` [INFO] running `"docker" "rm" "-f" "f15ebb9c7cad3903ba635fd518ea728cdd1f10a6747500005b38afaa9fae7f9a"` [INFO] [stdout] f15ebb9c7cad3903ba635fd518ea728cdd1f10a6747500005b38afaa9fae7f9a