[INFO] updating cached repository nielsutrecht/adventofrust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nielsutrecht/adventofrust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nielsutrecht/adventofrust" "work/ex/clippy-test-run/sources/stable/gh/nielsutrecht/adventofrust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nielsutrecht/adventofrust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nielsutrecht/adventofrust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nielsutrecht/adventofrust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nielsutrecht/adventofrust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bd42a28d86550e5c4dc4fd9c5cc5cf4cbe1fd5d7 [INFO] sha for GitHub repo nielsutrecht/adventofrust: bd42a28d86550e5c4dc4fd9c5cc5cf4cbe1fd5d7 [INFO] validating manifest of nielsutrecht/adventofrust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nielsutrecht/adventofrust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nielsutrecht/adventofrust [INFO] finished frobbing nielsutrecht/adventofrust [INFO] frobbed toml for nielsutrecht/adventofrust written to work/ex/clippy-test-run/sources/stable/gh/nielsutrecht/adventofrust/Cargo.toml [INFO] started frobbing nielsutrecht/adventofrust [INFO] finished frobbing nielsutrecht/adventofrust [INFO] frobbed toml for nielsutrecht/adventofrust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nielsutrecht/adventofrust/Cargo.toml [INFO] crate nielsutrecht/adventofrust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nielsutrecht/adventofrust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nielsutrecht/adventofrust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 63c0bf9c55aa0df854225a03e98f44647c97b1dcb684c63bde07e307dedb5431 [INFO] running `"docker" "start" "-a" "63c0bf9c55aa0df854225a03e98f44647c97b1dcb684c63bde07e307dedb5431"` [INFO] [stderr] Checking advent_of_code v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/io/mod.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | / return read_to_string(file_name(year, day)) [INFO] [stderr] 8 | | .expect("Something went wrong reading the file"); [INFO] [stderr] | |_________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 7 | read_to_string(file_name(year, day)) [INFO] [stderr] 8 | .expect("Something went wrong reading the file") [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/io/mod.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / return buf.lines() [INFO] [stderr] 16 | | .map(|l| l.expect("Could not parse line")) [INFO] [stderr] 17 | | .collect(); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 15 | buf.lines() [INFO] [stderr] 16 | .map(|l| l.expect("Could not parse line")) [INFO] [stderr] 17 | .collect() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/convert/mod.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/convert/mod.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / return v.into_iter() [INFO] [stderr] 15 | | .map(|s| { [INFO] [stderr] 16 | | s.split_whitespace() [INFO] [stderr] 17 | | .into_iter() [INFO] [stderr] 18 | | .map(|e | e.parse::().expect("Parse error")) [INFO] [stderr] 19 | | .collect() [INFO] [stderr] 20 | | }).collect() [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 14 | v.into_iter() [INFO] [stderr] 15 | .map(|s| { [INFO] [stderr] 16 | s.split_whitespace() [INFO] [stderr] 17 | .into_iter() [INFO] [stderr] 18 | .map(|e | e.parse::().expect("Parse error")) [INFO] [stderr] 19 | .collect() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/convert/mod.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | return out [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/calc/point.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | return Point::new(self.x + x, self.y + y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Point::new(self.x + x, self.y + y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/calc/point.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | return self.x >= min_x && self.x <= max_x && self.y >= min_y && self.y <= max_y; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.x >= min_x && self.x <= max_x && self.y >= min_y && self.y <= max_y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/calc/point.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | return (self.x - other.x).abs() + (self.y - other.y).abs() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.x - other.x).abs() + (self.y - other.y).abs()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/calc/point.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | / return match direction { [INFO] [stderr] 45 | | DirectionCompass::N => self.add(0, -1), [INFO] [stderr] 46 | | DirectionCompass::E => self.add(1, 0), [INFO] [stderr] 47 | | DirectionCompass::S => self.add(0, 1), [INFO] [stderr] 48 | | DirectionCompass::W => self.add(-1, 0) [INFO] [stderr] 49 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 44 | match direction { [INFO] [stderr] 45 | DirectionCompass::N => self.add(0, -1), [INFO] [stderr] 46 | DirectionCompass::E => self.add(1, 0), [INFO] [stderr] 47 | DirectionCompass::S => self.add(0, 1), [INFO] [stderr] 48 | DirectionCompass::W => self.add(-1, 0) [INFO] [stderr] 49 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/calc/point.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | return Point::new(self.x + _rhs.x, self.y + _rhs.y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Point::new(self.x + _rhs.x, self.y + _rhs.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/calc/point.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | return Point::new(self.x - _rhs.x, self.y - _rhs.y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Point::new(self.x - _rhs.x, self.y - _rhs.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/io/mod.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | / return read_to_string(file_name(year, day)) [INFO] [stderr] 8 | | .expect("Something went wrong reading the file"); [INFO] [stderr] | |_________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 7 | read_to_string(file_name(year, day)) [INFO] [stderr] 8 | .expect("Something went wrong reading the file") [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/io/mod.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / return buf.lines() [INFO] [stderr] 16 | | .map(|l| l.expect("Could not parse line")) [INFO] [stderr] 17 | | .collect(); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 15 | buf.lines() [INFO] [stderr] 16 | .map(|l| l.expect("Could not parse line")) [INFO] [stderr] 17 | .collect() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/convert/mod.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/convert/mod.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / return v.into_iter() [INFO] [stderr] 15 | | .map(|s| { [INFO] [stderr] 16 | | s.split_whitespace() [INFO] [stderr] 17 | | .into_iter() [INFO] [stderr] 18 | | .map(|e | e.parse::().expect("Parse error")) [INFO] [stderr] 19 | | .collect() [INFO] [stderr] 20 | | }).collect() [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 14 | v.into_iter() [INFO] [stderr] 15 | .map(|s| { [INFO] [stderr] 16 | s.split_whitespace() [INFO] [stderr] 17 | .into_iter() [INFO] [stderr] 18 | .map(|e | e.parse::().expect("Parse error")) [INFO] [stderr] 19 | .collect() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/convert/mod.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | return out [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/convert/mod.rs:54:33 [INFO] [stderr] | [INFO] [stderr] 54 | assert_eq!(-123, result[01][1]); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 54 | assert_eq!(-123, result[1][1]); [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 54 | assert_eq!(-123, result[0o1][1]); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/calc/point.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | return Point::new(self.x + x, self.y + y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Point::new(self.x + x, self.y + y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/calc/point.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | return self.x >= min_x && self.x <= max_x && self.y >= min_y && self.y <= max_y; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.x >= min_x && self.x <= max_x && self.y >= min_y && self.y <= max_y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/calc/point.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | return (self.x - other.x).abs() + (self.y - other.y).abs() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.x - other.x).abs() + (self.y - other.y).abs()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/calc/point.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | / return match direction { [INFO] [stderr] 45 | | DirectionCompass::N => self.add(0, -1), [INFO] [stderr] 46 | | DirectionCompass::E => self.add(1, 0), [INFO] [stderr] 47 | | DirectionCompass::S => self.add(0, 1), [INFO] [stderr] 48 | | DirectionCompass::W => self.add(-1, 0) [INFO] [stderr] 49 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 44 | match direction { [INFO] [stderr] 45 | DirectionCompass::N => self.add(0, -1), [INFO] [stderr] 46 | DirectionCompass::E => self.add(1, 0), [INFO] [stderr] 47 | DirectionCompass::S => self.add(0, 1), [INFO] [stderr] 48 | DirectionCompass::W => self.add(-1, 0) [INFO] [stderr] 49 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/calc/point.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | return Point::new(self.x + _rhs.x, self.y + _rhs.y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Point::new(self.x + _rhs.x, self.y + _rhs.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/calc/point.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | return Point::new(self.x - _rhs.x, self.y - _rhs.y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Point::new(self.x - _rhs.x, self.y - _rhs.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/calc/point.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | return super::Point::new(x, y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `super::Point::new(x, y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: method is never used: `origin` [INFO] [stderr] --> src/calc/point.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | fn origin() -> Point { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `add` [INFO] [stderr] --> src/calc/point.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | fn add(&self, x: i32, y: i32) -> Point { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `within_points` [INFO] [stderr] --> src/calc/point.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | fn within_points(&self, a: Point, b: Point) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `manhattan` [INFO] [stderr] --> src/calc/point.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | fn manhattan(&self, other: Point) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `add_direction` [INFO] [stderr] --> src/calc/point.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | fn add_direction(&self, direction: DirectionCompass) -> Point { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `rotate90` [INFO] [stderr] --> src/calc/point.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | fn rotate90(&self) -> Point { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/convert/mod.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | / s.split_whitespace() [INFO] [stderr] 17 | | .into_iter() [INFO] [stderr] | |____________________________^ help: consider removing `.into_iter()`: `s.split_whitespace()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/calc/point.rs:26:12 [INFO] [stderr] | [INFO] [stderr] 26 | fn add(&self, x: i32, y: i32) -> Point { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/calc/point.rs:30:22 [INFO] [stderr] | [INFO] [stderr] 30 | fn within_points(&self, a: Point, b: Point) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/calc/point.rs:39:18 [INFO] [stderr] | [INFO] [stderr] 39 | fn manhattan(&self, other: Point) -> i32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/calc/point.rs:43:22 [INFO] [stderr] | [INFO] [stderr] 43 | fn add_direction(&self, direction: DirectionCompass) -> Point { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/calc/point.rs:52:17 [INFO] [stderr] | [INFO] [stderr] 52 | fn rotate90(&self) -> Point { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day1702.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | return (lowest, highest); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(lowest, highest)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day1702.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day1702.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | return Day1702 { sheet }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Day1702 { sheet }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day1702.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | return x.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `x.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day1702.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | return x.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `x.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day1701.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | return sum.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sum.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day1701.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | return Day1701 { digits }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Day1701 { digits }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day1701.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | return Day1701::solve(&self.digits, part_1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Day1701::solve(&self.digits, part_1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day1701.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | return Day1701::solve(&self.digits, part_2) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Day1701::solve(&self.digits, part_2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/day1701.rs:12:25 [INFO] [stderr] | [INFO] [stderr] 12 | fn solve(digits: &Vec, f: F) -> String where F: Fn(usize) -> usize { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/convert/mod.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | / s.split_whitespace() [INFO] [stderr] 17 | | .into_iter() [INFO] [stderr] | |____________________________^ help: consider removing `.into_iter()`: `s.split_whitespace()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/calc/point.rs:26:12 [INFO] [stderr] | [INFO] [stderr] 26 | fn add(&self, x: i32, y: i32) -> Point { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/calc/point.rs:30:22 [INFO] [stderr] | [INFO] [stderr] 30 | fn within_points(&self, a: Point, b: Point) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/calc/point.rs:39:18 [INFO] [stderr] | [INFO] [stderr] 39 | fn manhattan(&self, other: Point) -> i32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/calc/point.rs:43:22 [INFO] [stderr] | [INFO] [stderr] 43 | fn add_direction(&self, direction: DirectionCompass) -> Point { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/calc/point.rs:52:17 [INFO] [stderr] | [INFO] [stderr] 52 | fn rotate90(&self) -> Point { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day1702.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | return (lowest, highest); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(lowest, highest)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day1702.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day1702.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | return Day1702 { sheet }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Day1702 { sheet }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day1702.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | return x.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `x.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day1702.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | return x.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `x.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:19:24 [INFO] [stderr] | [INFO] [stderr] 19 | Ok(num) => return num, [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `num` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:20:23 [INFO] [stderr] | [INFO] [stderr] 20 | Err(_) => return 0, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | return 0 [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:19:24 [INFO] [stderr] | [INFO] [stderr] 19 | Ok(num) => return num, [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `num` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:20:23 [INFO] [stderr] | [INFO] [stderr] 20 | Err(_) => return 0, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | return 0 [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day1701.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | return sum.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sum.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day1701.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | return Day1701 { digits }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Day1701 { digits }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day1701.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | return Day1701::solve(&self.digits, part_1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Day1701::solve(&self.digits, part_1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day1701.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | return Day1701::solve(&self.digits, part_2) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Day1701::solve(&self.digits, part_2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/day1701.rs:12:25 [INFO] [stderr] | [INFO] [stderr] 12 | fn solve(digits: &Vec, f: F) -> String where F: Fn(usize) -> usize { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.11s [INFO] running `"docker" "inspect" "63c0bf9c55aa0df854225a03e98f44647c97b1dcb684c63bde07e307dedb5431"` [INFO] running `"docker" "rm" "-f" "63c0bf9c55aa0df854225a03e98f44647c97b1dcb684c63bde07e307dedb5431"` [INFO] [stdout] 63c0bf9c55aa0df854225a03e98f44647c97b1dcb684c63bde07e307dedb5431