[INFO] updating cached repository nicohman/carbon
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/nicohman/carbon
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/nicohman/carbon" "work/ex/clippy-test-run/sources/stable/gh/nicohman/carbon"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nicohman/carbon'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/nicohman/carbon" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nicohman/carbon"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nicohman/carbon'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] fc78e9cd355415edbfbea87aada6dcee6cdec8d1
[INFO] sha for GitHub repo nicohman/carbon: fc78e9cd355415edbfbea87aada6dcee6cdec8d1
[INFO] validating manifest of nicohman/carbon on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of nicohman/carbon on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing nicohman/carbon
[INFO] finished frobbing nicohman/carbon
[INFO] frobbed toml for nicohman/carbon written to work/ex/clippy-test-run/sources/stable/gh/nicohman/carbon/Cargo.toml
[INFO] started frobbing nicohman/carbon
[INFO] finished frobbing nicohman/carbon
[INFO] frobbed toml for nicohman/carbon written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nicohman/carbon/Cargo.toml
[INFO] crate nicohman/carbon has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting nicohman/carbon against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nicohman/carbon:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 018df81f7a25e7519cd457170fce4ddc9f401de0493ca535f3de25e1b7fb7e50
[INFO] running `"docker" "start" "-a" "018df81f7a25e7519cd457170fce4ddc9f401de0493ca535f3de25e1b7fb7e50"`
[INFO] [stderr]     Checking carbon v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unused import: `std::str::FromStr`
[INFO] [stderr]  --> src/bin/carbon.rs:8:5
[INFO] [stderr]   |
[INFO] [stderr] 8 | use std::str::FromStr;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/bin/carbon.rs:179:5
[INFO] [stderr]     |
[INFO] [stderr] 179 |     return String::from(env::home_dir().unwrap().to_str().unwrap());
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from(env::home_dir().unwrap().to_str().unwrap())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/bin/carbon.rs:184:5
[INFO] [stderr]     |
[INFO] [stderr] 184 |     return base;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `base`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]    --> src/bin/carbon.rs:179:25
[INFO] [stderr]     |
[INFO] [stderr] 179 |     return String::from(env::home_dir().unwrap().to_str().unwrap());
[INFO] [stderr]     |                         ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::str::FromStr`
[INFO] [stderr]  --> src/bin/carbon.rs:8:5
[INFO] [stderr]   |
[INFO] [stderr] 8 | use std::str::FromStr;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/bin/carbon.rs:179:5
[INFO] [stderr]     |
[INFO] [stderr] 179 |     return String::from(env::home_dir().unwrap().to_str().unwrap());
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from(env::home_dir().unwrap().to_str().unwrap())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/bin/carbon.rs:184:5
[INFO] [stderr]     |
[INFO] [stderr] 184 |     return base;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `base`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]    --> src/bin/carbon.rs:179:25
[INFO] [stderr]     |
[INFO] [stderr] 179 |     return String::from(env::home_dir().unwrap().to_str().unwrap());
[INFO] [stderr]     |                         ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `disp`
[INFO] [stderr]   --> src/bin/carbon.rs:81:23
[INFO] [stderr]    |
[INFO] [stderr] 81 | fn gen_npc(sys: &str, disp: bool) {
[INFO] [stderr]    |                       ^^^^ help: consider using `_disp` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/bin/carbon.rs:91:9
[INFO] [stderr]    |
[INFO] [stderr] 91 |     let mut vec: Vec<String>;
[INFO] [stderr]    |         ----^^^
[INFO] [stderr]    |         |
[INFO] [stderr]    |         help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: struct is never constructed: `Npc`
[INFO] [stderr]   --> src/bin/carbon.rs:10:1
[INFO] [stderr]    |
[INFO] [stderr] 10 | struct Npc {
[INFO] [stderr]    | ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `to_string`
[INFO] [stderr]   --> src/bin/carbon.rs:17:5
[INFO] [stderr]    |
[INFO] [stderr] 17 |     fn to_string(&self) -> String {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `add_npc`
[INFO] [stderr]   --> src/bin/carbon.rs:76:1
[INFO] [stderr]    |
[INFO] [stderr] 76 | fn add_npc(npc:Npc, camp:&str){
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `proc_path`
[INFO] [stderr]    --> src/bin/carbon.rs:181:1
[INFO] [stderr]     |
[INFO] [stderr] 181 | fn proc_path(path: DirEntry) -> String {
[INFO] [stderr]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/bin/carbon.rs:18:99
[INFO] [stderr]    |
[INFO] [stderr] 18 |         let skills:String = self.skills.keys().map(|key| String::from("|")+&key+":"+&format!("{}",self.skills.get(key).unwrap())).collect::<String>();
[INFO] [stderr]    |                                                                                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.skills[key]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]   --> src/bin/carbon.rs:44:8
[INFO] [stderr]    |
[INFO] [stderr] 44 |     if opts.len() < 1 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `opts.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/bin/carbon.rs:138:20
[INFO] [stderr]     |
[INFO] [stderr] 138 |         let camp = String::from(String::from(name.as_ref()) + "\n" + &sys + "\n" + &desc);
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `String::from(name.as_ref()) + "\n" + &sys + "\n" + &desc`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `disp`
[INFO] [stderr]   --> src/bin/carbon.rs:81:23
[INFO] [stderr]    |
[INFO] [stderr] 81 | fn gen_npc(sys: &str, disp: bool) {
[INFO] [stderr]    |                       ^^^^ help: consider using `_disp` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/bin/carbon.rs:91:9
[INFO] [stderr]    |
[INFO] [stderr] 91 |     let mut vec: Vec<String>;
[INFO] [stderr]    |         ----^^^
[INFO] [stderr]    |         |
[INFO] [stderr]    |         help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: struct is never constructed: `Npc`
[INFO] [stderr]   --> src/bin/carbon.rs:10:1
[INFO] [stderr]    |
[INFO] [stderr] 10 | struct Npc {
[INFO] [stderr]    | ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `to_string`
[INFO] [stderr]   --> src/bin/carbon.rs:17:5
[INFO] [stderr]    |
[INFO] [stderr] 17 |     fn to_string(&self) -> String {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `add_npc`
[INFO] [stderr]   --> src/bin/carbon.rs:76:1
[INFO] [stderr]    |
[INFO] [stderr] 76 | fn add_npc(npc:Npc, camp:&str){
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `proc_path`
[INFO] [stderr]    --> src/bin/carbon.rs:181:1
[INFO] [stderr]     |
[INFO] [stderr] 181 | fn proc_path(path: DirEntry) -> String {
[INFO] [stderr]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/bin/carbon.rs:18:99
[INFO] [stderr]    |
[INFO] [stderr] 18 |         let skills:String = self.skills.keys().map(|key| String::from("|")+&key+":"+&format!("{}",self.skills.get(key).unwrap())).collect::<String>();
[INFO] [stderr]    |                                                                                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.skills[key]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]   --> src/bin/carbon.rs:44:8
[INFO] [stderr]    |
[INFO] [stderr] 44 |     if opts.len() < 1 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `opts.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/bin/carbon.rs:138:20
[INFO] [stderr]     |
[INFO] [stderr] 138 |         let camp = String::from(String::from(name.as_ref()) + "\n" + &sys + "\n" + &desc);
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `String::from(name.as_ref()) + "\n" + &sys + "\n" + &desc`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.87s
[INFO] running `"docker" "inspect" "018df81f7a25e7519cd457170fce4ddc9f401de0493ca535f3de25e1b7fb7e50"`
[INFO] running `"docker" "rm" "-f" "018df81f7a25e7519cd457170fce4ddc9f401de0493ca535f3de25e1b7fb7e50"`
[INFO] [stdout] 018df81f7a25e7519cd457170fce4ddc9f401de0493ca535f3de25e1b7fb7e50