[INFO] updating cached repository nickrtorres/bdgt [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nickrtorres/bdgt [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nickrtorres/bdgt" "work/ex/clippy-test-run/sources/stable/gh/nickrtorres/bdgt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nickrtorres/bdgt'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nickrtorres/bdgt" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nickrtorres/bdgt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nickrtorres/bdgt'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 683f6285a32cfb1f0136f74f27857ec5ea7f6e0b [INFO] sha for GitHub repo nickrtorres/bdgt: 683f6285a32cfb1f0136f74f27857ec5ea7f6e0b [INFO] validating manifest of nickrtorres/bdgt on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nickrtorres/bdgt on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nickrtorres/bdgt [INFO] finished frobbing nickrtorres/bdgt [INFO] frobbed toml for nickrtorres/bdgt written to work/ex/clippy-test-run/sources/stable/gh/nickrtorres/bdgt/Cargo.toml [INFO] started frobbing nickrtorres/bdgt [INFO] finished frobbing nickrtorres/bdgt [INFO] frobbed toml for nickrtorres/bdgt written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nickrtorres/bdgt/Cargo.toml [INFO] crate nickrtorres/bdgt has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nickrtorres/bdgt against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nickrtorres/bdgt:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d72dca72cc7cda1c6057ce2c883b9747f8aaddf0bcd969a76c65d908cdbf2363 [INFO] running `"docker" "start" "-a" "d72dca72cc7cda1c6057ce2c883b9747f8aaddf0bcd969a76c65d908cdbf2363"` [INFO] [stderr] Checking bdgt v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/system.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | return if Path::new(&format!("{}/.bdgt", path_string)).exists() { true } else { false } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `if Path::new(&format!("{}/.bdgt", path_string)).exists() { true } else { false }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/system.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | return if Path::new(&format!("{}/.bdgt/{}", bdgt_home, file)).exists() { true } else { false } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `if Path::new(&format!("{}/.bdgt/{}", bdgt_home, file)).exists() { true } else { false }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/system.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | return output; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | return '~'; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `'~'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/system.rs:25:11 [INFO] [stderr] | [INFO] [stderr] 25 | match env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `v` [INFO] [stderr] --> src/system.rs:62:12 [INFO] [stderr] | [INFO] [stderr] 62 | Ok(v) => get_signum(input, &mut output), // this is a hack :( [INFO] [stderr] | ^ help: consider using `_v` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/system.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | Err(e) => util::error_exit("unable to get user input"), [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/system.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | return if Path::new(&format!("{}/.bdgt", path_string)).exists() { true } else { false } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `if Path::new(&format!("{}/.bdgt", path_string)).exists() { true } else { false }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/system.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | return if Path::new(&format!("{}/.bdgt/{}", bdgt_home, file)).exists() { true } else { false } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `if Path::new(&format!("{}/.bdgt/{}", bdgt_home, file)).exists() { true } else { false }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/system.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | return output; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | return '~'; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `'~'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/system.rs:22:12 [INFO] [stderr] | [INFO] [stderr] 22 | return if Path::new(&format!("{}/.bdgt", path_string)).exists() { true } else { false } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `Path::new(&format!("{}/.bdgt", path_string)).exists()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/system.rs:41:12 [INFO] [stderr] | [INFO] [stderr] 41 | return if Path::new(&format!("{}/.bdgt/{}", bdgt_home, file)).exists() { true } else { false } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `Path::new(&format!("{}/.bdgt/{}", bdgt_home, file)).exists()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/system.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | io::stdout().flush().ok().expect("Could not flush stdout"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/system.rs:25:11 [INFO] [stderr] | [INFO] [stderr] 25 | match env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `v` [INFO] [stderr] --> src/system.rs:62:12 [INFO] [stderr] | [INFO] [stderr] 62 | Ok(v) => get_signum(input, &mut output), // this is a hack :( [INFO] [stderr] | ^ help: consider using `_v` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/system.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | Err(e) => util::error_exit("unable to get user input"), [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/system.rs:22:12 [INFO] [stderr] | [INFO] [stderr] 22 | return if Path::new(&format!("{}/.bdgt", path_string)).exists() { true } else { false } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `Path::new(&format!("{}/.bdgt", path_string)).exists()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/system.rs:41:12 [INFO] [stderr] | [INFO] [stderr] 41 | return if Path::new(&format!("{}/.bdgt/{}", bdgt_home, file)).exists() { true } else { false } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `Path::new(&format!("{}/.bdgt/{}", bdgt_home, file)).exists()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/system.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | io::stdout().flush().ok().expect("Could not flush stdout"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.64s [INFO] running `"docker" "inspect" "d72dca72cc7cda1c6057ce2c883b9747f8aaddf0bcd969a76c65d908cdbf2363"` [INFO] running `"docker" "rm" "-f" "d72dca72cc7cda1c6057ce2c883b9747f8aaddf0bcd969a76c65d908cdbf2363"` [INFO] [stdout] d72dca72cc7cda1c6057ce2c883b9747f8aaddf0bcd969a76c65d908cdbf2363