[INFO] updating cached repository nicklauri/aden [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nicklauri/aden [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nicklauri/aden" "work/ex/clippy-test-run/sources/stable/gh/nicklauri/aden"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nicklauri/aden'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nicklauri/aden" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nicklauri/aden"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nicklauri/aden'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b2acd1e35a2f95212c785eb2b75ee570d2f686f0 [INFO] sha for GitHub repo nicklauri/aden: b2acd1e35a2f95212c785eb2b75ee570d2f686f0 [INFO] validating manifest of nicklauri/aden on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nicklauri/aden on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nicklauri/aden [INFO] finished frobbing nicklauri/aden [INFO] frobbed toml for nicklauri/aden written to work/ex/clippy-test-run/sources/stable/gh/nicklauri/aden/Cargo.toml [INFO] started frobbing nicklauri/aden [INFO] finished frobbing nicklauri/aden [INFO] frobbed toml for nicklauri/aden written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nicklauri/aden/Cargo.toml [INFO] crate nicklauri/aden has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nicklauri/aden against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nicklauri/aden:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3bd0fbfbb54885b9a1543b31cc080b044a02dec7b016fa1c27c9bd926b0f6e3a [INFO] running `"docker" "start" "-a" "3bd0fbfbb54885b9a1543b31cc080b044a02dec7b016fa1c27c9bd926b0f6e3a"` [INFO] [stderr] Checking aden v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/server_side/response.rs:110:3 [INFO] [stderr] | [INFO] [stderr] 110 | if !self.is_ready { [INFO] [stderr] | _________^ [INFO] [stderr] 111 | | if !self.http_ver.is_empty() && self.status_code != 0 [INFO] [stderr] 112 | | && !self.status_msg.is_empty() && self.header.len() > 0 [INFO] [stderr] 113 | | && self.content_length > 0 { [INFO] [stderr] 114 | | self.is_ready = true; [INFO] [stderr] 115 | | } [INFO] [stderr] 116 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 110 | if !self.is_ready && !self.http_ver.is_empty() && self.status_code != 0 [INFO] [stderr] 111 | && !self.status_msg.is_empty() && self.header.len() > 0 [INFO] [stderr] 112 | && self.content_length > 0 { [INFO] [stderr] 113 | self.is_ready = true; [INFO] [stderr] 114 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/server_side/utils.rs:28:37 [INFO] [stderr] | [INFO] [stderr] 28 | elapsed.subsec_nanos() as f64 * 0.000001; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.000_001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/server_side/utils.rs:45:37 [INFO] [stderr] | [INFO] [stderr] 45 | elapsed.subsec_nanos() as f64 * 0.000000001; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.000_000_001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/server_side/utils.rs:57:37 [INFO] [stderr] | [INFO] [stderr] 57 | elapsed.subsec_nanos() as f64 * 0.000000001; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.000_000_001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/server_side/mod.rs:178:4 [INFO] [stderr] | [INFO] [stderr] 178 | if rrhlen > 4 { [INFO] [stderr] | _____________^ [INFO] [stderr] 179 | | if req_raw_header[rrhlen - 1] == '\n' as u8 && req_raw_header[rrhlen - 2] == '\r' as u8 [INFO] [stderr] 180 | | && req_raw_header[rrhlen - 3] == '\n' as u8 && req_raw_header[rrhlen - 4] == '\r' as u8 { [INFO] [stderr] 181 | | break; [INFO] [stderr] 182 | | } [INFO] [stderr] 183 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 178 | if rrhlen > 4 && req_raw_header[rrhlen - 1] == '\n' as u8 && req_raw_header[rrhlen - 2] == '\r' as u8 [INFO] [stderr] 179 | && req_raw_header[rrhlen - 3] == '\n' as u8 && req_raw_header[rrhlen - 4] == '\r' as u8 { [INFO] [stderr] 180 | break; [INFO] [stderr] 181 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/server_side/mod.rs:241:4 [INFO] [stderr] | [INFO] [stderr] 241 | } [INFO] [stderr] | __________^ [INFO] [stderr] 242 | | // else if req_path.ends_with(r"\") { [INFO] [stderr] 243 | | else if req_path_isdir { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::suspicious_else_formatting)] on by default [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/server_side/response.rs:110:3 [INFO] [stderr] | [INFO] [stderr] 110 | if !self.is_ready { [INFO] [stderr] | _________^ [INFO] [stderr] 111 | | if !self.http_ver.is_empty() && self.status_code != 0 [INFO] [stderr] 112 | | && !self.status_msg.is_empty() && self.header.len() > 0 [INFO] [stderr] 113 | | && self.content_length > 0 { [INFO] [stderr] 114 | | self.is_ready = true; [INFO] [stderr] 115 | | } [INFO] [stderr] 116 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 110 | if !self.is_ready && !self.http_ver.is_empty() && self.status_code != 0 [INFO] [stderr] 111 | && !self.status_msg.is_empty() && self.header.len() > 0 [INFO] [stderr] 112 | && self.content_length > 0 { [INFO] [stderr] 113 | self.is_ready = true; [INFO] [stderr] 114 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/server_side/utils.rs:28:37 [INFO] [stderr] | [INFO] [stderr] 28 | elapsed.subsec_nanos() as f64 * 0.000001; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.000_001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/server_side/utils.rs:45:37 [INFO] [stderr] | [INFO] [stderr] 45 | elapsed.subsec_nanos() as f64 * 0.000000001; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.000_000_001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/server_side/utils.rs:57:37 [INFO] [stderr] | [INFO] [stderr] 57 | elapsed.subsec_nanos() as f64 * 0.000000001; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.000_000_001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/server_side/mod.rs:178:4 [INFO] [stderr] | [INFO] [stderr] 178 | if rrhlen > 4 { [INFO] [stderr] | _____________^ [INFO] [stderr] 179 | | if req_raw_header[rrhlen - 1] == '\n' as u8 && req_raw_header[rrhlen - 2] == '\r' as u8 [INFO] [stderr] 180 | | && req_raw_header[rrhlen - 3] == '\n' as u8 && req_raw_header[rrhlen - 4] == '\r' as u8 { [INFO] [stderr] 181 | | break; [INFO] [stderr] 182 | | } [INFO] [stderr] 183 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 178 | if rrhlen > 4 && req_raw_header[rrhlen - 1] == '\n' as u8 && req_raw_header[rrhlen - 2] == '\r' as u8 [INFO] [stderr] 179 | && req_raw_header[rrhlen - 3] == '\n' as u8 && req_raw_header[rrhlen - 4] == '\r' as u8 { [INFO] [stderr] 180 | break; [INFO] [stderr] 181 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/server_side/mod.rs:241:4 [INFO] [stderr] | [INFO] [stderr] 241 | } [INFO] [stderr] | __________^ [INFO] [stderr] 242 | | // else if req_path.ends_with(r"\") { [INFO] [stderr] 243 | | else if req_path_isdir { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::suspicious_else_formatting)] on by default [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: the variable `line_num` is used as a loop counter. Consider using `for (line_num, item) in config_bufreader.lines().enumerate()` or similar iterators [INFO] [stderr] --> src/server_side/config.rs:28:22 [INFO] [stderr] | [INFO] [stderr] 28 | for line_unwrap in config_bufreader.lines() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/server_side/config.rs:33:24 [INFO] [stderr] | [INFO] [stderr] 33 | if line.starts_with("#") || line.len() == 0 { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/server_side/config.rs:33:32 [INFO] [stderr] | [INFO] [stderr] 33 | if line.starts_with("#") || line.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/server_side/config.rs:37:42 [INFO] [stderr] | [INFO] [stderr] 37 | let mut split: Vec<&str> = line.split("=").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/server_side/mimetype.rs:46:7 [INFO] [stderr] | [INFO] [stderr] 46 | if line.len() > 0 && line.as_bytes()[0] != '#' as u8 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/server_side/mimetype.rs:46:47 [INFO] [stderr] | [INFO] [stderr] 46 | if line.len() > 0 && line.as_bytes()[0] != '#' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'#' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/server_side/mimetype.rs:71:7 [INFO] [stderr] | [INFO] [stderr] 71 | if line.len() > 0 && line.as_bytes()[0] != '#' as u8 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/server_side/mimetype.rs:71:47 [INFO] [stderr] | [INFO] [stderr] 71 | if line.len() > 0 && line.as_bytes()[0] != '#' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'#' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/server_side/mimetype.rs:82:39 [INFO] [stderr] | [INFO] [stderr] 82 | pub fn get_mimetype(&self, filename: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/server_side/mimetype.rs:84:24 [INFO] [stderr] | [INFO] [stderr] 84 | if filename.contains(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/server_side/mimetype.rs:85:38 [INFO] [stderr] | [INFO] [stderr] 85 | let filename_ext = filename.split(".").last().unwrap().to_string(); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/server_side/mimetype.rs:98:42 [INFO] [stderr] | [INFO] [stderr] 98 | pub fn get_mimetype_or(&self, filename: &String, default: &str) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/server_side/mimetype.rs:105:47 [INFO] [stderr] | [INFO] [stderr] 105 | pub fn get_mimetype_default(&self, filename: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/server_side/response.rs:112:39 [INFO] [stderr] | [INFO] [stderr] 112 | && !self.status_msg.is_empty() && self.header.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.header.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/server_side/response.rs:169:11 [INFO] [stderr] | [INFO] [stderr] 169 | if let Ok(_) = br.read_exact(&mut u8_buff[..]) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 170 | | self.bytes_read += numbytes as u64; [INFO] [stderr] 171 | | } [INFO] [stderr] | |_____________- help: try this: `if br.read_exact(&mut u8_buff[..]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/server_side/utils.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | elapsed.subsec_nanos() as f64 * 0.000001; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(elapsed.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/server_side/utils.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | elapsed.subsec_nanos() as f64 * 0.000000001; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(elapsed.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/server_side/utils.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | elapsed.subsec_nanos() as f64 * 0.000000001; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(elapsed.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/server_side/utils.rs:80:41 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn to_root_path(p: &str, root_path: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/server_side/mod.rs:211:3 [INFO] [stderr] | [INFO] [stderr] 211 | let query_string: &str; [INFO] [stderr] | _________^ [INFO] [stderr] 212 | | if req_path_split_query_string.len() > 1 { [INFO] [stderr] 213 | | // For future use. [INFO] [stderr] 214 | | query_string = req_path_split_query_string[1]; [INFO] [stderr] ... | [INFO] [stderr] 217 | | query_string = ""; [INFO] [stderr] 218 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let query_string = if req_path_split_query_string.len() > 1 { req_path_split_query_string[1] } else { "" };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/server_side/mod.rs:112:49 [INFO] [stderr] | [INFO] [stderr] 112 | let forbinden_dirs = forbinden_dirs_raw.split(";").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/server_side/mod.rs:160:9 [INFO] [stderr] | [INFO] [stderr] 160 | if req_raw_header.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `req_raw_header.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/server_side/mod.rs:179:38 [INFO] [stderr] | [INFO] [stderr] 179 | if req_raw_header[rrhlen - 1] == '\n' as u8 && req_raw_header[rrhlen - 2] == '\r' as u8 [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/server_side/mod.rs:179:82 [INFO] [stderr] | [INFO] [stderr] 179 | if req_raw_header[rrhlen - 1] == '\n' as u8 && req_raw_header[rrhlen - 2] == '\r' as u8 [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\r' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/server_side/mod.rs:180:39 [INFO] [stderr] | [INFO] [stderr] 180 | && req_raw_header[rrhlen - 3] == '\n' as u8 && req_raw_header[rrhlen - 4] == '\r' as u8 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/server_side/mod.rs:180:83 [INFO] [stderr] | [INFO] [stderr] 180 | && req_raw_header[rrhlen - 3] == '\n' as u8 && req_raw_header[rrhlen - 4] == '\r' as u8 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\r' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/server_side/mod.rs:196:3 [INFO] [stderr] | [INFO] [stderr] 196 | match req.get_header("Content-Length".to_string()) { [INFO] [stderr] | _________^ [INFO] [stderr] 197 | | Ok(ct) => { [INFO] [stderr] 198 | | let content_len: usize = ct.parse().unwrap(); [INFO] [stderr] 199 | | let mut req_raw_content: Vec = vec![0; content_len]; [INFO] [stderr] ... | [INFO] [stderr] 205 | | } [INFO] [stderr] 206 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 196 | if let Ok(ct) = req.get_header("Content-Length".to_string()) { [INFO] [stderr] 197 | let content_len: usize = ct.parse().unwrap(); [INFO] [stderr] 198 | let mut req_raw_content: Vec = vec![0; content_len]; [INFO] [stderr] 199 | client.read_exact(&mut req_raw_content); [INFO] [stderr] 200 | req.content = String::from_utf8_lossy(&req_raw_content.as_slice()).into_owned(); [INFO] [stderr] 201 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/server_side/mod.rs:209:67 [INFO] [stderr] | [INFO] [stderr] 209 | let req_path_split_query_string: Vec<&str> = req.req_path.split("?").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'?'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/server_side/mod.rs:249:73 [INFO] [stderr] | [INFO] [stderr] 249 | if !req_path.to_owned().ends_with('\\') && !req.req_path.ends_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/client_side/request.rs:61:45 [INFO] [stderr] | [INFO] [stderr] 61 | let mut line_vec: Vec<&str> = line.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/client_side/request.rs:94:36 [INFO] [stderr] | [INFO] [stderr] 94 | pub fn is_valid_http_request(req: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/client_side/request.rs:105:79 [INFO] [stderr] | [INFO] [stderr] 105 | else if !vec!["GET", "POST"].contains(&req_line[0].to_uppercase().as_str()) { [INFO] [stderr] | _____________________________________________________________________________________^ [INFO] [stderr] 106 | | // use vector to be easy to upgrade, [INFO] [stderr] 107 | | // only support for GET and POST method. [INFO] [stderr] 108 | | false [INFO] [stderr] 109 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/client_side/request.rs:102:26 [INFO] [stderr] | [INFO] [stderr] 102 | if req_line.len() != 3 { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 103 | | false [INFO] [stderr] 104 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/client_side/request.rs:105:8 [INFO] [stderr] | [INFO] [stderr] 105 | else if !vec!["GET", "POST"].contains(&req_line[0].to_uppercase().as_str()) { [INFO] [stderr] | ______________^ [INFO] [stderr] 106 | | // use vector to be easy to upgrade, [INFO] [stderr] 107 | | // only support for GET and POST method. [INFO] [stderr] 108 | | false [INFO] [stderr] ... | [INFO] [stderr] 111 | | true [INFO] [stderr] 112 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `!(!vec!["GET", "POST"].contains(&req_line[0].to_uppercase().as_str()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `aden`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: the variable `line_num` is used as a loop counter. Consider using `for (line_num, item) in config_bufreader.lines().enumerate()` or similar iterators [INFO] [stderr] --> src/server_side/config.rs:28:22 [INFO] [stderr] | [INFO] [stderr] 28 | for line_unwrap in config_bufreader.lines() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/server_side/config.rs:33:24 [INFO] [stderr] | [INFO] [stderr] 33 | if line.starts_with("#") || line.len() == 0 { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/server_side/config.rs:33:32 [INFO] [stderr] | [INFO] [stderr] 33 | if line.starts_with("#") || line.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/server_side/config.rs:37:42 [INFO] [stderr] | [INFO] [stderr] 37 | let mut split: Vec<&str> = line.split("=").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/server_side/mimetype.rs:46:7 [INFO] [stderr] | [INFO] [stderr] 46 | if line.len() > 0 && line.as_bytes()[0] != '#' as u8 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/server_side/mimetype.rs:46:47 [INFO] [stderr] | [INFO] [stderr] 46 | if line.len() > 0 && line.as_bytes()[0] != '#' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'#' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/server_side/mimetype.rs:71:7 [INFO] [stderr] | [INFO] [stderr] 71 | if line.len() > 0 && line.as_bytes()[0] != '#' as u8 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/server_side/mimetype.rs:71:47 [INFO] [stderr] | [INFO] [stderr] 71 | if line.len() > 0 && line.as_bytes()[0] != '#' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'#' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/server_side/mimetype.rs:82:39 [INFO] [stderr] | [INFO] [stderr] 82 | pub fn get_mimetype(&self, filename: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/server_side/mimetype.rs:84:24 [INFO] [stderr] | [INFO] [stderr] 84 | if filename.contains(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/server_side/mimetype.rs:85:38 [INFO] [stderr] | [INFO] [stderr] 85 | let filename_ext = filename.split(".").last().unwrap().to_string(); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/server_side/mimetype.rs:98:42 [INFO] [stderr] | [INFO] [stderr] 98 | pub fn get_mimetype_or(&self, filename: &String, default: &str) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/server_side/mimetype.rs:105:47 [INFO] [stderr] | [INFO] [stderr] 105 | pub fn get_mimetype_default(&self, filename: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/server_side/response.rs:112:39 [INFO] [stderr] | [INFO] [stderr] 112 | && !self.status_msg.is_empty() && self.header.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.header.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/server_side/response.rs:169:11 [INFO] [stderr] | [INFO] [stderr] 169 | if let Ok(_) = br.read_exact(&mut u8_buff[..]) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 170 | | self.bytes_read += numbytes as u64; [INFO] [stderr] 171 | | } [INFO] [stderr] | |_____________- help: try this: `if br.read_exact(&mut u8_buff[..]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/server_side/utils.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | elapsed.subsec_nanos() as f64 * 0.000001; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(elapsed.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/server_side/utils.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | elapsed.subsec_nanos() as f64 * 0.000000001; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(elapsed.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/server_side/utils.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | elapsed.subsec_nanos() as f64 * 0.000000001; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(elapsed.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/server_side/utils.rs:80:41 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn to_root_path(p: &str, root_path: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/server_side/mod.rs:211:3 [INFO] [stderr] | [INFO] [stderr] 211 | let query_string: &str; [INFO] [stderr] | _________^ [INFO] [stderr] 212 | | if req_path_split_query_string.len() > 1 { [INFO] [stderr] 213 | | // For future use. [INFO] [stderr] 214 | | query_string = req_path_split_query_string[1]; [INFO] [stderr] ... | [INFO] [stderr] 217 | | query_string = ""; [INFO] [stderr] 218 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let query_string = if req_path_split_query_string.len() > 1 { req_path_split_query_string[1] } else { "" };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/server_side/mod.rs:112:49 [INFO] [stderr] | [INFO] [stderr] 112 | let forbinden_dirs = forbinden_dirs_raw.split(";").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/server_side/mod.rs:160:9 [INFO] [stderr] | [INFO] [stderr] 160 | if req_raw_header.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `req_raw_header.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/server_side/mod.rs:179:38 [INFO] [stderr] | [INFO] [stderr] 179 | if req_raw_header[rrhlen - 1] == '\n' as u8 && req_raw_header[rrhlen - 2] == '\r' as u8 [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/server_side/mod.rs:179:82 [INFO] [stderr] | [INFO] [stderr] 179 | if req_raw_header[rrhlen - 1] == '\n' as u8 && req_raw_header[rrhlen - 2] == '\r' as u8 [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\r' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/server_side/mod.rs:180:39 [INFO] [stderr] | [INFO] [stderr] 180 | && req_raw_header[rrhlen - 3] == '\n' as u8 && req_raw_header[rrhlen - 4] == '\r' as u8 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/server_side/mod.rs:180:83 [INFO] [stderr] | [INFO] [stderr] 180 | && req_raw_header[rrhlen - 3] == '\n' as u8 && req_raw_header[rrhlen - 4] == '\r' as u8 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\r' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/server_side/mod.rs:196:3 [INFO] [stderr] | [INFO] [stderr] 196 | match req.get_header("Content-Length".to_string()) { [INFO] [stderr] | _________^ [INFO] [stderr] 197 | | Ok(ct) => { [INFO] [stderr] 198 | | let content_len: usize = ct.parse().unwrap(); [INFO] [stderr] 199 | | let mut req_raw_content: Vec = vec![0; content_len]; [INFO] [stderr] ... | [INFO] [stderr] 205 | | } [INFO] [stderr] 206 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 196 | if let Ok(ct) = req.get_header("Content-Length".to_string()) { [INFO] [stderr] 197 | let content_len: usize = ct.parse().unwrap(); [INFO] [stderr] 198 | let mut req_raw_content: Vec = vec![0; content_len]; [INFO] [stderr] 199 | client.read_exact(&mut req_raw_content); [INFO] [stderr] 200 | req.content = String::from_utf8_lossy(&req_raw_content.as_slice()).into_owned(); [INFO] [stderr] 201 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/server_side/mod.rs:209:67 [INFO] [stderr] | [INFO] [stderr] 209 | let req_path_split_query_string: Vec<&str> = req.req_path.split("?").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'?'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/server_side/mod.rs:249:73 [INFO] [stderr] | [INFO] [stderr] 249 | if !req_path.to_owned().ends_with('\\') && !req.req_path.ends_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/client_side/request.rs:61:45 [INFO] [stderr] | [INFO] [stderr] 61 | let mut line_vec: Vec<&str> = line.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/client_side/request.rs:94:36 [INFO] [stderr] | [INFO] [stderr] 94 | pub fn is_valid_http_request(req: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/client_side/request.rs:105:79 [INFO] [stderr] | [INFO] [stderr] 105 | else if !vec!["GET", "POST"].contains(&req_line[0].to_uppercase().as_str()) { [INFO] [stderr] | _____________________________________________________________________________________^ [INFO] [stderr] 106 | | // use vector to be easy to upgrade, [INFO] [stderr] 107 | | // only support for GET and POST method. [INFO] [stderr] 108 | | false [INFO] [stderr] 109 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/client_side/request.rs:102:26 [INFO] [stderr] | [INFO] [stderr] 102 | if req_line.len() != 3 { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 103 | | false [INFO] [stderr] 104 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/client_side/request.rs:105:8 [INFO] [stderr] | [INFO] [stderr] 105 | else if !vec!["GET", "POST"].contains(&req_line[0].to_uppercase().as_str()) { [INFO] [stderr] | ______________^ [INFO] [stderr] 106 | | // use vector to be easy to upgrade, [INFO] [stderr] 107 | | // only support for GET and POST method. [INFO] [stderr] 108 | | false [INFO] [stderr] ... | [INFO] [stderr] 111 | | true [INFO] [stderr] 112 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `!(!vec!["GET", "POST"].contains(&req_line[0].to_uppercase().as_str()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `aden`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "3bd0fbfbb54885b9a1543b31cc080b044a02dec7b016fa1c27c9bd926b0f6e3a"` [INFO] running `"docker" "rm" "-f" "3bd0fbfbb54885b9a1543b31cc080b044a02dec7b016fa1c27c9bd926b0f6e3a"` [INFO] [stdout] 3bd0fbfbb54885b9a1543b31cc080b044a02dec7b016fa1c27c9bd926b0f6e3a