[INFO] updating cached repository nickbnf/plic [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nickbnf/plic [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nickbnf/plic" "work/ex/clippy-test-run/sources/stable/gh/nickbnf/plic"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nickbnf/plic'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nickbnf/plic" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nickbnf/plic"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nickbnf/plic'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 590ac8a7f2b3cddd6c01709c6ddef92e7b851c0a [INFO] sha for GitHub repo nickbnf/plic: 590ac8a7f2b3cddd6c01709c6ddef92e7b851c0a [INFO] validating manifest of nickbnf/plic on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nickbnf/plic on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nickbnf/plic [INFO] finished frobbing nickbnf/plic [INFO] frobbed toml for nickbnf/plic written to work/ex/clippy-test-run/sources/stable/gh/nickbnf/plic/Cargo.toml [INFO] started frobbing nickbnf/plic [INFO] finished frobbing nickbnf/plic [INFO] frobbed toml for nickbnf/plic written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nickbnf/plic/Cargo.toml [INFO] crate nickbnf/plic has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nickbnf/plic against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nickbnf/plic:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8bc90120cf9e042d1b8c1a806d70e1cdd20c07eaec69343f564b3fcf017743b7 [INFO] running `"docker" "start" "-a" "8bc90120cf9e042d1b8c1a806d70e1cdd20c07eaec69343f564b3fcf017743b7"` [INFO] [stderr] Checking nix v0.5.1 [INFO] [stderr] Checking clap v2.13.0 [INFO] [stderr] Checking rustyline v1.0.0 [INFO] [stderr] Checking plic v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/eval/mod.rs:33:14 [INFO] [stderr] | [INFO] [stderr] 33 | &PlicType::Operation { function: _ } => write!(f, "Built-in operation"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Operation { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/main.rs:43:31 [INFO] [stderr] | [INFO] [stderr] 43 | Err(_) => return(), [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] extern crate matches; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/eval/mod.rs:33:14 [INFO] [stderr] | [INFO] [stderr] 33 | &PlicType::Operation { function: _ } => write!(f, "Built-in operation"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Operation { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/main.rs:43:31 [INFO] [stderr] | [INFO] [stderr] 43 | Err(_) => return(), [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: value assigned to `s` is never read [INFO] [stderr] --> src/eval/builtins.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | let mut s = 0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `file` [INFO] [stderr] --> src/main.rs:29:23 [INFO] [stderr] | [INFO] [stderr] 29 | else if let Some( file ) = matches.value_of("INPUT") { [INFO] [stderr] | ^^^^ help: consider using `_file` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/eval/mod.rs:95:24 [INFO] [stderr] | [INFO] [stderr] 95 | fn copy_expression( mut tokens: &mut T, copy: String ) -> Result [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/eval/mod.rs:124:28 [INFO] [stderr] | [INFO] [stderr] 124 | fn evaluate_expression( mut tokens: &mut T, env: &mut Environment ) -> Result [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: value assigned to `s` is never read [INFO] [stderr] --> src/eval/builtins.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | let mut s = 0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `file` [INFO] [stderr] --> src/main.rs:29:23 [INFO] [stderr] | [INFO] [stderr] 29 | else if let Some( file ) = matches.value_of("INPUT") { [INFO] [stderr] | ^^^^ help: consider using `_file` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Pair` [INFO] [stderr] --> src/eval/mod.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | Pair(HeapIndex, HeapIndex), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `env` [INFO] [stderr] --> src/eval/mod.rs:269:17 [INFO] [stderr] | [INFO] [stderr] 269 | let mut env = super::Environment::new(); [INFO] [stderr] | ^^^ help: consider using `_env` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `env` [INFO] [stderr] --> src/eval/mod.rs:286:17 [INFO] [stderr] | [INFO] [stderr] 286 | let mut env = super::Environment::new(); [INFO] [stderr] | ^^^ help: consider using `_env` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `env` [INFO] [stderr] --> src/eval/mod.rs:306:17 [INFO] [stderr] | [INFO] [stderr] 306 | let mut env = super::Environment::new(); [INFO] [stderr] | ^^^ help: consider using `_env` instead [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lexer.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | / pub fn tokens<'a>( code: &'a str ) -> CodeTokens<'a> { [INFO] [stderr] 6 | | CodeTokens { iter: code.chars().peekable() } [INFO] [stderr] 7 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/eval/builtins.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | s = s + n; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `s += n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/eval/builtins.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | s = s - n; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `s -= n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval/mod.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | / match self { [INFO] [stderr] 32 | | &PlicType::Integer( n ) => write!(f, "{}", n), [INFO] [stderr] 33 | | &PlicType::Operation { function: _ } => write!(f, "Built-in operation"), [INFO] [stderr] 34 | | &PlicType::Symbol( ref s ) => write!(f, "'{}", s), [INFO] [stderr] 35 | | &PlicType::Lambda{ ref bound_var, ref expression } => write!(f, "{} => {}", bound_var, expression), [INFO] [stderr] 36 | | _ => write!(f, "Unknown") [INFO] [stderr] 37 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 31 | match *self { [INFO] [stderr] 32 | PlicType::Integer( n ) => write!(f, "{}", n), [INFO] [stderr] 33 | PlicType::Operation { function: _ } => write!(f, "Built-in operation"), [INFO] [stderr] 34 | PlicType::Symbol( ref s ) => write!(f, "'{}", s), [INFO] [stderr] 35 | PlicType::Lambda{ ref bound_var, ref expression } => write!(f, "{} => {}", bound_var, expression), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval/mod.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | / match self { [INFO] [stderr] 54 | | &EvalError::NonApplicable => write!(f, "Operation not applicable"), [INFO] [stderr] 55 | | &EvalError::Other => write!(f, "Error"), [INFO] [stderr] 56 | | _ => write!(f, "Unknown") [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 53 | match *self { [INFO] [stderr] 54 | EvalError::NonApplicable => write!(f, "Operation not applicable"), [INFO] [stderr] 55 | EvalError::Other => write!(f, "Error"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/eval/mod.rs:101:39 [INFO] [stderr] | [INFO] [stderr] 101 | lexer::Token::Plus => Ok( copy + &"+ " ), [INFO] [stderr] | ^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `"+ "` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/eval/mod.rs:102:40 [INFO] [stderr] | [INFO] [stderr] 102 | lexer::Token::Minus => Ok( copy + &"- " ), [INFO] [stderr] | ^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `"- "` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/eval/mod.rs:103:41 [INFO] [stderr] | [INFO] [stderr] 103 | lexer::Token::Lambda => Ok( copy + &"λ " ), [INFO] [stderr] | ^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `"λ "` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/eval/mod.rs:111:17 [INFO] [stderr] | [INFO] [stderr] 111 | string = string + ") "; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `string += ") "` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/eval/mod.rs:95:24 [INFO] [stderr] | [INFO] [stderr] 95 | fn copy_expression( mut tokens: &mut T, copy: String ) -> Result [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/eval/mod.rs:124:28 [INFO] [stderr] | [INFO] [stderr] 124 | fn evaluate_expression( mut tokens: &mut T, env: &mut Environment ) -> Result [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/eval/mod.rs:269:13 [INFO] [stderr] | [INFO] [stderr] 269 | let mut env = super::Environment::new(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/eval/mod.rs:286:13 [INFO] [stderr] | [INFO] [stderr] 286 | let mut env = super::Environment::new(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/eval/mod.rs:306:13 [INFO] [stderr] | [INFO] [stderr] 306 | let mut env = super::Environment::new(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Pair` [INFO] [stderr] --> src/eval/mod.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | Pair(HeapIndex, HeapIndex), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lexer.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | / pub fn tokens<'a>( code: &'a str ) -> CodeTokens<'a> { [INFO] [stderr] 6 | | CodeTokens { iter: code.chars().peekable() } [INFO] [stderr] 7 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/eval/builtins.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | s = s + n; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `s += n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/eval/builtins.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | s = s - n; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `s -= n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval/mod.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | / match self { [INFO] [stderr] 32 | | &PlicType::Integer( n ) => write!(f, "{}", n), [INFO] [stderr] 33 | | &PlicType::Operation { function: _ } => write!(f, "Built-in operation"), [INFO] [stderr] 34 | | &PlicType::Symbol( ref s ) => write!(f, "'{}", s), [INFO] [stderr] 35 | | &PlicType::Lambda{ ref bound_var, ref expression } => write!(f, "{} => {}", bound_var, expression), [INFO] [stderr] 36 | | _ => write!(f, "Unknown") [INFO] [stderr] 37 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 31 | match *self { [INFO] [stderr] 32 | PlicType::Integer( n ) => write!(f, "{}", n), [INFO] [stderr] 33 | PlicType::Operation { function: _ } => write!(f, "Built-in operation"), [INFO] [stderr] 34 | PlicType::Symbol( ref s ) => write!(f, "'{}", s), [INFO] [stderr] 35 | PlicType::Lambda{ ref bound_var, ref expression } => write!(f, "{} => {}", bound_var, expression), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/eval/mod.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | / match self { [INFO] [stderr] 54 | | &EvalError::NonApplicable => write!(f, "Operation not applicable"), [INFO] [stderr] 55 | | &EvalError::Other => write!(f, "Error"), [INFO] [stderr] 56 | | _ => write!(f, "Unknown") [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 53 | match *self { [INFO] [stderr] 54 | EvalError::NonApplicable => write!(f, "Operation not applicable"), [INFO] [stderr] 55 | EvalError::Other => write!(f, "Error"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/eval/mod.rs:101:39 [INFO] [stderr] | [INFO] [stderr] 101 | lexer::Token::Plus => Ok( copy + &"+ " ), [INFO] [stderr] | ^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `"+ "` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/eval/mod.rs:102:40 [INFO] [stderr] | [INFO] [stderr] 102 | lexer::Token::Minus => Ok( copy + &"- " ), [INFO] [stderr] | ^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `"- "` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/eval/mod.rs:103:41 [INFO] [stderr] | [INFO] [stderr] 103 | lexer::Token::Lambda => Ok( copy + &"λ " ), [INFO] [stderr] | ^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `"λ "` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/eval/mod.rs:111:17 [INFO] [stderr] | [INFO] [stderr] 111 | string = string + ") "; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `string += ") "` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.09s [INFO] running `"docker" "inspect" "8bc90120cf9e042d1b8c1a806d70e1cdd20c07eaec69343f564b3fcf017743b7"` [INFO] running `"docker" "rm" "-f" "8bc90120cf9e042d1b8c1a806d70e1cdd20c07eaec69343f564b3fcf017743b7"` [INFO] [stdout] 8bc90120cf9e042d1b8c1a806d70e1cdd20c07eaec69343f564b3fcf017743b7