[INFO] updating cached repository nginth/rusterver [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nginth/rusterver [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nginth/rusterver" "work/ex/clippy-test-run/sources/stable/gh/nginth/rusterver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nginth/rusterver'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nginth/rusterver" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nginth/rusterver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nginth/rusterver'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c2390309c5ab757005bb37eba9e085e79b45bb8b [INFO] sha for GitHub repo nginth/rusterver: c2390309c5ab757005bb37eba9e085e79b45bb8b [INFO] validating manifest of nginth/rusterver on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nginth/rusterver on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nginth/rusterver [INFO] finished frobbing nginth/rusterver [INFO] frobbed toml for nginth/rusterver written to work/ex/clippy-test-run/sources/stable/gh/nginth/rusterver/Cargo.toml [INFO] started frobbing nginth/rusterver [INFO] finished frobbing nginth/rusterver [INFO] frobbed toml for nginth/rusterver written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nginth/rusterver/Cargo.toml [INFO] crate nginth/rusterver has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nginth/rusterver against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nginth/rusterver:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4d9cca455f78171265cdecd3166e78a951c9653ae9d45e362d886b426dc4fb93 [INFO] running `"docker" "start" "-a" "4d9cca455f78171265cdecd3166e78a951c9653ae9d45e362d886b426dc4fb93"` [INFO] [stderr] Checking rusterver v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/response.rs:22:17 [INFO] [stderr] | [INFO] [stderr] 22 | code: code, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/response.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | reason: reason, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reason` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::str` [INFO] [stderr] --> src/main.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::str; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Error` [INFO] [stderr] --> src/http/request.rs:2:33 [INFO] [stderr] | [INFO] [stderr] 2 | use std::io::{Lines, BufReader, Error}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::str::SplitWhitespace` [INFO] [stderr] --> src/http/request.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::str::SplitWhitespace; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/http/response.rs:57:22 [INFO] [stderr] | [INFO] [stderr] 57 | const CRLF: &'static [u8; 2] = b"\r\n"; [INFO] [stderr] | -^^^^^^^-------- help: consider removing `'static`: `&[u8; 2]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/response.rs:22:17 [INFO] [stderr] | [INFO] [stderr] 22 | code: code, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/response.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | reason: reason, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reason` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused variable: `request_string` [INFO] [stderr] --> src/main.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | let mut request_string = String::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using `_request_string` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | let mut reader = BufReader::new(stream); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | let mut request_string = String::new(); [INFO] [stderr] | ----^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/http/response.rs:48:48 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn get_byte_response<'b>(&'b mut self, mut byte_vector: &'b mut Vec) -> &[u8] { [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/http/response.rs:55:45 [INFO] [stderr] | [INFO] [stderr] 55 | fn construct_response<'b>(&'b mut self, mut byte_vector: &'b mut Vec) { [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_reason` [INFO] [stderr] --> src/http/response.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn get_reason(&self) -> &'a str { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_code` [INFO] [stderr] --> src/http/response.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn get_code(&self) -> &'a str { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_version` [INFO] [stderr] --> src/http/response.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn get_version(&self) -> &'a str { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/http/request.rs:47:34 [INFO] [stderr] | [INFO] [stderr] 47 | request.headers.push(String::from(s)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | writer.write(byte_response).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rusterver`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused import: `std::str` [INFO] [stderr] --> src/main.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::str; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Error` [INFO] [stderr] --> src/http/request.rs:2:33 [INFO] [stderr] | [INFO] [stderr] 2 | use std::io::{Lines, BufReader, Error}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::str::SplitWhitespace` [INFO] [stderr] --> src/http/request.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::str::SplitWhitespace; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/http/response.rs:57:22 [INFO] [stderr] | [INFO] [stderr] 57 | const CRLF: &'static [u8; 2] = b"\r\n"; [INFO] [stderr] | -^^^^^^^-------- help: consider removing `'static`: `&[u8; 2]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused variable: `request_string` [INFO] [stderr] --> src/main.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | let mut request_string = String::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using `_request_string` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | let mut reader = BufReader::new(stream); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | let mut request_string = String::new(); [INFO] [stderr] | ----^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/http/response.rs:48:48 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn get_byte_response<'b>(&'b mut self, mut byte_vector: &'b mut Vec) -> &[u8] { [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/http/response.rs:55:45 [INFO] [stderr] | [INFO] [stderr] 55 | fn construct_response<'b>(&'b mut self, mut byte_vector: &'b mut Vec) { [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_reason` [INFO] [stderr] --> src/http/response.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn get_reason(&self) -> &'a str { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_code` [INFO] [stderr] --> src/http/response.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn get_code(&self) -> &'a str { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_version` [INFO] [stderr] --> src/http/response.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn get_version(&self) -> &'a str { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/http/request.rs:47:34 [INFO] [stderr] | [INFO] [stderr] 47 | request.headers.push(String::from(s)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | writer.write(byte_response).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rusterver`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4d9cca455f78171265cdecd3166e78a951c9653ae9d45e362d886b426dc4fb93"` [INFO] running `"docker" "rm" "-f" "4d9cca455f78171265cdecd3166e78a951c9653ae9d45e362d886b426dc4fb93"` [INFO] [stdout] 4d9cca455f78171265cdecd3166e78a951c9653ae9d45e362d886b426dc4fb93