[INFO] updating cached repository nextialab/Tepostli
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/nextialab/Tepostli
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/nextialab/Tepostli" "work/ex/clippy-test-run/sources/stable/gh/nextialab/Tepostli"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nextialab/Tepostli'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/nextialab/Tepostli" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nextialab/Tepostli"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nextialab/Tepostli'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 37d9d62c63df19d638f72fc38e6111611663b168
[INFO] sha for GitHub repo nextialab/Tepostli: 37d9d62c63df19d638f72fc38e6111611663b168
[INFO] validating manifest of nextialab/Tepostli on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of nextialab/Tepostli on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing nextialab/Tepostli
[INFO] finished frobbing nextialab/Tepostli
[INFO] frobbed toml for nextialab/Tepostli written to work/ex/clippy-test-run/sources/stable/gh/nextialab/Tepostli/Cargo.toml
[INFO] started frobbing nextialab/Tepostli
[INFO] finished frobbing nextialab/Tepostli
[INFO] frobbed toml for nextialab/Tepostli written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nextialab/Tepostli/Cargo.toml
[INFO] crate nextialab/Tepostli has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting nextialab/Tepostli against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nextialab/Tepostli:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 3be2a4e9a7eef894f4ed295cb75b382dac21e0b8e7408fafbde5730295bdb183
[INFO] running `"docker" "start" "-a" "3be2a4e9a7eef894f4ed295cb75b382dac21e0b8e7408fafbde5730295bdb183"`
[INFO] [stderr]     Checking tepostli v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/sparser.rs:53:5
[INFO] [stderr]    |
[INFO] [stderr] 53 |     return (Token::End, from);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(Token::End, from)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/sparser.rs:80:5
[INFO] [stderr]    |
[INFO] [stderr] 80 |     return (slist, chars);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(slist, chars)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/sparser.rs:100:5
[INFO] [stderr]     |
[INFO] [stderr] 100 |     return None;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/sparser.rs:107:5
[INFO] [stderr]     |
[INFO] [stderr] 107 |     return slist;
[INFO] [stderr]     |     ^^^^^^^^^^^^^ help: remove `return` as shown: `slist`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:16:6
[INFO] [stderr]    |
[INFO] [stderr] 16 |                     return (message.to_string(), addr.port());
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(message.to_string(), addr.port())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:18:15
[INFO] [stderr]    |
[INFO] [stderr] 18 |                 Err(_) => return ("(error could_not_read)".to_string(), addr.port())
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `("(error could_not_read)".to_string(), addr.port())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:21:13
[INFO] [stderr]    |
[INFO] [stderr] 21 |         Err(_) => return ("(error could_not_read)".to_string(), 0)
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `("(error could_not_read)".to_string(), 0)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:33:21
[INFO] [stderr]    |
[INFO] [stderr] 33 |                             Ok(value) => return value,
[INFO] [stderr]    |                                          ^^^^^^^^^^^^ help: remove `return` as shown: `value`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:34:18
[INFO] [stderr]    |
[INFO] [stderr] 34 |                             Err(_) => return default
[INFO] [stderr]    |                                       ^^^^^^^^^^^^^^ help: remove `return` as shown: `default`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:37:11
[INFO] [stderr]    |
[INFO] [stderr] 37 |                     _ => return default
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^ help: remove `return` as shown: `default`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:40:5
[INFO] [stderr]    |
[INFO] [stderr] 40 |                 return default
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^ help: remove `return` as shown: `default`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:43:11
[INFO] [stderr]    |
[INFO] [stderr] 43 |         None => return default
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^ help: remove `return` as shown: `default`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/sparser.rs:53:5
[INFO] [stderr]    |
[INFO] [stderr] 53 |     return (Token::End, from);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(Token::End, from)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/sparser.rs:80:5
[INFO] [stderr]    |
[INFO] [stderr] 80 |     return (slist, chars);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(slist, chars)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/sparser.rs:100:5
[INFO] [stderr]     |
[INFO] [stderr] 100 |     return None;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/sparser.rs:107:5
[INFO] [stderr]     |
[INFO] [stderr] 107 |     return slist;
[INFO] [stderr]     |     ^^^^^^^^^^^^^ help: remove `return` as shown: `slist`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:16:6
[INFO] [stderr]    |
[INFO] [stderr] 16 |                     return (message.to_string(), addr.port());
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(message.to_string(), addr.port())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:18:15
[INFO] [stderr]    |
[INFO] [stderr] 18 |                 Err(_) => return ("(error could_not_read)".to_string(), addr.port())
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `("(error could_not_read)".to_string(), addr.port())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:21:13
[INFO] [stderr]    |
[INFO] [stderr] 21 |         Err(_) => return ("(error could_not_read)".to_string(), 0)
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `("(error could_not_read)".to_string(), 0)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:33:21
[INFO] [stderr]    |
[INFO] [stderr] 33 |                             Ok(value) => return value,
[INFO] [stderr]    |                                          ^^^^^^^^^^^^ help: remove `return` as shown: `value`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:34:18
[INFO] [stderr]    |
[INFO] [stderr] 34 |                             Err(_) => return default
[INFO] [stderr]    |                                       ^^^^^^^^^^^^^^ help: remove `return` as shown: `default`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:37:11
[INFO] [stderr]    |
[INFO] [stderr] 37 |                     _ => return default
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^ help: remove `return` as shown: `default`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:40:5
[INFO] [stderr]    |
[INFO] [stderr] 40 |                 return default
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^ help: remove `return` as shown: `default`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:43:11
[INFO] [stderr]    |
[INFO] [stderr] 43 |         None => return default
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^ help: remove `return` as shown: `default`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: variable `port` is assigned to, but never used
[INFO] [stderr]   --> src/main.rs:49:9
[INFO] [stderr]    |
[INFO] [stderr] 49 |     let port: u16;
[INFO] [stderr]    |         ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr]    = note: consider using `_port` instead
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `port` is never read
[INFO] [stderr]   --> src/main.rs:55:9
[INFO] [stderr]    |
[INFO] [stderr] 55 |                     port = next_port;
[INFO] [stderr]    |                     ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_assignments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]   --> src/sparser.rs:18:25
[INFO] [stderr]    |
[INFO] [stderr] 18 |     while let Some(p) = local.next() {
[INFO] [stderr]    |                         ^^^^^^^^^^^^ help: try: `for p in local { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/sparser.rs:44:20
[INFO] [stderr]    |
[INFO] [stderr] 44 |                 if token.len() > 0 {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!token.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/sparser.rs:83:28
[INFO] [stderr]    |
[INFO] [stderr] 83 | pub fn find_list<'a>(list: &'a Vec<SList>, name: String) -> Option<&'a Vec<SList>> {
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^ help: change this to: `&[SList]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/sparser.rs:86:9
[INFO] [stderr]    |
[INFO] [stderr] 86 | /         match item {
[INFO] [stderr] 87 | |             &SList::List(ref slist) => {
[INFO] [stderr] 88 | |                 let result = find_list(slist, copy_name);
[INFO] [stderr] 89 | |                 match result {
[INFO] [stderr] ...  |
[INFO] [stderr] 97 | |             &SList::Atom(_) => continue
[INFO] [stderr] 98 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 86 |         match *item {
[INFO] [stderr] 87 |             SList::List(ref slist) => {
[INFO] [stderr] 88 |                 let result = find_list(slist, copy_name);
[INFO] [stderr] 89 |                 match result {
[INFO] [stderr] 90 |                     Some(_) => return result,
[INFO] [stderr] 91 |                     None => continue
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:25:28
[INFO] [stderr]    |
[INFO] [stderr] 25 | fn get_player_types(slist: &Vec<sparser::SList>, default: u16) -> u16 {
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[sparser::SList]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: variable `port` is assigned to, but never used
[INFO] [stderr]   --> src/main.rs:49:9
[INFO] [stderr]    |
[INFO] [stderr] 49 |     let port: u16;
[INFO] [stderr]    |         ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr]    = note: consider using `_port` instead
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `port` is never read
[INFO] [stderr]   --> src/main.rs:55:9
[INFO] [stderr]    |
[INFO] [stderr] 55 |                     port = next_port;
[INFO] [stderr]    |                     ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_assignments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> src/main.rs:52:28
[INFO] [stderr]    |
[INFO] [stderr] 52 |             match socket.send_to("(init Ocelotl (version 15.1))".as_bytes(), "127.0.0.1:6000") {
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"(init Ocelotl (version 15.1))"`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:65:10
[INFO] [stderr]    |
[INFO] [stderr] 65 |                         i = i + 1;
[INFO] [stderr]    |                         ^^^^^^^^^ help: replace it with: `i += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:84:11
[INFO] [stderr]    |
[INFO] [stderr] 84 |                 if slist.len() > 0 {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!slist.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:86:9
[INFO] [stderr]     |
[INFO] [stderr] 86  |                       match head {
[INFO] [stderr]     |  _____________________^
[INFO] [stderr] 87  | |                         &sparser::SList::Atom(ref string) if *string == "sense_body".to_string() => {
[INFO] [stderr] 88  | |                             loop {
[INFO] [stderr] 89  | |                                 match rx.recv_timeout(Duration::from_millis(10)) {
[INFO] [stderr] ...   |
[INFO] [stderr] 100 | |                         _ => continue
[INFO] [stderr] 101 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 86  |                     match *head {
[INFO] [stderr] 87  |                         sparser::SList::Atom(ref string) if *string == "sense_body".to_string() => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> src/main.rs:87:47
[INFO] [stderr]    |
[INFO] [stderr] 87 |                         &sparser::SList::Atom(ref string) if *string == "sense_body".to_string() => {
[INFO] [stderr]    |                                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ try implementing the comparison without allocating
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cmp_owned)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:98:11
[INFO] [stderr]    |
[INFO] [stderr] 98 |                             simulation_time = simulation_time + 1;
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `simulation_time += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]   --> src/sparser.rs:18:25
[INFO] [stderr]    |
[INFO] [stderr] 18 |     while let Some(p) = local.next() {
[INFO] [stderr]    |                         ^^^^^^^^^^^^ help: try: `for p in local { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/sparser.rs:44:20
[INFO] [stderr]    |
[INFO] [stderr] 44 |                 if token.len() > 0 {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!token.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/sparser.rs:83:28
[INFO] [stderr]    |
[INFO] [stderr] 83 | pub fn find_list<'a>(list: &'a Vec<SList>, name: String) -> Option<&'a Vec<SList>> {
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^ help: change this to: `&[SList]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/sparser.rs:86:9
[INFO] [stderr]    |
[INFO] [stderr] 86 | /         match item {
[INFO] [stderr] 87 | |             &SList::List(ref slist) => {
[INFO] [stderr] 88 | |                 let result = find_list(slist, copy_name);
[INFO] [stderr] 89 | |                 match result {
[INFO] [stderr] ...  |
[INFO] [stderr] 97 | |             &SList::Atom(_) => continue
[INFO] [stderr] 98 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 86 |         match *item {
[INFO] [stderr] 87 |             SList::List(ref slist) => {
[INFO] [stderr] 88 |                 let result = find_list(slist, copy_name);
[INFO] [stderr] 89 |                 match result {
[INFO] [stderr] 90 |                     Some(_) => return result,
[INFO] [stderr] 91 |                     None => continue
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:25:28
[INFO] [stderr]    |
[INFO] [stderr] 25 | fn get_player_types(slist: &Vec<sparser::SList>, default: u16) -> u16 {
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[sparser::SList]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> src/main.rs:52:28
[INFO] [stderr]    |
[INFO] [stderr] 52 |             match socket.send_to("(init Ocelotl (version 15.1))".as_bytes(), "127.0.0.1:6000") {
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"(init Ocelotl (version 15.1))"`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:65:10
[INFO] [stderr]    |
[INFO] [stderr] 65 |                         i = i + 1;
[INFO] [stderr]    |                         ^^^^^^^^^ help: replace it with: `i += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:84:11
[INFO] [stderr]    |
[INFO] [stderr] 84 |                 if slist.len() > 0 {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!slist.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:86:9
[INFO] [stderr]     |
[INFO] [stderr] 86  |                       match head {
[INFO] [stderr]     |  _____________________^
[INFO] [stderr] 87  | |                         &sparser::SList::Atom(ref string) if *string == "sense_body".to_string() => {
[INFO] [stderr] 88  | |                             loop {
[INFO] [stderr] 89  | |                                 match rx.recv_timeout(Duration::from_millis(10)) {
[INFO] [stderr] ...   |
[INFO] [stderr] 100 | |                         _ => continue
[INFO] [stderr] 101 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 86  |                     match *head {
[INFO] [stderr] 87  |                         sparser::SList::Atom(ref string) if *string == "sense_body".to_string() => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> src/main.rs:87:47
[INFO] [stderr]    |
[INFO] [stderr] 87 |                         &sparser::SList::Atom(ref string) if *string == "sense_body".to_string() => {
[INFO] [stderr]    |                                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ try implementing the comparison without allocating
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cmp_owned)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:98:11
[INFO] [stderr]    |
[INFO] [stderr] 98 |                             simulation_time = simulation_time + 1;
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `simulation_time += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.74s
[INFO] running `"docker" "inspect" "3be2a4e9a7eef894f4ed295cb75b382dac21e0b8e7408fafbde5730295bdb183"`
[INFO] running `"docker" "rm" "-f" "3be2a4e9a7eef894f4ed295cb75b382dac21e0b8e7408fafbde5730295bdb183"`
[INFO] [stdout] 3be2a4e9a7eef894f4ed295cb75b382dac21e0b8e7408fafbde5730295bdb183