[INFO] updating cached repository neosmart/tcpproxy [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/neosmart/tcpproxy [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/neosmart/tcpproxy" "work/ex/clippy-test-run/sources/stable/gh/neosmart/tcpproxy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/neosmart/tcpproxy'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/neosmart/tcpproxy" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/neosmart/tcpproxy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/neosmart/tcpproxy'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f14dc522f7327d5594ba183c6f6f4333cc06e992 [INFO] sha for GitHub repo neosmart/tcpproxy: f14dc522f7327d5594ba183c6f6f4333cc06e992 [INFO] validating manifest of neosmart/tcpproxy on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of neosmart/tcpproxy on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing neosmart/tcpproxy [INFO] finished frobbing neosmart/tcpproxy [INFO] frobbed toml for neosmart/tcpproxy written to work/ex/clippy-test-run/sources/stable/gh/neosmart/tcpproxy/Cargo.toml [INFO] started frobbing neosmart/tcpproxy [INFO] finished frobbing neosmart/tcpproxy [INFO] frobbed toml for neosmart/tcpproxy written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/neosmart/tcpproxy/Cargo.toml [INFO] crate neosmart/tcpproxy has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting neosmart/tcpproxy against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/neosmart/tcpproxy:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fe52b83874546564901e6ce4e526b870f7a4ca619259118e381748d589050e3d [INFO] running `"docker" "start" "-a" "fe52b83874546564901e6ce4e526b870f7a4ca619259118e381748d589050e3d"` [INFO] [stderr] Checking net2 v0.2.31 [INFO] [stderr] Checking bytes v0.4.5 [INFO] [stderr] Checking abstract-ns v0.3.4 [INFO] [stderr] Checking mio v0.6.10 [INFO] [stderr] Checking tokio-io v0.1.2 [INFO] [stderr] Checking tokio-core v0.1.9 [INFO] [stderr] Checking domain v0.2.1 [INFO] [stderr] Checking ns-dns-tokio v0.3.1 [INFO] [stderr] Checking tcpproxy v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/main.rs:139:29 [INFO] [stderr] | [INFO] [stderr] 139 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/main.rs:139:29 [INFO] [stderr] | [INFO] [stderr] 139 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:92:10 [INFO] [stderr] | [INFO] [stderr] 92 | .expect(&format!("Unable to bind to {}", &bind_addr)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to bind to {}", &bind_addr))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:107:26 [INFO] [stderr] | [INFO] [stderr] 107 | .expect(&format!("No valid IP addresses for target {}", remote_host)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("No valid IP addresses for target {}", remote_host))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:92:10 [INFO] [stderr] | [INFO] [stderr] 92 | .expect(&format!("Unable to bind to {}", &bind_addr)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to bind to {}", &bind_addr))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:117:31 [INFO] [stderr] | [INFO] [stderr] 117 | let remote_addr = remote_addr.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `remote_addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:142:49 [INFO] [stderr] | [INFO] [stderr] 142 | let client_addr_clone = client_addr.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `client_addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:107:26 [INFO] [stderr] | [INFO] [stderr] 107 | .expect(&format!("No valid IP addresses for target {}", remote_host)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("No valid IP addresses for target {}", remote_host))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:117:31 [INFO] [stderr] | [INFO] [stderr] 117 | let remote_addr = remote_addr.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `remote_addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:142:49 [INFO] [stderr] | [INFO] [stderr] 142 | let client_addr_clone = client_addr.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `client_addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.78s [INFO] running `"docker" "inspect" "fe52b83874546564901e6ce4e526b870f7a4ca619259118e381748d589050e3d"` [INFO] running `"docker" "rm" "-f" "fe52b83874546564901e6ce4e526b870f7a4ca619259118e381748d589050e3d"` [INFO] [stdout] fe52b83874546564901e6ce4e526b870f7a4ca619259118e381748d589050e3d