[INFO] updating cached repository neosmart/srtresync [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/neosmart/srtresync [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/neosmart/srtresync" "work/ex/clippy-test-run/sources/stable/gh/neosmart/srtresync"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/neosmart/srtresync'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/neosmart/srtresync" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/neosmart/srtresync"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/neosmart/srtresync'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f84a370e06f249bbc51b8f08079c2e111764ae91 [INFO] sha for GitHub repo neosmart/srtresync: f84a370e06f249bbc51b8f08079c2e111764ae91 [INFO] validating manifest of neosmart/srtresync on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of neosmart/srtresync on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing neosmart/srtresync [INFO] finished frobbing neosmart/srtresync [INFO] frobbed toml for neosmart/srtresync written to work/ex/clippy-test-run/sources/stable/gh/neosmart/srtresync/Cargo.toml [INFO] started frobbing neosmart/srtresync [INFO] finished frobbing neosmart/srtresync [INFO] frobbed toml for neosmart/srtresync written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/neosmart/srtresync/Cargo.toml [INFO] crate neosmart/srtresync has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting neosmart/srtresync against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/neosmart/srtresync:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 63a5abf2a1bdd9163025620da20db272efa8df98281aea78e415285bf2300c3e [INFO] running `"docker" "start" "-a" "63a5abf2a1bdd9163025620da20db272efa8df98281aea78e415285bf2300c3e"` [INFO] [stderr] Checking srtresync v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused imports: `Add`, `Sub` [INFO] [stderr] --> src/main.rs:8:16 [INFO] [stderr] | [INFO] [stderr] 8 | use std::ops::{Add, Sub}; [INFO] [stderr] | ^^^ ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Add`, `Sub` [INFO] [stderr] --> src/main.rs:8:16 [INFO] [stderr] | [INFO] [stderr] 8 | use std::ops::{Add, Sub}; [INFO] [stderr] | ^^^ ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from` [INFO] [stderr] --> src/main.rs:88:2 [INFO] [stderr] | [INFO] [stderr] 88 | fn from(hours: i32, mins: i32, secs: i32, msecs: i32) -> Timestamp { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:33:6 [INFO] [stderr] | [INFO] [stderr] 33 | if text.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `text.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | 0 => new_ms = new_ms + 1000 * match chunk2.parse::() { [INFO] [stderr] | __________________________________^ [INFO] [stderr] 58 | | Ok(value) => value, [INFO] [stderr] 59 | | _ => return None [INFO] [stderr] 60 | | }, [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 57 | 0 => new_ms += 1000 * match chunk2.parse::() { [INFO] [stderr] 58 | Ok(value) => value, [INFO] [stderr] 59 | _ => return None [INFO] [stderr] 60 | }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | 1 => new_ms = new_ms + match chunk2.parse::() { [INFO] [stderr] | __________________________________^ [INFO] [stderr] 62 | | Ok(value) => value, [INFO] [stderr] 63 | | _ => return None [INFO] [stderr] 64 | | }, [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 61 | 1 => new_ms += match chunk2.parse::() { [INFO] [stderr] 62 | Ok(value) => value, [INFO] [stderr] 63 | _ => return None [INFO] [stderr] 64 | }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:67:7 [INFO] [stderr] | [INFO] [stderr] 67 | j = j + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `j += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:70:10 [INFO] [stderr] | [INFO] [stderr] 70 | 1 => new_ms = new_ms + 60 * 1000 * match chunk.parse::() { [INFO] [stderr] | ______________________^ [INFO] [stderr] 71 | | Ok(value) => value, [INFO] [stderr] 72 | | _ => return None [INFO] [stderr] 73 | | }, [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 70 | 1 => new_ms += 60 * 1000 * match chunk.parse::() { [INFO] [stderr] 71 | Ok(value) => value, [INFO] [stderr] 72 | _ => return None [INFO] [stderr] 73 | }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:74:10 [INFO] [stderr] | [INFO] [stderr] 74 | 2 => new_ms = new_ms + 60 * 60 * 1000 * match chunk.parse::() { [INFO] [stderr] | ______________________^ [INFO] [stderr] 75 | | Ok(value) => value, [INFO] [stderr] 76 | | _ => return None [INFO] [stderr] 77 | | }, [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 74 | 2 => new_ms += 60 * 60 * 1000 * match chunk.parse::() { [INFO] [stderr] 75 | Ok(value) => value, [INFO] [stderr] 76 | _ => return None [INFO] [stderr] 77 | }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:80:4 [INFO] [stderr] | [INFO] [stderr] 80 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from` [INFO] [stderr] --> src/main.rs:88:2 [INFO] [stderr] | [INFO] [stderr] 88 | fn from(hours: i32, mins: i32, secs: i32, msecs: i32) -> Timestamp { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:33:6 [INFO] [stderr] | [INFO] [stderr] 33 | if text.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `text.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | 0 => new_ms = new_ms + 1000 * match chunk2.parse::() { [INFO] [stderr] | __________________________________^ [INFO] [stderr] 58 | | Ok(value) => value, [INFO] [stderr] 59 | | _ => return None [INFO] [stderr] 60 | | }, [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 57 | 0 => new_ms += 1000 * match chunk2.parse::() { [INFO] [stderr] 58 | Ok(value) => value, [INFO] [stderr] 59 | _ => return None [INFO] [stderr] 60 | }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | 1 => new_ms = new_ms + match chunk2.parse::() { [INFO] [stderr] | __________________________________^ [INFO] [stderr] 62 | | Ok(value) => value, [INFO] [stderr] 63 | | _ => return None [INFO] [stderr] 64 | | }, [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 61 | 1 => new_ms += match chunk2.parse::() { [INFO] [stderr] 62 | Ok(value) => value, [INFO] [stderr] 63 | _ => return None [INFO] [stderr] 64 | }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:67:7 [INFO] [stderr] | [INFO] [stderr] 67 | j = j + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `j += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:70:10 [INFO] [stderr] | [INFO] [stderr] 70 | 1 => new_ms = new_ms + 60 * 1000 * match chunk.parse::() { [INFO] [stderr] | ______________________^ [INFO] [stderr] 71 | | Ok(value) => value, [INFO] [stderr] 72 | | _ => return None [INFO] [stderr] 73 | | }, [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 70 | 1 => new_ms += 60 * 1000 * match chunk.parse::() { [INFO] [stderr] 71 | Ok(value) => value, [INFO] [stderr] 72 | _ => return None [INFO] [stderr] 73 | }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:74:10 [INFO] [stderr] | [INFO] [stderr] 74 | 2 => new_ms = new_ms + 60 * 60 * 1000 * match chunk.parse::() { [INFO] [stderr] | ______________________^ [INFO] [stderr] 75 | | Ok(value) => value, [INFO] [stderr] 76 | | _ => return None [INFO] [stderr] 77 | | }, [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 74 | 2 => new_ms += 60 * 60 * 1000 * match chunk.parse::() { [INFO] [stderr] 75 | Ok(value) => value, [INFO] [stderr] 76 | _ => return None [INFO] [stderr] 77 | }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:80:4 [INFO] [stderr] | [INFO] [stderr] 80 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:167:31 [INFO] [stderr] | [INFO] [stderr] 167 | let pair1 = &args[2].split("-").map(|x| match Timestamp::parse(x) { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:173:31 [INFO] [stderr] | [INFO] [stderr] 173 | let pair2 = &args[3].split("-").map(|x| match Timestamp::parse(x) { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:182:4 [INFO] [stderr] | [INFO] [stderr] 182 | writeln!(std::io::stderr(), "Must provide filename and offset argument(s)!").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:187:2 [INFO] [stderr] | [INFO] [stderr] 187 | writeln!(std::io::stderr(), "Offset will be {} scaled by time at a rate of {}", Timestamp::new(0-y), 0f32-x).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:203:25 [INFO] [stderr] | [INFO] [stderr] 203 | if print_next_line && l.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!l.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:236:5 [INFO] [stderr] | [INFO] [stderr] 236 | subtitle_index = subtitle_index + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `subtitle_index += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:241:2 [INFO] [stderr] | [INFO] [stderr] 241 | writeln!(std::io::stderr(), "Processed {} captions", subtitle_index).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:167:31 [INFO] [stderr] | [INFO] [stderr] 167 | let pair1 = &args[2].split("-").map(|x| match Timestamp::parse(x) { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:173:31 [INFO] [stderr] | [INFO] [stderr] 173 | let pair2 = &args[3].split("-").map(|x| match Timestamp::parse(x) { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:182:4 [INFO] [stderr] | [INFO] [stderr] 182 | writeln!(std::io::stderr(), "Must provide filename and offset argument(s)!").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:187:2 [INFO] [stderr] | [INFO] [stderr] 187 | writeln!(std::io::stderr(), "Offset will be {} scaled by time at a rate of {}", Timestamp::new(0-y), 0f32-x).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:203:25 [INFO] [stderr] | [INFO] [stderr] 203 | if print_next_line && l.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!l.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:236:5 [INFO] [stderr] | [INFO] [stderr] 236 | subtitle_index = subtitle_index + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `subtitle_index += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:241:2 [INFO] [stderr] | [INFO] [stderr] 241 | writeln!(std::io::stderr(), "Processed {} captions", subtitle_index).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.44s [INFO] running `"docker" "inspect" "63a5abf2a1bdd9163025620da20db272efa8df98281aea78e415285bf2300c3e"` [INFO] running `"docker" "rm" "-f" "63a5abf2a1bdd9163025620da20db272efa8df98281aea78e415285bf2300c3e"` [INFO] [stdout] 63a5abf2a1bdd9163025620da20db272efa8df98281aea78e415285bf2300c3e