[INFO] updating cached repository neosmart/relaunch [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/neosmart/relaunch [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/neosmart/relaunch" "work/ex/clippy-test-run/sources/stable/gh/neosmart/relaunch"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/neosmart/relaunch'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/neosmart/relaunch" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/neosmart/relaunch"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/neosmart/relaunch'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bee75ef198d67f86e626f326b84c5d1e2d9ca14f [INFO] sha for GitHub repo neosmart/relaunch: bee75ef198d67f86e626f326b84c5d1e2d9ca14f [INFO] validating manifest of neosmart/relaunch on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of neosmart/relaunch on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing neosmart/relaunch [INFO] finished frobbing neosmart/relaunch [INFO] frobbed toml for neosmart/relaunch written to work/ex/clippy-test-run/sources/stable/gh/neosmart/relaunch/Cargo.toml [INFO] started frobbing neosmart/relaunch [INFO] finished frobbing neosmart/relaunch [INFO] frobbed toml for neosmart/relaunch written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/neosmart/relaunch/Cargo.toml [INFO] crate neosmart/relaunch has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting neosmart/relaunch against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/neosmart/relaunch:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] de88f47a7be98c686b32d65d95251c630dc1a3ebc663f0eb3b7c995fdb7ade99 [INFO] running `"docker" "start" "-a" "de88f47a7be98c686b32d65d95251c630dc1a3ebc663f0eb3b7c995fdb7ade99"` [INFO] [stderr] Checking time v0.1.38 [INFO] [stderr] Checking relaunch v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: All variants have the same postfix: `Err` [INFO] [stderr] --> src/main.rs:288:1 [INFO] [stderr] | [INFO] [stderr] 288 | / enum RelaunchError { [INFO] [stderr] 289 | | LaunchErr(std::io::Error), [INFO] [stderr] 290 | | StdoutErr(std::io::Error), [INFO] [stderr] 291 | | StderrErr(std::io::Error), [INFO] [stderr] 292 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: All variants have the same postfix: `Err` [INFO] [stderr] --> src/main.rs:288:1 [INFO] [stderr] | [INFO] [stderr] 288 | / enum RelaunchError { [INFO] [stderr] 289 | | LaunchErr(std::io::Error), [INFO] [stderr] 290 | | StdoutErr(std::io::Error), [INFO] [stderr] 291 | | StderrErr(std::io::Error), [INFO] [stderr] 292 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:194:97 [INFO] [stderr] | [INFO] [stderr] 194 | let stdout = OpenOptions::new().create(true).append(true).open(path_stdout).map_err(|e| RelaunchError::StdoutErr(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `RelaunchError::StdoutErr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:198:97 [INFO] [stderr] | [INFO] [stderr] 198 | let stderr = OpenOptions::new().create(true).append(true).open(path_stderr).map_err(|e| RelaunchError::StderrErr(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `RelaunchError::StderrErr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:202:45 [INFO] [stderr] | [INFO] [stderr] 202 | let mut child = cmd.spawn().map_err(|e| RelaunchError::LaunchErr(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `RelaunchError::LaunchErr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:237:5 [INFO] [stderr] | [INFO] [stderr] 237 | / match moptions.restart_always { [INFO] [stderr] 238 | | true => Ok(RelaunchResult::RestartCountExceeded(fail_count)), [INFO] [stderr] 239 | | false => match fail_count { [INFO] [stderr] 240 | | 0 => Ok(RelaunchResult::Ok), [INFO] [stderr] ... | [INFO] [stderr] 245 | | } [INFO] [stderr] 246 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 237 | if moptions.restart_always { Ok(RelaunchResult::RestartCountExceeded(fail_count)) } else { match fail_count { [INFO] [stderr] 238 | 0 => Ok(RelaunchResult::Ok), [INFO] [stderr] 239 | x => match exit_code { [INFO] [stderr] 240 | Some(0) => Ok(RelaunchResult::OkAfterRestart(x)), [INFO] [stderr] 241 | None | Some(_) => Ok(RelaunchResult::RestartCountExceeded(fail_count)), [INFO] [stderr] 242 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:194:97 [INFO] [stderr] | [INFO] [stderr] 194 | let stdout = OpenOptions::new().create(true).append(true).open(path_stdout).map_err(|e| RelaunchError::StdoutErr(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `RelaunchError::StdoutErr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:198:97 [INFO] [stderr] | [INFO] [stderr] 198 | let stderr = OpenOptions::new().create(true).append(true).open(path_stderr).map_err(|e| RelaunchError::StderrErr(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `RelaunchError::StderrErr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:202:45 [INFO] [stderr] | [INFO] [stderr] 202 | let mut child = cmd.spawn().map_err(|e| RelaunchError::LaunchErr(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `RelaunchError::LaunchErr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:237:5 [INFO] [stderr] | [INFO] [stderr] 237 | / match moptions.restart_always { [INFO] [stderr] 238 | | true => Ok(RelaunchResult::RestartCountExceeded(fail_count)), [INFO] [stderr] 239 | | false => match fail_count { [INFO] [stderr] 240 | | 0 => Ok(RelaunchResult::Ok), [INFO] [stderr] ... | [INFO] [stderr] 245 | | } [INFO] [stderr] 246 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 237 | if moptions.restart_always { Ok(RelaunchResult::RestartCountExceeded(fail_count)) } else { match fail_count { [INFO] [stderr] 238 | 0 => Ok(RelaunchResult::Ok), [INFO] [stderr] 239 | x => match exit_code { [INFO] [stderr] 240 | Some(0) => Ok(RelaunchResult::OkAfterRestart(x)), [INFO] [stderr] 241 | None | Some(_) => Ok(RelaunchResult::RestartCountExceeded(fail_count)), [INFO] [stderr] 242 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.38s [INFO] running `"docker" "inspect" "de88f47a7be98c686b32d65d95251c630dc1a3ebc663f0eb3b7c995fdb7ade99"` [INFO] running `"docker" "rm" "-f" "de88f47a7be98c686b32d65d95251c630dc1a3ebc663f0eb3b7c995fdb7ade99"` [INFO] [stdout] de88f47a7be98c686b32d65d95251c630dc1a3ebc663f0eb3b7c995fdb7ade99