[INFO] updating cached repository neoeno/oorustlippio [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/neoeno/oorustlippio [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/neoeno/oorustlippio" "work/ex/clippy-test-run/sources/stable/gh/neoeno/oorustlippio"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/neoeno/oorustlippio'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/neoeno/oorustlippio" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/neoeno/oorustlippio"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/neoeno/oorustlippio'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b6af41e7432221f92ea0938f354e143afc533465 [INFO] sha for GitHub repo neoeno/oorustlippio: b6af41e7432221f92ea0938f354e143afc533465 [INFO] validating manifest of neoeno/oorustlippio on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of neoeno/oorustlippio on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing neoeno/oorustlippio [INFO] finished frobbing neoeno/oorustlippio [INFO] frobbed toml for neoeno/oorustlippio written to work/ex/clippy-test-run/sources/stable/gh/neoeno/oorustlippio/Cargo.toml [INFO] started frobbing neoeno/oorustlippio [INFO] finished frobbing neoeno/oorustlippio [INFO] frobbed toml for neoeno/oorustlippio written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/neoeno/oorustlippio/Cargo.toml [INFO] crate neoeno/oorustlippio has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting neoeno/oorustlippio against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/neoeno/oorustlippio:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 346808aba1da24d994616076a908c958010154533bdae9a669721ae1c2996cc3 [INFO] running `"docker" "start" "-a" "346808aba1da24d994616076a908c958010154533bdae9a669721ae1c2996cc3"` [INFO] [stderr] Checking ooulipo v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:32:36 [INFO] [stderr] | [INFO] [stderr] 32 | lines.push(ASTNode::Line { name: name, message: trimmed_message }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:32:36 [INFO] [stderr] | [INFO] [stderr] 32 | lines.push(ASTNode::Line { name: name, message: trimmed_message }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | return ASTNode::Dialogue(lines); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ASTNode::Dialogue(lines)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | / return match node { [INFO] [stderr] 50 | | ASTNode::Dialogue(items) => advance_dialogue(items), [INFO] [stderr] 51 | | ASTNode::Line { name, message } => advance_line(name, message), [INFO] [stderr] 52 | | ASTNode::Noop => panic!("Can't advance a noop :("), [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 49 | match node { [INFO] [stderr] 50 | ASTNode::Dialogue(items) => advance_dialogue(items), [INFO] [stderr] 51 | ASTNode::Line { name, message } => advance_line(name, message), [INFO] [stderr] 52 | ASTNode::Noop => panic!("Can't advance a noop :("), [INFO] [stderr] 53 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / return match items.first() { [INFO] [stderr] 58 | | Option::Some(&ASTNode::Noop) => advance(ASTNode::Dialogue(items[1..].to_vec())), [INFO] [stderr] 59 | | Option::Some(item) => { [INFO] [stderr] 60 | | let (action, advanced_node) = advance((*item).clone()); [INFO] [stderr] ... | [INFO] [stderr] 63 | | Option::None => (Action::Noop, ASTNode::Noop), [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 57 | match items.first() { [INFO] [stderr] 58 | Option::Some(&ASTNode::Noop) => advance(ASTNode::Dialogue(items[1..].to_vec())), [INFO] [stderr] 59 | Option::Some(item) => { [INFO] [stderr] 60 | let (action, advanced_node) = advance((*item).clone()); [INFO] [stderr] 61 | return (action, ASTNode::Dialogue([vec![advanced_node], items[1..].to_vec()].concat())) [INFO] [stderr] 62 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | return (Action::Print(format!("{} says {}", name, message)), ASTNode::Noop); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(Action::Print(format!("{} says {}", name, message)), ASTNode::Noop)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | return ASTNode::Dialogue(lines); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ASTNode::Dialogue(lines)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | / return match node { [INFO] [stderr] 50 | | ASTNode::Dialogue(items) => advance_dialogue(items), [INFO] [stderr] 51 | | ASTNode::Line { name, message } => advance_line(name, message), [INFO] [stderr] 52 | | ASTNode::Noop => panic!("Can't advance a noop :("), [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 49 | match node { [INFO] [stderr] 50 | ASTNode::Dialogue(items) => advance_dialogue(items), [INFO] [stderr] 51 | ASTNode::Line { name, message } => advance_line(name, message), [INFO] [stderr] 52 | ASTNode::Noop => panic!("Can't advance a noop :("), [INFO] [stderr] 53 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / return match items.first() { [INFO] [stderr] 58 | | Option::Some(&ASTNode::Noop) => advance(ASTNode::Dialogue(items[1..].to_vec())), [INFO] [stderr] 59 | | Option::Some(item) => { [INFO] [stderr] 60 | | let (action, advanced_node) = advance((*item).clone()); [INFO] [stderr] ... | [INFO] [stderr] 63 | | Option::None => (Action::Noop, ASTNode::Noop), [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 57 | match items.first() { [INFO] [stderr] 58 | Option::Some(&ASTNode::Noop) => advance(ASTNode::Dialogue(items[1..].to_vec())), [INFO] [stderr] 59 | Option::Some(item) => { [INFO] [stderr] 60 | let (action, advanced_node) = advance((*item).clone()); [INFO] [stderr] 61 | return (action, ASTNode::Dialogue([vec![advanced_node], items[1..].to_vec()].concat())) [INFO] [stderr] 62 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | return (Action::Print(format!("{} says {}", name, message)), ASTNode::Noop); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(Action::Print(format!("{} says {}", name, message)), ASTNode::Noop)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.36s [INFO] running `"docker" "inspect" "346808aba1da24d994616076a908c958010154533bdae9a669721ae1c2996cc3"` [INFO] running `"docker" "rm" "-f" "346808aba1da24d994616076a908c958010154533bdae9a669721ae1c2996cc3"` [INFO] [stdout] 346808aba1da24d994616076a908c958010154533bdae9a669721ae1c2996cc3