[INFO] updating cached repository nenofite/gene-code [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nenofite/gene-code [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nenofite/gene-code" "work/ex/clippy-test-run/sources/stable/gh/nenofite/gene-code"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nenofite/gene-code'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nenofite/gene-code" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nenofite/gene-code"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nenofite/gene-code'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 649ddc28448d9480a7012744b7720d7564823ddf [INFO] sha for GitHub repo nenofite/gene-code: 649ddc28448d9480a7012744b7720d7564823ddf [INFO] validating manifest of nenofite/gene-code on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nenofite/gene-code on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nenofite/gene-code [INFO] finished frobbing nenofite/gene-code [INFO] frobbed toml for nenofite/gene-code written to work/ex/clippy-test-run/sources/stable/gh/nenofite/gene-code/Cargo.toml [INFO] started frobbing nenofite/gene-code [INFO] finished frobbing nenofite/gene-code [INFO] frobbed toml for nenofite/gene-code written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nenofite/gene-code/Cargo.toml [INFO] crate nenofite/gene-code has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nenofite/gene-code against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nenofite/gene-code:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e601b886cae7a5c7dc2eb883c46fb6506023a09afb639d1bfc3356feb991fffe [INFO] running `"docker" "start" "-a" "e601b886cae7a5c7dc2eb883c46fb6506023a09afb639d1bfc3356feb991fffe"` [INFO] [stderr] Checking gene_code v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gene.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | fitness: fitness, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `fitness` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gene.rs:144:28 [INFO] [stderr] | [INFO] [stderr] 144 | TestGene { id: id } [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gene.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | fitness: fitness, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `fitness` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gene.rs:144:28 [INFO] [stderr] | [INFO] [stderr] 144 | TestGene { id: id } [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `Hasher` [INFO] [stderr] --> src/gene.rs:7:23 [INFO] [stderr] | [INFO] [stderr] 7 | use std::hash::{Hash, Hasher}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashSet` [INFO] [stderr] --> src/gene.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use std::collections::HashSet; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/prog_gene.rs:172:19 [INFO] [stderr] | [INFO] [stderr] 172 | let eps = 0.000001; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.000_001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `Hasher` [INFO] [stderr] --> src/gene.rs:7:23 [INFO] [stderr] | [INFO] [stderr] 7 | use std::hash::{Hash, Hasher}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashSet` [INFO] [stderr] --> src/gene.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use std::collections::HashSet; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `run_all` [INFO] [stderr] --> src/lang.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | pub fn run_all(&mut self) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/prog_gene.rs:62:24 [INFO] [stderr] | [INFO] [stderr] 62 | if result.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!result.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/prog_gene.rs:69:24 [INFO] [stderr] | [INFO] [stderr] 69 | if result.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!result.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/prog_gene.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | / match prog { [INFO] [stderr] 106 | | &D(d) => write!(f, "{}", d)?, [INFO] [stderr] 107 | | &C(Add) => write!(f, "+")?, [INFO] [stderr] 108 | | &C(Sub) => write!(f, "-")?, [INFO] [stderr] ... | [INFO] [stderr] 112 | | &C(Swap) => write!(f, "swap")?, [INFO] [stderr] 113 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 105 | match *prog { [INFO] [stderr] 106 | D(d) => write!(f, "{}", d)?, [INFO] [stderr] 107 | C(Add) => write!(f, "+")?, [INFO] [stderr] 108 | C(Sub) => write!(f, "-")?, [INFO] [stderr] 109 | C(Mult) => write!(f, "*")?, [INFO] [stderr] 110 | C(Div) => write!(f, "/")?, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/lang.rs:141:5 [INFO] [stderr] | [INFO] [stderr] 141 | / fn use_commands() { [INFO] [stderr] 142 | | let mut s = Stack::new(); [INFO] [stderr] 143 | | [INFO] [stderr] 144 | | // We can run builtin commands on the stack [INFO] [stderr] ... | [INFO] [stderr] 198 | | assert_eq!(s.commands.len(), 0); [INFO] [stderr] 199 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/gene.rs:190:13 [INFO] [stderr] | [INFO] [stderr] 190 | assert_eq!(g.0.id as f32, g.1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/gene.rs:190:13 [INFO] [stderr] | [INFO] [stderr] 190 | assert_eq!(g.0.id as f32, g.1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/gene.rs:194:9 [INFO] [stderr] | [INFO] [stderr] 194 | assert_eq!(pool.get_best().1, 906.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/gene.rs:194:9 [INFO] [stderr] | [INFO] [stderr] 194 | assert_eq!(pool.get_best().1, 906.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/prog_gene.rs:62:24 [INFO] [stderr] | [INFO] [stderr] 62 | if result.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!result.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/prog_gene.rs:69:24 [INFO] [stderr] | [INFO] [stderr] 69 | if result.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!result.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/prog_gene.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | / match prog { [INFO] [stderr] 106 | | &D(d) => write!(f, "{}", d)?, [INFO] [stderr] 107 | | &C(Add) => write!(f, "+")?, [INFO] [stderr] 108 | | &C(Sub) => write!(f, "-")?, [INFO] [stderr] ... | [INFO] [stderr] 112 | | &C(Swap) => write!(f, "swap")?, [INFO] [stderr] 113 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 105 | match *prog { [INFO] [stderr] 106 | D(d) => write!(f, "{}", d)?, [INFO] [stderr] 107 | C(Add) => write!(f, "+")?, [INFO] [stderr] 108 | C(Sub) => write!(f, "-")?, [INFO] [stderr] 109 | C(Mult) => write!(f, "*")?, [INFO] [stderr] 110 | C(Div) => write!(f, "/")?, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `gene_code`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "e601b886cae7a5c7dc2eb883c46fb6506023a09afb639d1bfc3356feb991fffe"` [INFO] running `"docker" "rm" "-f" "e601b886cae7a5c7dc2eb883c46fb6506023a09afb639d1bfc3356feb991fffe"` [INFO] [stdout] e601b886cae7a5c7dc2eb883c46fb6506023a09afb639d1bfc3356feb991fffe