[INFO] updating cached repository nbrick/crush [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nbrick/crush [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nbrick/crush" "work/ex/clippy-test-run/sources/stable/gh/nbrick/crush"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nbrick/crush'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nbrick/crush" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nbrick/crush"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nbrick/crush'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e4a4091a3de53d188970054470af631b25112fb6 [INFO] sha for GitHub repo nbrick/crush: e4a4091a3de53d188970054470af631b25112fb6 [INFO] validating manifest of nbrick/crush on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nbrick/crush on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nbrick/crush [INFO] finished frobbing nbrick/crush [INFO] frobbed toml for nbrick/crush written to work/ex/clippy-test-run/sources/stable/gh/nbrick/crush/Cargo.toml [INFO] started frobbing nbrick/crush [INFO] finished frobbing nbrick/crush [INFO] frobbed toml for nbrick/crush written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nbrick/crush/Cargo.toml [INFO] crate nbrick/crush has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nbrick/crush against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nbrick/crush:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7c02d09130fb614d8266079ca2bd015e04e5ca87e598501ac84ab81ed1ccd11a [INFO] running `"docker" "start" "-a" "7c02d09130fb614d8266079ca2bd015e04e5ca87e598501ac84ab81ed1ccd11a"` [INFO] [stderr] Checking crush v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:47:16 [INFO] [stderr] | [INFO] [stderr] 47 | Ok(Entry { delta: delta, tags: tokens.map(String::from).collect() }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `delta` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:47:16 [INFO] [stderr] | [INFO] [stderr] 47 | Ok(Entry { delta: delta, tags: tokens.map(String::from).collect() }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `delta` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:51:23 [INFO] [stderr] | [INFO] [stderr] 51 | fn sum_delta(entries: &Vec) -> Delta { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Entry]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | let ref filename = args[1]; [INFO] [stderr] | ----^^^^^^^^^^^^----------- help: try: `let filename = &args[1];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | let ref filter_tag = args[2]; [INFO] [stderr] | ----^^^^^^^^^^^^^^----------- help: try: `let filter_tag = &args[2];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | / match res_e { [INFO] [stderr] 72 | | &Ok(_) => true, [INFO] [stderr] 73 | | &Err(ref err) => { [INFO] [stderr] 74 | | writeln!(&mut stderr(), "crush@{}:{}: {}", filename, n+1, err).unwrap(); [INFO] [stderr] 75 | | false [INFO] [stderr] 76 | | }, [INFO] [stderr] 77 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 71 | match *res_e { [INFO] [stderr] 72 | Ok(_) => true, [INFO] [stderr] 73 | Err(ref err) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:51:23 [INFO] [stderr] | [INFO] [stderr] 51 | fn sum_delta(entries: &Vec) -> Delta { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Entry]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | let ref filename = args[1]; [INFO] [stderr] | ----^^^^^^^^^^^^----------- help: try: `let filename = &args[1];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | let ref filter_tag = args[2]; [INFO] [stderr] | ----^^^^^^^^^^^^^^----------- help: try: `let filter_tag = &args[2];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | / match res_e { [INFO] [stderr] 72 | | &Ok(_) => true, [INFO] [stderr] 73 | | &Err(ref err) => { [INFO] [stderr] 74 | | writeln!(&mut stderr(), "crush@{}:{}: {}", filename, n+1, err).unwrap(); [INFO] [stderr] 75 | | false [INFO] [stderr] 76 | | }, [INFO] [stderr] 77 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 71 | match *res_e { [INFO] [stderr] 72 | Ok(_) => true, [INFO] [stderr] 73 | Err(ref err) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.37s [INFO] running `"docker" "inspect" "7c02d09130fb614d8266079ca2bd015e04e5ca87e598501ac84ab81ed1ccd11a"` [INFO] running `"docker" "rm" "-f" "7c02d09130fb614d8266079ca2bd015e04e5ca87e598501ac84ab81ed1ccd11a"` [INFO] [stdout] 7c02d09130fb614d8266079ca2bd015e04e5ca87e598501ac84ab81ed1ccd11a