[INFO] updating cached repository nathanjent/ruby-the-ms.-hackman-bot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nathanjent/ruby-the-ms.-hackman-bot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nathanjent/ruby-the-ms.-hackman-bot" "work/ex/clippy-test-run/sources/stable/gh/nathanjent/ruby-the-ms.-hackman-bot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nathanjent/ruby-the-ms.-hackman-bot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nathanjent/ruby-the-ms.-hackman-bot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nathanjent/ruby-the-ms.-hackman-bot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nathanjent/ruby-the-ms.-hackman-bot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9c1c98050ede3daf2a850ab0b0ccc218ecd51210 [INFO] sha for GitHub repo nathanjent/ruby-the-ms.-hackman-bot: 9c1c98050ede3daf2a850ab0b0ccc218ecd51210 [INFO] validating manifest of nathanjent/ruby-the-ms.-hackman-bot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nathanjent/ruby-the-ms.-hackman-bot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nathanjent/ruby-the-ms.-hackman-bot [INFO] finished frobbing nathanjent/ruby-the-ms.-hackman-bot [INFO] frobbed toml for nathanjent/ruby-the-ms.-hackman-bot written to work/ex/clippy-test-run/sources/stable/gh/nathanjent/ruby-the-ms.-hackman-bot/Cargo.toml [INFO] started frobbing nathanjent/ruby-the-ms.-hackman-bot [INFO] finished frobbing nathanjent/ruby-the-ms.-hackman-bot [INFO] frobbed toml for nathanjent/ruby-the-ms.-hackman-bot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nathanjent/ruby-the-ms.-hackman-bot/Cargo.toml [INFO] crate nathanjent/ruby-the-ms.-hackman-bot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nathanjent/ruby-the-ms.-hackman-bot against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nathanjent/ruby-the-ms.-hackman-bot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 20a677895e370daa1b8db38a032e010e433f583a5e074f818ba2be406c51145e [INFO] running `"docker" "start" "-a" "20a677895e370daa1b8db38a032e010e433f583a5e074f818ba2be406c51145e"` [INFO] [stderr] Checking ruby_the_ms_hack_man_bot v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/player.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/simple_matrix.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/simple_matrix.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/player.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/simple_matrix.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/simple_matrix.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused imports: `BufRead`, `Write`, `self as stdio` [INFO] [stderr] --> src/main.rs:9:15 [INFO] [stderr] | [INFO] [stderr] 9 | use std::io::{self as stdio, BufRead, Write}; [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^ ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/player.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | next_move [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/player.rs:64:25 [INFO] [stderr] | [INFO] [stderr] 64 | let mut next_move = Move::new(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `error::*` [INFO] [stderr] --> src/main.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | use error::*; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `bot::BotState` [INFO] [stderr] --> src/main.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | use bot::BotState; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `handler::*` [INFO] [stderr] --> src/main.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | use handler::*; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/player.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | next_move [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/player.rs:64:25 [INFO] [stderr] | [INFO] [stderr] 64 | let mut next_move = Move::new(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `n` [INFO] [stderr] --> src/handler.rs:86:62 [INFO] [stderr] | [INFO] [stderr] 86 | Message::Action(Action::Character { time_to_respond: n }) => { [INFO] [stderr] | ^ help: consider using `_n` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `n` [INFO] [stderr] --> src/handler.rs:90:57 [INFO] [stderr] | [INFO] [stderr] 90 | Message::Action(Action::Move { time_to_respond: n }) => { [INFO] [stderr] | ^ help: consider using `_n` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `action` is never read [INFO] [stderr] --> src/handler.rs:97:21 [INFO] [stderr] | [INFO] [stderr] 97 | let mut action = String::new(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `en_pos` [INFO] [stderr] --> src/handler.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | let en_pos = &field.enemy_positions; [INFO] [stderr] | ^^^^^^ help: consider using `_en_pos` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bm_pos` [INFO] [stderr] --> src/handler.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | let bm_pos = &field.bomb_positions; [INFO] [stderr] | ^^^^^^ help: consider using `_bm_pos` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `sn_pos` [INFO] [stderr] --> src/handler.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | let sn_pos = &field.snippet_positions; [INFO] [stderr] | ^^^^^^ help: consider using `_sn_pos` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `player_id` [INFO] [stderr] --> src/handler.rs:117:29 [INFO] [stderr] | [INFO] [stderr] 117 | fn make_move(field: &Field, player_id: &i32) -> Move { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_player_id` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `enemy` [INFO] [stderr] --> src/field.rs:89:37 [INFO] [stderr] | [INFO] [stderr] 89 | CellItem::Enemy(enemy) => { [INFO] [stderr] | ^^^^^ help: consider using `_enemy` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `n` [INFO] [stderr] --> src/field.rs:92:36 [INFO] [stderr] | [INFO] [stderr] 92 | CellItem::Bomb(n) => { [INFO] [stderr] | ^ help: consider using `_n` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/player.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | let mut next_move = Move::new(); [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `character_type` [INFO] [stderr] --> src/player.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn character_type(&self) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Bixiette` [INFO] [stderr] --> src/player.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | Bixiette, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `make_move` [INFO] [stderr] --> src/player.rs:63:1 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn make_move() -> Move { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `reset_to` [INFO] [stderr] --> src/simple_matrix.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn reset_to(&mut self, value: T) [INFO] [stderr] 21 | | where T: Copy [INFO] [stderr] 22 | | { [INFO] [stderr] 23 | | for v in self.m.iter_mut() { [INFO] [stderr] 24 | | *v = value; [INFO] [stderr] 25 | | } [INFO] [stderr] 26 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/field.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | s.split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/field.rs:125:24 [INFO] [stderr] | [INFO] [stderr] 125 | cell.split(";") [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unused variable: `n` [INFO] [stderr] --> src/handler.rs:86:62 [INFO] [stderr] | [INFO] [stderr] 86 | Message::Action(Action::Character { time_to_respond: n }) => { [INFO] [stderr] | ^ help: consider using `_n` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `n` [INFO] [stderr] --> src/handler.rs:90:57 [INFO] [stderr] | [INFO] [stderr] 90 | Message::Action(Action::Move { time_to_respond: n }) => { [INFO] [stderr] | ^ help: consider using `_n` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `action` is never read [INFO] [stderr] --> src/handler.rs:97:21 [INFO] [stderr] | [INFO] [stderr] 97 | let mut action = String::new(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `en_pos` [INFO] [stderr] --> src/handler.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | let en_pos = &field.enemy_positions; [INFO] [stderr] | ^^^^^^ help: consider using `_en_pos` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bm_pos` [INFO] [stderr] --> src/handler.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | let bm_pos = &field.bomb_positions; [INFO] [stderr] | ^^^^^^ help: consider using `_bm_pos` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `sn_pos` [INFO] [stderr] --> src/handler.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | let sn_pos = &field.snippet_positions; [INFO] [stderr] | ^^^^^^ help: consider using `_sn_pos` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `player_id` [INFO] [stderr] --> src/handler.rs:117:29 [INFO] [stderr] | [INFO] [stderr] 117 | fn make_move(field: &Field, player_id: &i32) -> Move { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_player_id` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `expected_cells` [INFO] [stderr] --> src/field.rs:197:13 [INFO] [stderr] | [INFO] [stderr] 197 | let expected_cells = vec![CellItem::Empty, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using `_expected_cells` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `actual_cells` [INFO] [stderr] --> src/field.rs:206:13 [INFO] [stderr] | [INFO] [stderr] 206 | let actual_cells = parse_field(field_str); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using `_actual_cells` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `enemy` [INFO] [stderr] --> src/field.rs:89:37 [INFO] [stderr] | [INFO] [stderr] 89 | CellItem::Enemy(enemy) => { [INFO] [stderr] | ^^^^^ help: consider using `_enemy` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `n` [INFO] [stderr] --> src/field.rs:92:36 [INFO] [stderr] | [INFO] [stderr] 92 | CellItem::Bomb(n) => { [INFO] [stderr] | ^ help: consider using `_n` instead [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/handler.rs:91:17 [INFO] [stderr] | [INFO] [stderr] 91 | let ref field = bot.field.borrow(); [INFO] [stderr] | ----^^^^^^^^^---------------------- help: try: `let field = &bot.field.borrow();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/handler.rs:94:17 [INFO] [stderr] | [INFO] [stderr] 94 | let ref player_name = settings.name; [INFO] [stderr] | ----^^^^^^^^^^^^^^^----------------- help: try: `let player_name = &settings.name;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/handler.rs:95:17 [INFO] [stderr] | [INFO] [stderr] 95 | let ref player_id = settings.id; [INFO] [stderr] | ----^^^^^^^^^^^^^--------------- help: try: `let player_id = &settings.id;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/handler.rs:117:40 [INFO] [stderr] | [INFO] [stderr] 117 | fn make_move(field: &Field, player_id: &i32) -> Move { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/handler.rs:130:5 [INFO] [stderr] | [INFO] [stderr] 130 | / if let &Some(p) = my_pos { [INFO] [stderr] 131 | | if let &Some(o) = op_pos { [INFO] [stderr] 132 | | next_move.move_type = match p.x % o.x { [INFO] [stderr] 133 | | 0 => MoveType::Up, [INFO] [stderr] ... | [INFO] [stderr] 139 | | } [INFO] [stderr] 140 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 130 | if let Some(p) = *my_pos { [INFO] [stderr] | ^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/handler.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | / if let &Some(o) = op_pos { [INFO] [stderr] 132 | | next_move.move_type = match p.x % o.x { [INFO] [stderr] 133 | | 0 => MoveType::Up, [INFO] [stderr] 134 | | 1 => MoveType::Down, [INFO] [stderr] ... | [INFO] [stderr] 138 | | }; [INFO] [stderr] 139 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 131 | if let Some(o) = *op_pos { [INFO] [stderr] | ^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/message.rs:60:41 [INFO] [stderr] | [INFO] [stderr] 60 | let names = value.split(",").map(|s| s.into()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/player.rs:25:37 [INFO] [stderr] | [INFO] [stderr] 25 | CharacterType::Bixie => format!("bixie"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"bixie".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/player.rs:26:40 [INFO] [stderr] | [INFO] [stderr] 26 | CharacterType::Bixiette => format!("bixiette"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"bixiette".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | / match output { [INFO] [stderr] 52 | | Some(o) => writeln!(writer, "{}", o)?, [INFO] [stderr] 53 | | None => {}, [INFO] [stderr] 54 | | } [INFO] [stderr] | |_____________________^ help: try this: `if let Some(o) = output { writeln!(writer, "{}", o)? }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/player.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | let mut next_move = Move::new(); [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `BotState` [INFO] [stderr] --> src/bot.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | pub struct BotState { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Settings` [INFO] [stderr] --> src/bot.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | pub struct Settings { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/bot.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn new() -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `UnintentionalBreak` [INFO] [stderr] --> src/error.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | UnintentionalBreak, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `PlayerNotFound` [INFO] [stderr] --> src/error.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | PlayerNotFound(String), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Field` [INFO] [stderr] --> src/field.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | pub struct Field { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/field.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn new(width: usize, height: usize) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_point` [INFO] [stderr] --> src/field.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | fn get_point(&self, index: usize) -> Point { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `update_field` [INFO] [stderr] --> src/field.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn update_field(&mut self, field: Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_width` [INFO] [stderr] --> src/field.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | pub fn set_width(&mut self, width: usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_height` [INFO] [stderr] --> src/field.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | pub fn set_height(&mut self, height: usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `handle_message` [INFO] [stderr] --> src/handler.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn handle_message(line: String, bot: &BotState) -> Result> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `make_move` [INFO] [stderr] --> src/handler.rs:117:1 [INFO] [stderr] | [INFO] [stderr] 117 | fn make_move(field: &Field, player_id: &i32) -> Move { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Player` [INFO] [stderr] --> src/player.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub struct Player { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/player.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn new(name: String) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `character_type` [INFO] [stderr] --> src/player.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn character_type(&self) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `CharacterType` [INFO] [stderr] --> src/player.rs:32:1 [INFO] [stderr] | [INFO] [stderr] 32 | pub enum CharacterType { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Move` [INFO] [stderr] --> src/player.rs:40:1 [INFO] [stderr] | [INFO] [stderr] 40 | pub struct Move { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `MoveType` [INFO] [stderr] --> src/player.rs:46:1 [INFO] [stderr] | [INFO] [stderr] 46 | pub enum MoveType { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/player.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn new() -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `make_move` [INFO] [stderr] --> src/player.rs:63:1 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn make_move() -> Move { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/simple_matrix.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn new(width: usize, height: usize) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `reset_to` [INFO] [stderr] --> src/simple_matrix.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn reset_to(&mut self, value: T) [INFO] [stderr] 21 | | where T: Copy [INFO] [stderr] 22 | | { [INFO] [stderr] 23 | | for v in self.m.iter_mut() { [INFO] [stderr] 24 | | *v = value; [INFO] [stderr] 25 | | } [INFO] [stderr] 26 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/field.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | s.split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/field.rs:125:24 [INFO] [stderr] | [INFO] [stderr] 125 | cell.split(";") [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: module `Test` should have a snake case name such as `test` [INFO] [stderr] --> src/field.rs:191:1 [INFO] [stderr] | [INFO] [stderr] 191 | / mod Test { [INFO] [stderr] 192 | | use field::{parse_field, CellItem, AiType, GateDirection}; [INFO] [stderr] 193 | | #[test] [INFO] [stderr] 194 | | fn parse_field_test() { [INFO] [stderr] ... | [INFO] [stderr] 207 | | } [INFO] [stderr] 208 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/handler.rs:91:17 [INFO] [stderr] | [INFO] [stderr] 91 | let ref field = bot.field.borrow(); [INFO] [stderr] | ----^^^^^^^^^---------------------- help: try: `let field = &bot.field.borrow();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/handler.rs:94:17 [INFO] [stderr] | [INFO] [stderr] 94 | let ref player_name = settings.name; [INFO] [stderr] | ----^^^^^^^^^^^^^^^----------------- help: try: `let player_name = &settings.name;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/handler.rs:95:17 [INFO] [stderr] | [INFO] [stderr] 95 | let ref player_id = settings.id; [INFO] [stderr] | ----^^^^^^^^^^^^^--------------- help: try: `let player_id = &settings.id;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/handler.rs:117:40 [INFO] [stderr] | [INFO] [stderr] 117 | fn make_move(field: &Field, player_id: &i32) -> Move { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/handler.rs:130:5 [INFO] [stderr] | [INFO] [stderr] 130 | / if let &Some(p) = my_pos { [INFO] [stderr] 131 | | if let &Some(o) = op_pos { [INFO] [stderr] 132 | | next_move.move_type = match p.x % o.x { [INFO] [stderr] 133 | | 0 => MoveType::Up, [INFO] [stderr] ... | [INFO] [stderr] 139 | | } [INFO] [stderr] 140 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 130 | if let Some(p) = *my_pos { [INFO] [stderr] | ^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/handler.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | / if let &Some(o) = op_pos { [INFO] [stderr] 132 | | next_move.move_type = match p.x % o.x { [INFO] [stderr] 133 | | 0 => MoveType::Up, [INFO] [stderr] 134 | | 1 => MoveType::Down, [INFO] [stderr] ... | [INFO] [stderr] 138 | | }; [INFO] [stderr] 139 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 131 | if let Some(o) = *op_pos { [INFO] [stderr] | ^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/message.rs:60:41 [INFO] [stderr] | [INFO] [stderr] 60 | let names = value.split(",").map(|s| s.into()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/player.rs:25:37 [INFO] [stderr] | [INFO] [stderr] 25 | CharacterType::Bixie => format!("bixie"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"bixie".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/player.rs:26:40 [INFO] [stderr] | [INFO] [stderr] 26 | CharacterType::Bixiette => format!("bixiette"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"bixiette".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: module `Test` should have a snake case name such as `test` [INFO] [stderr] --> src/simple_matrix.rs:49:1 [INFO] [stderr] | [INFO] [stderr] 49 | / mod Test { [INFO] [stderr] 50 | | use simple_matrix::Matrix; [INFO] [stderr] 51 | | [INFO] [stderr] 52 | | #[test] [INFO] [stderr] ... | [INFO] [stderr] 72 | | } [INFO] [stderr] 73 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.15s [INFO] running `"docker" "inspect" "20a677895e370daa1b8db38a032e010e433f583a5e074f818ba2be406c51145e"` [INFO] running `"docker" "rm" "-f" "20a677895e370daa1b8db38a032e010e433f583a5e074f818ba2be406c51145e"` [INFO] [stdout] 20a677895e370daa1b8db38a032e010e433f583a5e074f818ba2be406c51145e