[INFO] updating cached repository natepisarski/amalgate
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/natepisarski/amalgate
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/natepisarski/amalgate" "work/ex/clippy-test-run/sources/stable/gh/natepisarski/amalgate"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/natepisarski/amalgate'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/natepisarski/amalgate" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/natepisarski/amalgate"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/natepisarski/amalgate'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] d9f3fb145e46f22449bbb6d657ff6f587b69e92d
[INFO] sha for GitHub repo natepisarski/amalgate: d9f3fb145e46f22449bbb6d657ff6f587b69e92d
[INFO] validating manifest of natepisarski/amalgate on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of natepisarski/amalgate on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing natepisarski/amalgate
[INFO] finished frobbing natepisarski/amalgate
[INFO] frobbed toml for natepisarski/amalgate written to work/ex/clippy-test-run/sources/stable/gh/natepisarski/amalgate/Cargo.toml
[INFO] started frobbing natepisarski/amalgate
[INFO] finished frobbing natepisarski/amalgate
[INFO] frobbed toml for natepisarski/amalgate written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/natepisarski/amalgate/Cargo.toml
[INFO] crate natepisarski/amalgate has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting natepisarski/amalgate against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/natepisarski/amalgate:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b9f31883c0c922e9b807e9982a5afa01211f29336687be092437918ce8ebcf61
[INFO] running `"docker" "start" "-a" "b9f31883c0c922e9b807e9982a5afa01211f29336687be092437918ce8ebcf61"`
[INFO] [stderr]     Checking amalgate v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]  --> src/line_reader/mod.rs:1:1
[INFO] [stderr]   |
[INFO] [stderr] 1 | pub mod line_reader;
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::module_inception)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/line_reader/line_reader.rs:43:9
[INFO] [stderr]    |
[INFO] [stderr] 43 |         return FileLineCollection {lines: line_vector}
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `FileLineCollection {lines: line_vector}`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::clone::Clone`
[INFO] [stderr]  --> src/line_reader/file_line.rs:1:5
[INFO] [stderr]   |
[INFO] [stderr] 1 | use std::clone::Clone;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]  --> src/string_utility/mod.rs:1:1
[INFO] [stderr]   |
[INFO] [stderr] 1 | pub mod string_utility;
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/string_utility/string_utility.rs:29:5
[INFO] [stderr]    |
[INFO] [stderr] 29 |     return current_collection;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `current_collection`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/string_utility/string_utility.rs:39:5
[INFO] [stderr]    |
[INFO] [stderr] 39 |     return collector.clone();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `collector.clone()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/string_utility/string_utility.rs:46:5
[INFO] [stderr]    |
[INFO] [stderr] 46 |     return into_string(characters.as_slice());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `into_string(characters.as_slice())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/amalgate_functions/amalgate_reader.rs:67:9
[INFO] [stderr]    |
[INFO] [stderr] 67 |         return false;
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/amalgate_functions/amalgate_reader.rs:92:9
[INFO] [stderr]    |
[INFO] [stderr] 92 |         return (first_line_arguments, body_lines);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(first_line_arguments, body_lines)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/amalgate_functions/amalgate_reader.rs:106:9
[INFO] [stderr]     |
[INFO] [stderr] 106 | /         return Err(format!("[{}, line {}, text: |{}|]: Cannot find a valid amalgate function at point.",
[INFO] [stderr] 107 | |                            line.file_name, line.line_number, line.line_text));
[INFO] [stderr]     | |______________________________________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 106 |         Err(format!("[{}, line {}, text: |{}|]: Cannot find a valid amalgate function at point.",
[INFO] [stderr] 107 |                            line.file_name, line.line_number, line.line_text))
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/amalgate_functions/amalgate_reader.rs:122:9
[INFO] [stderr]     |
[INFO] [stderr] 122 |         return Err(format!("Another error has occurred processing amalgate functions"))
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("Another error has occurred processing amalgate functions"))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/amalgate_functions/amalgate_reader.rs:137:9
[INFO] [stderr]     |
[INFO] [stderr] 137 |         return Err(format!("Another error has occurred processing amalgate functions"))
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("Another error has occurred processing amalgate functions"))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/amalgate_functions/amalgate_reader.rs:198:9
[INFO] [stderr]     |
[INFO] [stderr] 198 |         return result_lines;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `result_lines`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/amalgate_functions/amalgate_reader.rs:205:38
[INFO] [stderr]     |
[INFO] [stderr] 205 |     pub fn transpile(filename: &str) -> () {
[INFO] [stderr]     |                                      ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/amalgate_functions/import.rs:41:9
[INFO] [stderr]    |
[INFO] [stderr] 41 |         return resultant_lines;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `resultant_lines`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/amalgate_functions/import.rs:47:9
[INFO] [stderr]    |
[INFO] [stderr] 47 |         return item.eq("import") || item.eq("imp");
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `item.eq("import") || item.eq("imp")`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]  --> src/line_reader/mod.rs:1:1
[INFO] [stderr]   |
[INFO] [stderr] 1 | pub mod line_reader;
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::module_inception)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/line_reader/line_reader.rs:43:9
[INFO] [stderr]    |
[INFO] [stderr] 43 |         return FileLineCollection {lines: line_vector}
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `FileLineCollection {lines: line_vector}`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::clone::Clone`
[INFO] [stderr]  --> src/line_reader/file_line.rs:1:5
[INFO] [stderr]   |
[INFO] [stderr] 1 | use std::clone::Clone;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]  --> src/string_utility/mod.rs:1:1
[INFO] [stderr]   |
[INFO] [stderr] 1 | pub mod string_utility;
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/string_utility/string_utility.rs:29:5
[INFO] [stderr]    |
[INFO] [stderr] 29 |     return current_collection;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `current_collection`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/string_utility/string_utility.rs:39:5
[INFO] [stderr]    |
[INFO] [stderr] 39 |     return collector.clone();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `collector.clone()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/string_utility/string_utility.rs:46:5
[INFO] [stderr]    |
[INFO] [stderr] 46 |     return into_string(characters.as_slice());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `into_string(characters.as_slice())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/amalgate_functions/amalgate_reader.rs:67:9
[INFO] [stderr]    |
[INFO] [stderr] 67 |         return false;
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/amalgate_functions/amalgate_reader.rs:92:9
[INFO] [stderr]    |
[INFO] [stderr] 92 |         return (first_line_arguments, body_lines);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(first_line_arguments, body_lines)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/amalgate_functions/amalgate_reader.rs:106:9
[INFO] [stderr]     |
[INFO] [stderr] 106 | /         return Err(format!("[{}, line {}, text: |{}|]: Cannot find a valid amalgate function at point.",
[INFO] [stderr] 107 | |                            line.file_name, line.line_number, line.line_text));
[INFO] [stderr]     | |______________________________________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 106 |         Err(format!("[{}, line {}, text: |{}|]: Cannot find a valid amalgate function at point.",
[INFO] [stderr] 107 |                            line.file_name, line.line_number, line.line_text))
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/amalgate_functions/amalgate_reader.rs:122:9
[INFO] [stderr]     |
[INFO] [stderr] 122 |         return Err(format!("Another error has occurred processing amalgate functions"))
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("Another error has occurred processing amalgate functions"))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/amalgate_functions/amalgate_reader.rs:137:9
[INFO] [stderr]     |
[INFO] [stderr] 137 |         return Err(format!("Another error has occurred processing amalgate functions"))
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("Another error has occurred processing amalgate functions"))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/amalgate_functions/amalgate_reader.rs:198:9
[INFO] [stderr]     |
[INFO] [stderr] 198 |         return result_lines;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `result_lines`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/amalgate_functions/amalgate_reader.rs:205:38
[INFO] [stderr]     |
[INFO] [stderr] 205 |     pub fn transpile(filename: &str) -> () {
[INFO] [stderr]     |                                      ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/amalgate_functions/import.rs:41:9
[INFO] [stderr]    |
[INFO] [stderr] 41 |         return resultant_lines;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `resultant_lines`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/amalgate_functions/import.rs:47:9
[INFO] [stderr]    |
[INFO] [stderr] 47 |         return item.eq("import") || item.eq("imp");
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `item.eq("import") || item.eq("imp")`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `result_lines`
[INFO] [stderr]   --> src/main.rs:12:9
[INFO] [stderr]    |
[INFO] [stderr] 12 |     let result_lines = result.read();
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: consider using `_result_lines` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable `current_multiline_function` is assigned to, but never used
[INFO] [stderr]    --> src/amalgate_functions/amalgate_reader.rs:150:17
[INFO] [stderr]     |
[INFO] [stderr] 150 |         let mut current_multiline_function: Rc<AmalgateMultilineFunction>;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: consider using `_current_multiline_function` instead
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `current_multiline_function` is never read
[INFO] [stderr]    --> src/amalgate_functions/amalgate_reader.rs:172:21
[INFO] [stderr]     |
[INFO] [stderr] 172 |                     current_multiline_function = self.get_multiline_function(&current_multiline_name);
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_assignments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `result_lines`
[INFO] [stderr]   --> src/main.rs:12:9
[INFO] [stderr]    |
[INFO] [stderr] 12 |     let result_lines = result.read();
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: consider using `_result_lines` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable `current_multiline_function` is assigned to, but never used
[INFO] [stderr]    --> src/amalgate_functions/amalgate_reader.rs:150:17
[INFO] [stderr]     |
[INFO] [stderr] 150 |         let mut current_multiline_function: Rc<AmalgateMultilineFunction>;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: consider using `_current_multiline_function` instead
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `current_multiline_function` is never read
[INFO] [stderr]    --> src/amalgate_functions/amalgate_reader.rs:172:21
[INFO] [stderr]     |
[INFO] [stderr] 172 |                     current_multiline_function = self.get_multiline_function(&current_multiline_name);
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_assignments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]   --> src/line_reader/line_reader.rs:29:16
[INFO] [stderr]    |
[INFO] [stderr] 29 |           if let Err(_) = file.read_to_string(&mut contents) {
[INFO] [stderr]    |  _________-      ^^^^^^
[INFO] [stderr] 30 | |             panic!("{} could not be read! Make sure it exists and your user has read permissions to it.", self.file_name);
[INFO] [stderr] 31 | |         }
[INFO] [stderr]    | |_________- help: try this: `if file.read_to_string(&mut contents).is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/line_reader/line_reader.rs:41:13
[INFO] [stderr]    |
[INFO] [stderr] 41 |             counter = counter + 1;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]  --> src/string_utility/string_utility.rs:3:45
[INFO] [stderr]   |
[INFO] [stderr] 3 | pub fn split<'a>(line: &'a str, split_char: &'a char) -> Vec<String> {
[INFO] [stderr]   |                                             ^^^^^^^^ help: consider passing by value instead: `char`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/string_utility/string_utility.rs:13:16
[INFO] [stderr]    |
[INFO] [stderr] 13 |             if current_string.len() > 0 {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!current_string.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]   --> src/line_reader/line_reader.rs:29:16
[INFO] [stderr]    |
[INFO] [stderr] 29 |           if let Err(_) = file.read_to_string(&mut contents) {
[INFO] [stderr]    |  _________-      ^^^^^^
[INFO] [stderr] 30 | |             panic!("{} could not be read! Make sure it exists and your user has read permissions to it.", self.file_name);
[INFO] [stderr] 31 | |         }
[INFO] [stderr]    | |_________- help: try this: `if file.read_to_string(&mut contents).is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/line_reader/line_reader.rs:41:13
[INFO] [stderr]    |
[INFO] [stderr] 41 |             counter = counter + 1;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/string_utility/string_utility.rs:26:8
[INFO] [stderr]    |
[INFO] [stderr] 26 |     if current_string.len() > 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!current_string.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/string_utility/string_utility.rs:44:43
[INFO] [stderr]    |
[INFO] [stderr] 44 | pub fn substring(line: &str, start_index: &u32, length: &u32) -> String { // [TODO]: Clean up this usize vs u8 business
[INFO] [stderr]    |                                           ^^^^ help: consider passing by value instead: `u32`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/string_utility/string_utility.rs:44:57
[INFO] [stderr]    |
[INFO] [stderr] 44 | pub fn substring(line: &str, start_index: &u32, length: &u32) -> String { // [TODO]: Clean up this usize vs u8 business
[INFO] [stderr]    |                                                         ^^^^ help: consider passing by value instead: `u32`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]  --> src/string_utility/string_utility.rs:3:45
[INFO] [stderr]   |
[INFO] [stderr] 3 | pub fn split<'a>(line: &'a str, split_char: &'a char) -> Vec<String> {
[INFO] [stderr]   |                                             ^^^^^^^^ help: consider passing by value instead: `char`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/string_utility/string_utility.rs:53:20
[INFO] [stderr]    |
[INFO] [stderr] 53 |             return character.clone();
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `character`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/string_utility/string_utility.rs:55:9
[INFO] [stderr]    |
[INFO] [stderr] 55 |         counter = counter + 1;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/string_utility/string_utility.rs:13:16
[INFO] [stderr]    |
[INFO] [stderr] 13 |             if current_string.len() > 0 {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!current_string.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/string_utility/string_utility.rs:26:8
[INFO] [stderr]    |
[INFO] [stderr] 26 |     if current_string.len() > 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!current_string.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/string_utility/string_utility.rs:44:43
[INFO] [stderr]    |
[INFO] [stderr] 44 | pub fn substring(line: &str, start_index: &u32, length: &u32) -> String { // [TODO]: Clean up this usize vs u8 business
[INFO] [stderr]    |                                           ^^^^ help: consider passing by value instead: `u32`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/string_utility/string_utility.rs:44:57
[INFO] [stderr]    |
[INFO] [stderr] 44 | pub fn substring(line: &str, start_index: &u32, length: &u32) -> String { // [TODO]: Clean up this usize vs u8 business
[INFO] [stderr]    |                                                         ^^^^ help: consider passing by value instead: `u32`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/string_utility/string_utility.rs:53:20
[INFO] [stderr]    |
[INFO] [stderr] 53 |             return character.clone();
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `character`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/string_utility/string_utility.rs:55:9
[INFO] [stderr]    |
[INFO] [stderr] 55 |         counter = counter + 1;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/amalgate_functions/amalgate.rs:9:36
[INFO] [stderr]   |
[INFO] [stderr] 9 |     fn call(&self, existing_lines: &Vec<String>, argument: Vec<String>) -> Vec<String>;
[INFO] [stderr]   |                                    ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/amalgate_functions/amalgate.rs:14:29
[INFO] [stderr]    |
[INFO] [stderr] 14 |     fn used_on(&self, name: &String) -> bool;
[INFO] [stderr]    |                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/amalgate_functions/amalgate.rs:25:36
[INFO] [stderr]    |
[INFO] [stderr] 25 |     fn call(&self, existing_lines: &Vec<String>, argument: Vec<String>, body: Vec<String>) -> Vec<String>;
[INFO] [stderr]    |                                    ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/amalgate_functions/amalgate.rs:36:29
[INFO] [stderr]    |
[INFO] [stderr] 36 |     fn used_on(&self, name: &String) -> bool;
[INFO] [stderr]    |                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/amalgate_functions/amalgate_reader.rs:29:45
[INFO] [stderr]    |
[INFO] [stderr] 29 |     pub fn get_function(&self, call_result: &String) -> Rc<AmalgateFunction> {
[INFO] [stderr]    |                                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/amalgate_functions/amalgate_reader.rs:40:55
[INFO] [stderr]    |
[INFO] [stderr] 40 |     pub fn get_multiline_function(&self, call_result: &String) -> Rc<AmalgateMultilineFunction> {
[INFO] [stderr]    |                                                       ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/amalgate_functions/amalgate_reader.rs:53:33
[INFO] [stderr]    |
[INFO] [stderr] 53 |         line.trim().starts_with("=") && !line.trim().starts_with("==")
[INFO] [stderr]    |                                 ^^^ help: try using a char instead: `'='`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]   --> src/amalgate_functions/amalgate_reader.rs:59:12
[INFO] [stderr]    |
[INFO] [stderr] 59 |         if line.len() < 1 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/amalgate_functions/amalgate.rs:9:36
[INFO] [stderr]   |
[INFO] [stderr] 9 |     fn call(&self, existing_lines: &Vec<String>, argument: Vec<String>) -> Vec<String>;
[INFO] [stderr]   |                                    ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/amalgate_functions/amalgate.rs:14:29
[INFO] [stderr]    |
[INFO] [stderr] 14 |     fn used_on(&self, name: &String) -> bool;
[INFO] [stderr]    |                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/amalgate_functions/amalgate.rs:25:36
[INFO] [stderr]    |
[INFO] [stderr] 25 |     fn call(&self, existing_lines: &Vec<String>, argument: Vec<String>, body: Vec<String>) -> Vec<String>;
[INFO] [stderr]    |                                    ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/amalgate_functions/amalgate.rs:36:29
[INFO] [stderr]    |
[INFO] [stderr] 36 |     fn used_on(&self, name: &String) -> bool;
[INFO] [stderr]    |                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/amalgate_functions/amalgate_reader.rs:114:37
[INFO] [stderr]     |
[INFO] [stderr] 114 |                 if word.starts_with("=") {
[INFO] [stderr]     |                                     ^^^ help: try using a char instead: `'='`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/amalgate_functions/amalgate_reader.rs:122:20
[INFO] [stderr]     |
[INFO] [stderr] 122 |         return Err(format!("Another error has occurred processing amalgate functions"))
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Another error has occurred processing amalgate functions".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/amalgate_functions/amalgate_reader.rs:129:37
[INFO] [stderr]     |
[INFO] [stderr] 129 |                 if word.starts_with("=") {
[INFO] [stderr]     |                                     ^^^ help: try using a char instead: `'='`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/amalgate_functions/amalgate_reader.rs:137:20
[INFO] [stderr]     |
[INFO] [stderr] 137 |         return Err(format!("Another error has occurred processing amalgate functions"))
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Another error has occurred processing amalgate functions".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/amalgate_functions/amalgate_reader.rs:29:45
[INFO] [stderr]    |
[INFO] [stderr] 29 |     pub fn get_function(&self, call_result: &String) -> Rc<AmalgateFunction> {
[INFO] [stderr]    |                                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/amalgate_functions/amalgate_reader.rs:40:55
[INFO] [stderr]    |
[INFO] [stderr] 40 |     pub fn get_multiline_function(&self, call_result: &String) -> Rc<AmalgateMultilineFunction> {
[INFO] [stderr]    |                                                       ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/amalgate_functions/amalgate_reader.rs:53:33
[INFO] [stderr]    |
[INFO] [stderr] 53 |         line.trim().starts_with("=") && !line.trim().starts_with("==")
[INFO] [stderr]    |                                 ^^^ help: try using a char instead: `'='`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]   --> src/amalgate_functions/amalgate_reader.rs:59:12
[INFO] [stderr]    |
[INFO] [stderr] 59 |         if line.len() < 1 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/amalgate_functions/amalgate_reader.rs:114:37
[INFO] [stderr]     |
[INFO] [stderr] 114 |                 if word.starts_with("=") {
[INFO] [stderr]     |                                     ^^^ help: try using a char instead: `'='`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/amalgate_functions/amalgate_reader.rs:122:20
[INFO] [stderr]     |
[INFO] [stderr] 122 |         return Err(format!("Another error has occurred processing amalgate functions"))
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Another error has occurred processing amalgate functions".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/amalgate_functions/amalgate_reader.rs:129:37
[INFO] [stderr]     |
[INFO] [stderr] 129 |                 if word.starts_with("=") {
[INFO] [stderr]     |                                     ^^^ help: try using a char instead: `'='`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/amalgate_functions/amalgate_reader.rs:137:20
[INFO] [stderr]     |
[INFO] [stderr] 137 |         return Err(format!("Another error has occurred processing amalgate functions"))
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Another error has occurred processing amalgate functions".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.93s
[INFO] running `"docker" "inspect" "b9f31883c0c922e9b807e9982a5afa01211f29336687be092437918ce8ebcf61"`
[INFO] running `"docker" "rm" "-f" "b9f31883c0c922e9b807e9982a5afa01211f29336687be092437918ce8ebcf61"`
[INFO] [stdout] b9f31883c0c922e9b807e9982a5afa01211f29336687be092437918ce8ebcf61