[INFO] updating cached repository nareshganduri/JSONParser [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nareshganduri/JSONParser [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nareshganduri/JSONParser" "work/ex/clippy-test-run/sources/stable/gh/nareshganduri/JSONParser"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nareshganduri/JSONParser'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nareshganduri/JSONParser" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nareshganduri/JSONParser"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nareshganduri/JSONParser'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 59e28a186c905471196342d1a862e1ab9261e7e9 [INFO] sha for GitHub repo nareshganduri/JSONParser: 59e28a186c905471196342d1a862e1ab9261e7e9 [INFO] validating manifest of nareshganduri/JSONParser on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nareshganduri/JSONParser on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nareshganduri/JSONParser [INFO] finished frobbing nareshganduri/JSONParser [INFO] frobbed toml for nareshganduri/JSONParser written to work/ex/clippy-test-run/sources/stable/gh/nareshganduri/JSONParser/Cargo.toml [INFO] started frobbing nareshganduri/JSONParser [INFO] finished frobbing nareshganduri/JSONParser [INFO] frobbed toml for nareshganduri/JSONParser written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nareshganduri/JSONParser/Cargo.toml [INFO] crate nareshganduri/JSONParser has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nareshganduri/JSONParser against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nareshganduri/JSONParser:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 790aecb52d93ec8d5ccfc8f5d6e6b1d5ae31cd1ec411ce24a73f507370a9f30d [INFO] running `"docker" "start" "-a" "790aecb52d93ec8d5ccfc8f5d6e6b1d5ae31cd1ec411ce24a73f507370a9f30d"` [INFO] [stderr] Checking jsonparser v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer/mod.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer/mod.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:12:18 [INFO] [stderr] | [INFO] [stderr] 12 | let result = parser.parse(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:12:18 [INFO] [stderr] | [INFO] [stderr] 12 | let result = parser.parse(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/json.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | / match self { [INFO] [stderr] 17 | | &JSON::JSONNum(ref x) => write!(f, "{}", x), [INFO] [stderr] 18 | | &JSON::JSONString(ref x) => write!(f, "\"{}\"", x), [INFO] [stderr] 19 | | &JSON::JSONNull => write!(f, "null"), [INFO] [stderr] ... | [INFO] [stderr] 40 | | } [INFO] [stderr] 41 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 16 | match *self { [INFO] [stderr] 17 | JSON::JSONNum(ref x) => write!(f, "{}", x), [INFO] [stderr] 18 | JSON::JSONString(ref x) => write!(f, "\"{}\"", x), [INFO] [stderr] 19 | JSON::JSONNull => write!(f, "null"), [INFO] [stderr] 20 | JSON::JSONBool(ref x) => write!(f, "{}", x), [INFO] [stderr] 21 | JSON::JSONArray(ref x) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lexer/mod.rs:176:63 [INFO] [stderr] | [INFO] [stderr] 176 | let code_pt = std::char::from_u32(x as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/lexer/mod.rs:191:16 [INFO] [stderr] | [INFO] [stderr] 191 | Ok(self.error(err_msg)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 191 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/json.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | / match self { [INFO] [stderr] 17 | | &JSON::JSONNum(ref x) => write!(f, "{}", x), [INFO] [stderr] 18 | | &JSON::JSONString(ref x) => write!(f, "\"{}\"", x), [INFO] [stderr] 19 | | &JSON::JSONNull => write!(f, "null"), [INFO] [stderr] ... | [INFO] [stderr] 40 | | } [INFO] [stderr] 41 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 16 | match *self { [INFO] [stderr] 17 | JSON::JSONNum(ref x) => write!(f, "{}", x), [INFO] [stderr] 18 | JSON::JSONString(ref x) => write!(f, "\"{}\"", x), [INFO] [stderr] 19 | JSON::JSONNull => write!(f, "null"), [INFO] [stderr] 20 | JSON::JSONBool(ref x) => write!(f, "{}", x), [INFO] [stderr] 21 | JSON::JSONArray(ref x) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lexer/mod.rs:176:63 [INFO] [stderr] | [INFO] [stderr] 176 | let code_pt = std::char::from_u32(x as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/lexer/mod.rs:191:16 [INFO] [stderr] | [INFO] [stderr] 191 | Ok(self.error(err_msg)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 191 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.31s [INFO] running `"docker" "inspect" "790aecb52d93ec8d5ccfc8f5d6e6b1d5ae31cd1ec411ce24a73f507370a9f30d"` [INFO] running `"docker" "rm" "-f" "790aecb52d93ec8d5ccfc8f5d6e6b1d5ae31cd1ec411ce24a73f507370a9f30d"` [INFO] [stdout] 790aecb52d93ec8d5ccfc8f5d6e6b1d5ae31cd1ec411ce24a73f507370a9f30d