[INFO] updating cached repository naim94a/warping [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/naim94a/warping [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/naim94a/warping" "work/ex/clippy-test-run/sources/stable/gh/naim94a/warping"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/naim94a/warping'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/naim94a/warping" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/naim94a/warping"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/naim94a/warping'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0da79a6d380b3cdd859a28c8b34619baf3f3fae7 [INFO] sha for GitHub repo naim94a/warping: 0da79a6d380b3cdd859a28c8b34619baf3f3fae7 [INFO] validating manifest of naim94a/warping on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of naim94a/warping on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing naim94a/warping [INFO] finished frobbing naim94a/warping [INFO] frobbed toml for naim94a/warping written to work/ex/clippy-test-run/sources/stable/gh/naim94a/warping/Cargo.toml [INFO] started frobbing naim94a/warping [INFO] finished frobbing naim94a/warping [INFO] frobbed toml for naim94a/warping written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/naim94a/warping/Cargo.toml [INFO] crate naim94a/warping has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting naim94a/warping against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/naim94a/warping:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7e8c8a24d63c05dfc277e2906676679cd0935593e574327b0aa85ba3465bddf3 [INFO] running `"docker" "start" "-a" "7e8c8a24d63c05dfc277e2906676679cd0935593e574327b0aa85ba3465bddf3"` [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking warping v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | return res; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `res` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | return Err(ret.into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ret.into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | return Ok(MacAddr::new(&buffer[0..6])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(MacAddr::new(&buffer[0..6]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | return res; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `res` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | return Err(ret.into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ret.into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | return Ok(MacAddr::new(&buffer[0..6])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(MacAddr::new(&buffer[0..6]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | return res; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `res` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | return Err(ret.into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ret.into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | return Ok(MacAddr::new(&buffer[0..6])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(MacAddr::new(&buffer[0..6]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:51:48 [INFO] [stderr] | [INFO] [stderr] 51 | let half_sec = std::time::Duration::new(0, 500000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `500_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | return res; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `res` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | return Err(ret.into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ret.into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | return Ok(MacAddr::new(&buffer[0..6])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(MacAddr::new(&buffer[0..6]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:51:48 [INFO] [stderr] | [INFO] [stderr] 51 | let half_sec = std::time::Duration::new(0, 500000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `500_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: method is never used: `octets` [INFO] [stderr] --> src/lib.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn octets(&self) -> &[u8; 6] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `octets` [INFO] [stderr] --> src/lib.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn octets(&self) -> &[u8; 6] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | / match timeout { [INFO] [stderr] 91 | | Some(timeout) => { [INFO] [stderr] 92 | | if timeout > std::time::SystemTime::now() { [INFO] [stderr] 93 | | break; [INFO] [stderr] ... | [INFO] [stderr] 96 | | None => { } [INFO] [stderr] 97 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 90 | if let Some(timeout) = timeout { [INFO] [stderr] 91 | if timeout > std::time::SystemTime::now() { [INFO] [stderr] 92 | break; [INFO] [stderr] 93 | } [INFO] [stderr] 94 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | / match timeout { [INFO] [stderr] 91 | | Some(timeout) => { [INFO] [stderr] 92 | | if timeout > std::time::SystemTime::now() { [INFO] [stderr] 93 | | break; [INFO] [stderr] ... | [INFO] [stderr] 96 | | None => { } [INFO] [stderr] 97 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 90 | if let Some(timeout) = timeout { [INFO] [stderr] 91 | if timeout > std::time::SystemTime::now() { [INFO] [stderr] 92 | break; [INFO] [stderr] 93 | } [INFO] [stderr] 94 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.68s [INFO] running `"docker" "inspect" "7e8c8a24d63c05dfc277e2906676679cd0935593e574327b0aa85ba3465bddf3"` [INFO] running `"docker" "rm" "-f" "7e8c8a24d63c05dfc277e2906676679cd0935593e574327b0aa85ba3465bddf3"` [INFO] [stdout] 7e8c8a24d63c05dfc277e2906676679cd0935593e574327b0aa85ba3465bddf3