[INFO] updating cached repository n4to4/interpreter-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/n4to4/interpreter-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/n4to4/interpreter-rs" "work/ex/clippy-test-run/sources/stable/gh/n4to4/interpreter-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/n4to4/interpreter-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/n4to4/interpreter-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/n4to4/interpreter-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/n4to4/interpreter-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 14ece5df4d2e1a7f60069af47418825a0d3bcc78 [INFO] sha for GitHub repo n4to4/interpreter-rs: 14ece5df4d2e1a7f60069af47418825a0d3bcc78 [INFO] validating manifest of n4to4/interpreter-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of n4to4/interpreter-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing n4to4/interpreter-rs [INFO] finished frobbing n4to4/interpreter-rs [INFO] frobbed toml for n4to4/interpreter-rs written to work/ex/clippy-test-run/sources/stable/gh/n4to4/interpreter-rs/Cargo.toml [INFO] started frobbing n4to4/interpreter-rs [INFO] finished frobbing n4to4/interpreter-rs [INFO] frobbed toml for n4to4/interpreter-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/n4to4/interpreter-rs/Cargo.toml [INFO] crate n4to4/interpreter-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting n4to4/interpreter-rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/n4to4/interpreter-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6e8c657b8afc2407da65d49b04de2a24b5e77ecabbda2209db177b4e07009aff [INFO] running `"docker" "start" "-a" "6e8c657b8afc2407da65d49b04de2a24b5e77ecabbda2209db177b4e07009aff"` [INFO] [stderr] Checking difference v2.0.0 [INFO] [stderr] Checking pretty_assertions v0.5.1 [INFO] [stderr] Checking interpreter v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | typ: typ, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | l: l, [INFO] [stderr] | ^^^^ help: replace it with: `l` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | typ: typ, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | l: l, [INFO] [stderr] | ^^^^ help: replace it with: `l` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Program` [INFO] [stderr] --> src/ast.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | pub struct Program { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/ast.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn new() -> Program { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `token_literal` [INFO] [stderr] --> src/ast.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | fn token_literal(&self) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Identifier` [INFO] [stderr] --> src/ast.rs:47:1 [INFO] [stderr] | [INFO] [stderr] 47 | pub struct Identifier { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `LetStatement` [INFO] [stderr] --> src/ast.rs:63:1 [INFO] [stderr] | [INFO] [stderr] 63 | pub struct LetStatement { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Parser` [INFO] [stderr] --> src/parser.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | struct Parser<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/parser.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | fn new(l: &'a mut Lexer) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `next_token` [INFO] [stderr] --> src/parser.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | fn next_token(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `parse_program` [INFO] [stderr] --> src/parser.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | fn parse_program(&mut self) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `parse_statement` [INFO] [stderr] --> src/parser.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | fn parse_statement(&mut self) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `parse_let_statement` [INFO] [stderr] --> src/parser.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | fn parse_let_statement(&mut self) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `cur_token_is` [INFO] [stderr] --> src/parser.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | fn cur_token_is(&self, t: token::TokenType) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `peek_token_is` [INFO] [stderr] --> src/parser.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | fn peek_token_is(&self, t: token::TokenType) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `expect_peek` [INFO] [stderr] --> src/parser.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | fn expect_peek(&mut self, t: token::TokenType) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ast.rs:34:12 [INFO] [stderr] | [INFO] [stderr] 34 | if self.statements.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.statements.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `ch @ _` pattern can be written as just `ch` [INFO] [stderr] --> src/lexer.rs:78:18 [INFO] [stderr] | [INFO] [stderr] 78 | Some(ch @ _) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/repl.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | writer.write(PROMPT).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/repl.rs:16:16 [INFO] [stderr] | [INFO] [stderr] 16 | if let Ok(_) = reader.read_line(&mut line) { [INFO] [stderr] | _________- ^^^^^ [INFO] [stderr] 17 | | let mut l = Lexer::new(line); [INFO] [stderr] 18 | | l.for_each(|tok| { [INFO] [stderr] 19 | | writer.write_fmt(format_args!("{:?}\n", tok)).unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 23 | | return; [INFO] [stderr] 24 | | } [INFO] [stderr] | |_________- help: try this: `if reader.read_line(&mut line).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: variant `NOT_EQ` should have a camel case name such as `NotEq` [INFO] [stderr] --> src/token.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | NOT_EQ, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `interpreter`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: method is never used: `token_literal` [INFO] [stderr] --> src/ast.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | fn token_literal(&self) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `print_if_string` [INFO] [stderr] --> src/parser.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | fn print_if_string(s: &Any) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ast.rs:34:12 [INFO] [stderr] | [INFO] [stderr] 34 | if self.statements.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.statements.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `ch @ _` pattern can be written as just `ch` [INFO] [stderr] --> src/lexer.rs:78:18 [INFO] [stderr] | [INFO] [stderr] 78 | Some(ch @ _) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/parser.rs:130:32 [INFO] [stderr] | [INFO] [stderr] 130 | fn assert_let_statement(s: &Box, name: &str) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&Statement` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/repl.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | writer.write(PROMPT).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/repl.rs:16:16 [INFO] [stderr] | [INFO] [stderr] 16 | if let Ok(_) = reader.read_line(&mut line) { [INFO] [stderr] | _________- ^^^^^ [INFO] [stderr] 17 | | let mut l = Lexer::new(line); [INFO] [stderr] 18 | | l.for_each(|tok| { [INFO] [stderr] 19 | | writer.write_fmt(format_args!("{:?}\n", tok)).unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 23 | | return; [INFO] [stderr] 24 | | } [INFO] [stderr] | |_________- help: try this: `if reader.read_line(&mut line).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: variant `NOT_EQ` should have a camel case name such as `NotEq` [INFO] [stderr] --> src/token.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | NOT_EQ, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `interpreter`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "6e8c657b8afc2407da65d49b04de2a24b5e77ecabbda2209db177b4e07009aff"` [INFO] running `"docker" "rm" "-f" "6e8c657b8afc2407da65d49b04de2a24b5e77ecabbda2209db177b4e07009aff"` [INFO] [stdout] 6e8c657b8afc2407da65d49b04de2a24b5e77ecabbda2209db177b4e07009aff