[INFO] updating cached repository n41r0j/1dv607_rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/n41r0j/1dv607_rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/n41r0j/1dv607_rust" "work/ex/clippy-test-run/sources/stable/gh/n41r0j/1dv607_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/n41r0j/1dv607_rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/n41r0j/1dv607_rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/n41r0j/1dv607_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/n41r0j/1dv607_rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 90e237c8c3618485c3522759f4a1f2577616c515 [INFO] sha for GitHub repo n41r0j/1dv607_rust: 90e237c8c3618485c3522759f4a1f2577616c515 [INFO] validating manifest of n41r0j/1dv607_rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of n41r0j/1dv607_rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing n41r0j/1dv607_rust [INFO] finished frobbing n41r0j/1dv607_rust [INFO] frobbed toml for n41r0j/1dv607_rust written to work/ex/clippy-test-run/sources/stable/gh/n41r0j/1dv607_rust/Cargo.toml [INFO] started frobbing n41r0j/1dv607_rust [INFO] finished frobbing n41r0j/1dv607_rust [INFO] frobbed toml for n41r0j/1dv607_rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/n41r0j/1dv607_rust/Cargo.toml [INFO] crate n41r0j/1dv607_rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting n41r0j/1dv607_rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/n41r0j/1dv607_rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 34e9ded3f5ee1fe44e4e5733cdb7b59dfd07804ac816204a2afa935861dfa6d5 [INFO] running `"docker" "start" "-a" "34e9ded3f5ee1fe44e4e5733cdb7b59dfd07804ac816204a2afa935861dfa6d5"` [INFO] [stderr] Checking member_register v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/view/console.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | return input [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `input` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `choice` [INFO] [stderr] --> src/view/console.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | let choice: String = self.get_input(String::from("Second question!")); [INFO] [stderr] | ^^^^^^ help: consider using `_choice` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Boat` [INFO] [stderr] --> src/model/boat.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub struct Boat { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_type` [INFO] [stderr] --> src/model/boat.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | fn get_type(&self) -> &str { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_length` [INFO] [stderr] --> src/model/boat.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | fn get_length(&self) -> &f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/view/console.rs:27:19 [INFO] [stderr] | [INFO] [stderr] 27 | match choice.trim().as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `choice.trim()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/view/console.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | return input [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `input` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `choice` [INFO] [stderr] --> src/view/console.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | let choice: String = self.get_input(String::from("Second question!")); [INFO] [stderr] | ^^^^^^ help: consider using `_choice` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Boat` [INFO] [stderr] --> src/model/boat.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub struct Boat { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_type` [INFO] [stderr] --> src/model/boat.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | fn get_type(&self) -> &str { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_length` [INFO] [stderr] --> src/model/boat.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | fn get_length(&self) -> &f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/view/console.rs:27:19 [INFO] [stderr] | [INFO] [stderr] 27 | match choice.trim().as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `choice.trim()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.69s [INFO] running `"docker" "inspect" "34e9ded3f5ee1fe44e4e5733cdb7b59dfd07804ac816204a2afa935861dfa6d5"` [INFO] running `"docker" "rm" "-f" "34e9ded3f5ee1fe44e4e5733cdb7b59dfd07804ac816204a2afa935861dfa6d5"` [INFO] [stdout] 34e9ded3f5ee1fe44e4e5733cdb7b59dfd07804ac816204a2afa935861dfa6d5