[INFO] updating cached repository n3phtys/rusty-diceware
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/n3phtys/rusty-diceware
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/n3phtys/rusty-diceware" "work/ex/clippy-test-run/sources/stable/gh/n3phtys/rusty-diceware"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/n3phtys/rusty-diceware'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/n3phtys/rusty-diceware" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/n3phtys/rusty-diceware"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/n3phtys/rusty-diceware'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 51db1a21fab1d9645d28cec5a1f04349f424634b
[INFO] sha for GitHub repo n3phtys/rusty-diceware: 51db1a21fab1d9645d28cec5a1f04349f424634b
[INFO] validating manifest of n3phtys/rusty-diceware on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of n3phtys/rusty-diceware on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing n3phtys/rusty-diceware
[INFO] finished frobbing n3phtys/rusty-diceware
[INFO] frobbed toml for n3phtys/rusty-diceware written to work/ex/clippy-test-run/sources/stable/gh/n3phtys/rusty-diceware/Cargo.toml
[INFO] started frobbing n3phtys/rusty-diceware
[INFO] finished frobbing n3phtys/rusty-diceware
[INFO] frobbed toml for n3phtys/rusty-diceware written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/n3phtys/rusty-diceware/Cargo.toml
[INFO] crate n3phtys/rusty-diceware has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting n3phtys/rusty-diceware against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/n3phtys/rusty-diceware:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] c56cc2191cb37264426113777164538e4a284f45ebc141b8708a565e17d62c29
[INFO] running `"docker" "start" "-a" "c56cc2191cb37264426113777164538e4a284f45ebc141b8708a565e17d62c29"`
[INFO] [stderr]     Checking dice-me v0.1.1 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/list.rs:6:5
[INFO] [stderr]   |
[INFO] [stderr] 6 |     return r;
[INFO] [stderr]   |     ^^^^^^^^^ help: remove `return` as shown: `r`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/dice.rs:5:5
[INFO] [stderr]   |
[INFO] [stderr] 5 |     return [(rng.next_u32() % 6) as u8, (rng.next_u32() % 6) as u8, (rng.next_u32() % 6) as u8, (rng.next_u32() % 6) as u8];
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[(rng.next_u32() % 6) as u8, (rng.next_u32() % 6) as u8, (rng.next_u32() % 6) as u8, (rng.next_u32() % 6) as u8]`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/dice.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 |     return a * pow(6, 3) + b * pow(6, 2) + c * pow(6, 1) + d;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `a * pow(6, 3) + b * pow(6, 2) + c * pow(6, 1) + d`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/dice.rs:23:5
[INFO] [stderr]    |
[INFO] [stderr] 23 |     return r as usize;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `r as usize`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/main.rs:40:72
[INFO] [stderr]    |
[INFO] [stderr] 40 | fn build_diceware_password(rng : &mut OsRng, n: u32, list: &Vec<&str>) -> () {
[INFO] [stderr]    |                                                                        ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/list.rs:6:5
[INFO] [stderr]   |
[INFO] [stderr] 6 |     return r;
[INFO] [stderr]   |     ^^^^^^^^^ help: remove `return` as shown: `r`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/dice.rs:5:5
[INFO] [stderr]   |
[INFO] [stderr] 5 |     return [(rng.next_u32() % 6) as u8, (rng.next_u32() % 6) as u8, (rng.next_u32() % 6) as u8, (rng.next_u32() % 6) as u8];
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[(rng.next_u32() % 6) as u8, (rng.next_u32() % 6) as u8, (rng.next_u32() % 6) as u8, (rng.next_u32() % 6) as u8]`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/dice.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 |     return a * pow(6, 3) + b * pow(6, 2) + c * pow(6, 1) + d;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `a * pow(6, 3) + b * pow(6, 2) + c * pow(6, 1) + d`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/dice.rs:23:5
[INFO] [stderr]    |
[INFO] [stderr] 23 |     return r as usize;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `r as usize`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/main.rs:40:72
[INFO] [stderr]    |
[INFO] [stderr] 40 | fn build_diceware_password(rng : &mut OsRng, n: u32, list: &Vec<&str>) -> () {
[INFO] [stderr]    |                                                                        ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]  --> src/list.rs:5:34
[INFO] [stderr]   |
[INFO] [stderr] 5 |     let r: Vec<&str> = str.split("\n").collect::<Vec<&str>>();
[INFO] [stderr]   |                                  ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/dice.rs:20:9
[INFO] [stderr]    |
[INFO] [stderr] 20 |         r = r * (x as u32);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^ help: replace it with: `r *= (x as u32)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:40:60
[INFO] [stderr]    |
[INFO] [stderr] 40 | fn build_diceware_password(rng : &mut OsRng, n: u32, list: &Vec<&str>) -> () {
[INFO] [stderr]    |                                                            ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]  --> src/list.rs:5:34
[INFO] [stderr]   |
[INFO] [stderr] 5 |     let r: Vec<&str> = str.split("\n").collect::<Vec<&str>>();
[INFO] [stderr]   |                                  ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/dice.rs:20:9
[INFO] [stderr]    |
[INFO] [stderr] 20 |         r = r * (x as u32);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^ help: replace it with: `r *= (x as u32)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:40:60
[INFO] [stderr]    |
[INFO] [stderr] 40 | fn build_diceware_password(rng : &mut OsRng, n: u32, list: &Vec<&str>) -> () {
[INFO] [stderr]    |                                                            ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.79s
[INFO] running `"docker" "inspect" "c56cc2191cb37264426113777164538e4a284f45ebc141b8708a565e17d62c29"`
[INFO] running `"docker" "rm" "-f" "c56cc2191cb37264426113777164538e4a284f45ebc141b8708a565e17d62c29"`
[INFO] [stdout] c56cc2191cb37264426113777164538e4a284f45ebc141b8708a565e17d62c29