[INFO] updating cached repository mz2212/irondice
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/mz2212/irondice
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/mz2212/irondice" "work/ex/clippy-test-run/sources/stable/gh/mz2212/irondice"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mz2212/irondice'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/mz2212/irondice" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mz2212/irondice"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mz2212/irondice'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 26b175df7c92050b2ac74b69a7f151568b0e58ae
[INFO] sha for GitHub repo mz2212/irondice: 26b175df7c92050b2ac74b69a7f151568b0e58ae
[INFO] validating manifest of mz2212/irondice on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of mz2212/irondice on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing mz2212/irondice
[INFO] finished frobbing mz2212/irondice
[INFO] frobbed toml for mz2212/irondice written to work/ex/clippy-test-run/sources/stable/gh/mz2212/irondice/Cargo.toml
[INFO] started frobbing mz2212/irondice
[INFO] finished frobbing mz2212/irondice
[INFO] frobbed toml for mz2212/irondice written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mz2212/irondice/Cargo.toml
[INFO] crate mz2212/irondice has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting mz2212/irondice against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mz2212/irondice:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 433afcaea201db235d7222570b257a86addb986fca43ff97e25e8a13a6705250
[INFO] running `"docker" "start" "-a" "433afcaea201db235d7222570b257a86addb986fca43ff97e25e8a13a6705250"`
[INFO] [stderr]     Checking memchr v1.0.2
[INFO] [stderr]     Checking atty v0.2.6
[INFO] [stderr]     Checking clap v2.30.0
[INFO] [stderr]     Checking csv-core v0.1.3
[INFO] [stderr]     Checking csv v1.0.0-beta.5
[INFO] [stderr]     Checking irondice v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/main.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 | /     let len;
[INFO] [stderr] 20 | |     if matches.is_present("length") {
[INFO] [stderr] 21 | |         len = matches.value_of("length").unwrap().parse::<i8>().unwrap();
[INFO] [stderr] 22 | |     } else {
[INFO] [stderr] 23 | |         len = 6;
[INFO] [stderr] 24 | |     }
[INFO] [stderr]    | |_____^ help: it is more idiomatic to write: `let len = if matches.is_present("length") { matches.value_of("length").unwrap().parse::<i8>().unwrap() } else { 6 };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/main.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 | /     let mut path = PathBuf::new();
[INFO] [stderr] 26 | |     if matches.is_present("wordlist") {
[INFO] [stderr] 27 | |         path = PathBuf::from(matches.value_of("wordlist").unwrap());
[INFO] [stderr] 28 | |     } else {
[INFO] [stderr] 29 | |         path.push(std::env::current_exe().unwrap());
[INFO] [stderr] 30 | |         path.set_file_name("eff_large_wordlist.tsv");
[INFO] [stderr] 31 | |     }
[INFO] [stderr]    | |_____^ help: it is more idiomatic to write: `let <mut> path = if matches.is_present("wordlist") { PathBuf::from(matches.value_of("wordlist").unwrap()) } else { ..; PathBuf::new() };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: you might not need `mut` at all
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/main.rs:39:14
[INFO] [stderr]    |
[INFO] [stderr] 39 |     for i in 1..(len + 1) {
[INFO] [stderr]    |              ^^^^^^^^^^^^ help: use: `1..=len`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]   --> src/main.rs:46:16
[INFO] [stderr]    |
[INFO] [stderr] 46 |             if record.get(0).unwrap() == &curr_num {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^---------
[INFO] [stderr]    |                                          |
[INFO] [stderr]    |                                          help: use the right value directly: `curr_num`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/main.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 | /     let len;
[INFO] [stderr] 20 | |     if matches.is_present("length") {
[INFO] [stderr] 21 | |         len = matches.value_of("length").unwrap().parse::<i8>().unwrap();
[INFO] [stderr] 22 | |     } else {
[INFO] [stderr] 23 | |         len = 6;
[INFO] [stderr] 24 | |     }
[INFO] [stderr]    | |_____^ help: it is more idiomatic to write: `let len = if matches.is_present("length") { matches.value_of("length").unwrap().parse::<i8>().unwrap() } else { 6 };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/main.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 | /     let mut path = PathBuf::new();
[INFO] [stderr] 26 | |     if matches.is_present("wordlist") {
[INFO] [stderr] 27 | |         path = PathBuf::from(matches.value_of("wordlist").unwrap());
[INFO] [stderr] 28 | |     } else {
[INFO] [stderr] 29 | |         path.push(std::env::current_exe().unwrap());
[INFO] [stderr] 30 | |         path.set_file_name("eff_large_wordlist.tsv");
[INFO] [stderr] 31 | |     }
[INFO] [stderr]    | |_____^ help: it is more idiomatic to write: `let <mut> path = if matches.is_present("wordlist") { PathBuf::from(matches.value_of("wordlist").unwrap()) } else { ..; PathBuf::new() };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: you might not need `mut` at all
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/main.rs:39:14
[INFO] [stderr]    |
[INFO] [stderr] 39 |     for i in 1..(len + 1) {
[INFO] [stderr]    |              ^^^^^^^^^^^^ help: use: `1..=len`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]   --> src/main.rs:46:16
[INFO] [stderr]    |
[INFO] [stderr] 46 |             if record.get(0).unwrap() == &curr_num {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^---------
[INFO] [stderr]    |                                          |
[INFO] [stderr]    |                                          help: use the right value directly: `curr_num`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 8.12s
[INFO] running `"docker" "inspect" "433afcaea201db235d7222570b257a86addb986fca43ff97e25e8a13a6705250"`
[INFO] running `"docker" "rm" "-f" "433afcaea201db235d7222570b257a86addb986fca43ff97e25e8a13a6705250"`
[INFO] [stdout] 433afcaea201db235d7222570b257a86addb986fca43ff97e25e8a13a6705250