[INFO] updating cached repository myuon/ruyt [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/myuon/ruyt [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/myuon/ruyt" "work/ex/clippy-test-run/sources/stable/gh/myuon/ruyt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/myuon/ruyt'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/myuon/ruyt" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/myuon/ruyt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/myuon/ruyt'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8542a3c2e8058f94148ffb407187fdde3d95a357 [INFO] sha for GitHub repo myuon/ruyt: 8542a3c2e8058f94148ffb407187fdde3d95a357 [INFO] validating manifest of myuon/ruyt on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of myuon/ruyt on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing myuon/ruyt [INFO] finished frobbing myuon/ruyt [INFO] frobbed toml for myuon/ruyt written to work/ex/clippy-test-run/sources/stable/gh/myuon/ruyt/Cargo.toml [INFO] started frobbing myuon/ruyt [INFO] finished frobbing myuon/ruyt [INFO] frobbed toml for myuon/ruyt written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/myuon/ruyt/Cargo.toml [INFO] crate myuon/ruyt has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting myuon/ruyt against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/myuon/ruyt:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] aa800c3fc1971758e324b34b0eab47de966ef15b769da0af6185c5615adea61f [INFO] running `"docker" "start" "-a" "aa800c3fc1971758e324b34b0eab47de966ef15b769da0af6185c5615adea61f"` [INFO] [stderr] Checking rand v0.5.4 [INFO] [stderr] Checking ruyt v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/materials.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | is_scattered: is_scattered, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_scattered` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/materials.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | albedo: albedo, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `albedo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/materials.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | albedo: albedo, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `albedo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/figures.rs:27:25 [INFO] [stderr] | [INFO] [stderr] 27 | at: at, [INFO] [stderr] | ^^^^^^ help: replace it with: `at` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/figures.rs:28:25 [INFO] [stderr] | [INFO] [stderr] 28 | point: point, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/figures.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | center: center, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `center` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/figures.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | radius: radius, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/materials.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | is_scattered: is_scattered, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_scattered` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/materials.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | albedo: albedo, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `albedo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/materials.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | albedo: albedo, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `albedo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/figures.rs:27:25 [INFO] [stderr] | [INFO] [stderr] 27 | at: at, [INFO] [stderr] | ^^^^^^ help: replace it with: `at` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/figures.rs:28:25 [INFO] [stderr] | [INFO] [stderr] 28 | point: point, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/figures.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | center: center, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `center` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/figures.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | radius: radius, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/vector.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | pub fn new(v: V3) -> V3U { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `as_V3` [INFO] [stderr] --> src/vector.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | pub fn as_V3(self) -> V3 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `x` [INFO] [stderr] --> src/vector.rs:103:5 [INFO] [stderr] | [INFO] [stderr] 103 | pub fn x(&self) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `y` [INFO] [stderr] --> src/vector.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | pub fn y(&self) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `z` [INFO] [stderr] --> src/vector.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | pub fn z(&self) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/vector.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | pub fn new(v: V3) -> V3U { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `as_V3` [INFO] [stderr] --> src/vector.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | pub fn as_V3(self) -> V3 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `x` [INFO] [stderr] --> src/vector.rs:103:5 [INFO] [stderr] | [INFO] [stderr] 103 | pub fn x(&self) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `y` [INFO] [stderr] --> src/vector.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | pub fn y(&self) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `z` [INFO] [stderr] --> src/vector.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | pub fn z(&self) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method `as_V3` should have a snake case name such as `as_v3` [INFO] [stderr] --> src/vector.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | / pub fn as_V3(self) -> V3 { [INFO] [stderr] 100 | | self.0 [INFO] [stderr] 101 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: method `as_V3` should have a snake case name such as `as_v3` [INFO] [stderr] --> src/vector.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | / pub fn as_V3(self) -> V3 { [INFO] [stderr] 100 | | self.0 [INFO] [stderr] 101 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/figures.rs:36:51 [INFO] [stderr] | [INFO] [stderr] 36 | check((-b - discriminant.sqrt()) / a).or(check((-b + discriminant.sqrt()) / a)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| check((-b + discriminant.sqrt()) / a))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/figures.rs:36:51 [INFO] [stderr] | [INFO] [stderr] 36 | check((-b - discriminant.sqrt()) / a).or(check((-b + discriminant.sqrt()) / a)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| check((-b + discriminant.sqrt()) / a))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | f.write(format!("P3\n{} {}\n255\n", self.width, self.height).as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:63:17 [INFO] [stderr] | [INFO] [stderr] 63 | / f.write(format!( [INFO] [stderr] 64 | | "{} {} {}\n", [INFO] [stderr] 65 | | c.red(), [INFO] [stderr] 66 | | c.green(), [INFO] [stderr] 67 | | c.blue(), [INFO] [stderr] 68 | | ).as_bytes()).unwrap(); [INFO] [stderr] | |______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | f.write(format!("P3\n{} {}\n255\n", self.width, self.height).as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:63:17 [INFO] [stderr] | [INFO] [stderr] 63 | / f.write(format!( [INFO] [stderr] 64 | | "{} {} {}\n", [INFO] [stderr] 65 | | c.red(), [INFO] [stderr] 66 | | c.green(), [INFO] [stderr] 67 | | c.blue(), [INFO] [stderr] 68 | | ).as_bytes()).unwrap(); [INFO] [stderr] | |______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `ruyt`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: Could not compile `ruyt`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "aa800c3fc1971758e324b34b0eab47de966ef15b769da0af6185c5615adea61f"` [INFO] running `"docker" "rm" "-f" "aa800c3fc1971758e324b34b0eab47de966ef15b769da0af6185c5615adea61f"` [INFO] [stdout] aa800c3fc1971758e324b34b0eab47de966ef15b769da0af6185c5615adea61f