[INFO] updating cached repository mwilliamson/rewrite-c-strings
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/mwilliamson/rewrite-c-strings
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/mwilliamson/rewrite-c-strings" "work/ex/clippy-test-run/sources/stable/gh/mwilliamson/rewrite-c-strings"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mwilliamson/rewrite-c-strings'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/mwilliamson/rewrite-c-strings" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mwilliamson/rewrite-c-strings"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mwilliamson/rewrite-c-strings'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 51f69f60bcdd708223cdc363817b5ae153f003c3
[INFO] sha for GitHub repo mwilliamson/rewrite-c-strings: 51f69f60bcdd708223cdc363817b5ae153f003c3
[INFO] validating manifest of mwilliamson/rewrite-c-strings on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of mwilliamson/rewrite-c-strings on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing mwilliamson/rewrite-c-strings
[INFO] finished frobbing mwilliamson/rewrite-c-strings
[INFO] frobbed toml for mwilliamson/rewrite-c-strings written to work/ex/clippy-test-run/sources/stable/gh/mwilliamson/rewrite-c-strings/Cargo.toml
[INFO] started frobbing mwilliamson/rewrite-c-strings
[INFO] finished frobbing mwilliamson/rewrite-c-strings
[INFO] frobbed toml for mwilliamson/rewrite-c-strings written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mwilliamson/rewrite-c-strings/Cargo.toml
[INFO] crate mwilliamson/rewrite-c-strings has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting mwilliamson/rewrite-c-strings against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mwilliamson/rewrite-c-strings:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 7f9b5e5f85b108d4e7356a255fd191e8428020173b5d7bb67e8f82a5608e4648
[INFO] running `"docker" "start" "-a" "7f9b5e5f85b108d4e7356a255fd191e8428020173b5d7bb67e8f82a5608e4648"`
[INFO] [stderr]     Checking unicode-segmentation v1.0.1
[INFO] [stderr]     Checking memmap v0.5.0
[INFO] [stderr]     Checking clap v2.20.0
[INFO] [stderr]     Checking rewrite-c-strings v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:100:9
[INFO] [stderr]     |
[INFO] [stderr] 100 |         return Vec::from(value);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::from(value)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `new_index` is only used to index `new`.
[INFO] [stderr]   --> src/main.rs:37:30
[INFO] [stderr]    |
[INFO] [stderr] 37 |             for new_index in 0..new_len {
[INFO] [stderr]    |                              ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 37 |             for <item> in new.iter().take(new_len) {
[INFO] [stderr]    |                 ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `new_index` is only used to index `new`.
[INFO] [stderr]   --> src/main.rs:37:30
[INFO] [stderr]    |
[INFO] [stderr] 37 |             for new_index in 0..new_len {
[INFO] [stderr]    |                              ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 37 |             for <item> in new.iter().take(new_len) {
[INFO] [stderr]    |                 ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this call to `as_mut` does nothing
[INFO] [stderr]   --> src/main.rs:62:33
[INFO] [stderr]    |
[INFO] [stderr] 62 |         replace(b"old", b"new", buffer.as_mut());
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^ help: try this: `buffer`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_asref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 7.64s
[INFO] running `"docker" "inspect" "7f9b5e5f85b108d4e7356a255fd191e8428020173b5d7bb67e8f82a5608e4648"`
[INFO] running `"docker" "rm" "-f" "7f9b5e5f85b108d4e7356a255fd191e8428020173b5d7bb67e8f82a5608e4648"`
[INFO] [stdout] 7f9b5e5f85b108d4e7356a255fd191e8428020173b5d7bb67e8f82a5608e4648