[INFO] updating cached repository mvukic/brainfuck [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mvukic/brainfuck [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mvukic/brainfuck" "work/ex/clippy-test-run/sources/stable/gh/mvukic/brainfuck"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mvukic/brainfuck'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mvukic/brainfuck" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mvukic/brainfuck"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mvukic/brainfuck'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 69f047d797496296d85903217b585a88ac7e9f9a [INFO] sha for GitHub repo mvukic/brainfuck: 69f047d797496296d85903217b585a88ac7e9f9a [INFO] validating manifest of mvukic/brainfuck on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mvukic/brainfuck on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mvukic/brainfuck [INFO] finished frobbing mvukic/brainfuck [INFO] frobbed toml for mvukic/brainfuck written to work/ex/clippy-test-run/sources/stable/gh/mvukic/brainfuck/Cargo.toml [INFO] started frobbing mvukic/brainfuck [INFO] finished frobbing mvukic/brainfuck [INFO] frobbed toml for mvukic/brainfuck written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mvukic/brainfuck/Cargo.toml [INFO] crate mvukic/brainfuck has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mvukic/brainfuck against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mvukic/brainfuck:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d7a1f445cc9bf97288c1de97067701e60af283e9409293059f0294e56242ad1b [INFO] running `"docker" "start" "-a" "d7a1f445cc9bf97288c1de97067701e60af283e9409293059f0294e56242ad1b"` [INFO] [stderr] Checking brainfuck v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:165:5 [INFO] [stderr] | [INFO] [stderr] 165 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:165:5 [INFO] [stderr] | [INFO] [stderr] 165 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/main.rs:112:42 [INFO] [stderr] | [INFO] [stderr] 112 | let &(_, position) = brackets [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 113 | | .iter() [INFO] [stderr] 114 | | .filter(|x| x.0 == program_counter) [INFO] [stderr] 115 | | .next() [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|x| x.0 == program_counter).next()` with `find(|x| x.0 == program_counter)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/main.rs:124:41 [INFO] [stderr] | [INFO] [stderr] 124 | let &(position,_) = brackets [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 125 | | .iter() [INFO] [stderr] 126 | | .filter(|x| x.1 == program_counter) [INFO] [stderr] 127 | | .next() [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: replace `filter(|x| x.1 == program_counter).next()` with `find(|x| x.1 == program_counter)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/main.rs:112:42 [INFO] [stderr] | [INFO] [stderr] 112 | let &(_, position) = brackets [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 113 | | .iter() [INFO] [stderr] 114 | | .filter(|x| x.0 == program_counter) [INFO] [stderr] 115 | | .next() [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|x| x.0 == program_counter).next()` with `find(|x| x.0 == program_counter)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/main.rs:124:41 [INFO] [stderr] | [INFO] [stderr] 124 | let &(position,_) = brackets [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 125 | | .iter() [INFO] [stderr] 126 | | .filter(|x| x.1 == program_counter) [INFO] [stderr] 127 | | .next() [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: replace `filter(|x| x.1 == program_counter).next()` with `find(|x| x.1 == program_counter)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.87s [INFO] running `"docker" "inspect" "d7a1f445cc9bf97288c1de97067701e60af283e9409293059f0294e56242ad1b"` [INFO] running `"docker" "rm" "-f" "d7a1f445cc9bf97288c1de97067701e60af283e9409293059f0294e56242ad1b"` [INFO] [stdout] d7a1f445cc9bf97288c1de97067701e60af283e9409293059f0294e56242ad1b