[INFO] updating cached repository murphym18/rust-reverse-string
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/murphym18/rust-reverse-string
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/murphym18/rust-reverse-string" "work/ex/clippy-test-run/sources/stable/gh/murphym18/rust-reverse-string"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/murphym18/rust-reverse-string'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/murphym18/rust-reverse-string" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/murphym18/rust-reverse-string"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/murphym18/rust-reverse-string'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 3b0717d7f8acbf828748558023cf782ffd58dadb
[INFO] sha for GitHub repo murphym18/rust-reverse-string: 3b0717d7f8acbf828748558023cf782ffd58dadb
[INFO] validating manifest of murphym18/rust-reverse-string on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of murphym18/rust-reverse-string on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing murphym18/rust-reverse-string
[INFO] finished frobbing murphym18/rust-reverse-string
[INFO] frobbed toml for murphym18/rust-reverse-string written to work/ex/clippy-test-run/sources/stable/gh/murphym18/rust-reverse-string/Cargo.toml
[INFO] started frobbing murphym18/rust-reverse-string
[INFO] finished frobbing murphym18/rust-reverse-string
[INFO] frobbed toml for murphym18/rust-reverse-string written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/murphym18/rust-reverse-string/Cargo.toml
[INFO] crate murphym18/rust-reverse-string has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting murphym18/rust-reverse-string against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/murphym18/rust-reverse-string:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 2d4113996f2171f8bc1ed8b56dd90846928170e455ab9db7bbb12b8c85c01a4c
[INFO] running `"docker" "start" "-a" "2d4113996f2171f8bc1ed8b56dd90846928170e455ab9db7bbb12b8c85c01a4c"`
[INFO] [stderr]     Checking reverse_string v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:14:15
[INFO] [stderr]    |
[INFO] [stderr] 14 | fn reverse(s: &String) -> String {
[INFO] [stderr]    |               ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 14 | fn reverse(s: &str) -> String {
[INFO] [stderr]    |               ^^^^
[INFO] [stderr] help: change `s.as_str()` to
[INFO] [stderr]    |
[INFO] [stderr] 15 |     let mut tmp = String::from(s);
[INFO] [stderr]    |                                ^
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]   --> src/main.rs:18:5
[INFO] [stderr]    |
[INFO] [stderr] 18 | /     loop {
[INFO] [stderr] 19 | |         match tmp.pop() {
[INFO] [stderr] 20 | |             Some(c) => {
[INFO] [stderr] 21 | |                 result.push(c);
[INFO] [stderr] ...  |
[INFO] [stderr] 26 | |         }
[INFO] [stderr] 27 | |     }
[INFO] [stderr]    | |_____^ help: try: `while let Some(c) = tmp.pop() { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:14:15
[INFO] [stderr]    |
[INFO] [stderr] 14 | fn reverse(s: &String) -> String {
[INFO] [stderr]    |               ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 14 | fn reverse(s: &str) -> String {
[INFO] [stderr]    |               ^^^^
[INFO] [stderr] help: change `s.as_str()` to
[INFO] [stderr]    |
[INFO] [stderr] 15 |     let mut tmp = String::from(s);
[INFO] [stderr]    |                                ^
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]   --> src/main.rs:18:5
[INFO] [stderr]    |
[INFO] [stderr] 18 | /     loop {
[INFO] [stderr] 19 | |         match tmp.pop() {
[INFO] [stderr] 20 | |             Some(c) => {
[INFO] [stderr] 21 | |                 result.push(c);
[INFO] [stderr] ...  |
[INFO] [stderr] 26 | |         }
[INFO] [stderr] 27 | |     }
[INFO] [stderr]    | |_____^ help: try: `while let Some(c) = tmp.pop() { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.38s
[INFO] running `"docker" "inspect" "2d4113996f2171f8bc1ed8b56dd90846928170e455ab9db7bbb12b8c85c01a4c"`
[INFO] running `"docker" "rm" "-f" "2d4113996f2171f8bc1ed8b56dd90846928170e455ab9db7bbb12b8c85c01a4c"`
[INFO] [stdout] 2d4113996f2171f8bc1ed8b56dd90846928170e455ab9db7bbb12b8c85c01a4c