[INFO] updating cached repository muranoya/CubaLibre [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/muranoya/CubaLibre [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/muranoya/CubaLibre" "work/ex/clippy-test-run/sources/stable/gh/muranoya/CubaLibre"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/muranoya/CubaLibre'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/muranoya/CubaLibre" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/muranoya/CubaLibre"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/muranoya/CubaLibre'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f0994d8fef090c1831e844a32cf52edc867e32ad [INFO] sha for GitHub repo muranoya/CubaLibre: f0994d8fef090c1831e844a32cf52edc867e32ad [INFO] validating manifest of muranoya/CubaLibre on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of muranoya/CubaLibre on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing muranoya/CubaLibre [INFO] finished frobbing muranoya/CubaLibre [INFO] frobbed toml for muranoya/CubaLibre written to work/ex/clippy-test-run/sources/stable/gh/muranoya/CubaLibre/Cargo.toml [INFO] started frobbing muranoya/CubaLibre [INFO] finished frobbing muranoya/CubaLibre [INFO] frobbed toml for muranoya/CubaLibre written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/muranoya/CubaLibre/Cargo.toml [INFO] crate muranoya/CubaLibre has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting muranoya/CubaLibre against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/muranoya/CubaLibre:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 365d86009c51051290c74bb16547d5c3aed7e19b558727b9a83612d07807a2a3 [INFO] running `"docker" "start" "-a" "365d86009c51051290c74bb16547d5c3aed7e19b558727b9a83612d07807a2a3"` [INFO] [stderr] Checking cuba_libre v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | let _ = write!(f, "{} {} {}\r\n", self.method, self.uri, self.version); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:67:21 [INFO] [stderr] | [INFO] [stderr] 67 | let _ = write!(f, "{}: {}\r\n", k, v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:69:17 [INFO] [stderr] | [INFO] [stderr] 69 | let _ = write!(f, "\r\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:214:9 [INFO] [stderr] | [INFO] [stderr] 214 | body: body, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | let _ = write!(f, "{} {} {}\r\n", self.method, self.uri, self.version); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:67:21 [INFO] [stderr] | [INFO] [stderr] 67 | let _ = write!(f, "{}: {}\r\n", k, v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:69:17 [INFO] [stderr] | [INFO] [stderr] 69 | let _ = write!(f, "\r\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:214:9 [INFO] [stderr] | [INFO] [stderr] 214 | body: body, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `Shutdown` [INFO] [stderr] --> src/main.rs:2:40 [INFO] [stderr] | [INFO] [stderr] 2 | use std::net::{TcpListener, TcpStream, Shutdown}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `Http` [INFO] [stderr] --> src/main.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | / enum HttpVersion { [INFO] [stderr] 40 | | Http0_9, [INFO] [stderr] 41 | | Http1_0, [INFO] [stderr] 42 | | Http1_1, [INFO] [stderr] 43 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/main.rs:103:16 [INFO] [stderr] | [INFO] [stderr] 103 | fn set_options(args:&mut env::Args) -> Result { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Shutdown` [INFO] [stderr] --> src/main.rs:2:40 [INFO] [stderr] | [INFO] [stderr] 2 | use std::net::{TcpListener, TcpStream, Shutdown}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `Http` [INFO] [stderr] --> src/main.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | / enum HttpVersion { [INFO] [stderr] 40 | | Http0_9, [INFO] [stderr] 41 | | Http1_0, [INFO] [stderr] 42 | | Http1_1, [INFO] [stderr] 43 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: field is never used: `verbose` [INFO] [stderr] --> src/main.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | verbose: i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `print_usage` [INFO] [stderr] --> src/main.rs:99:1 [INFO] [stderr] | [INFO] [stderr] 99 | fn print_usage(args:&mut env::Args) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:25:25 [INFO] [stderr] | [INFO] [stderr] 25 | write!(f, "{}", match self { [INFO] [stderr] | _________________________^ [INFO] [stderr] 26 | | &HttpMethod::GET => "GET", [INFO] [stderr] 27 | | &HttpMethod::POST => "POST", [INFO] [stderr] 28 | | &HttpMethod::HEAD => "HEAD", [INFO] [stderr] ... | [INFO] [stderr] 33 | | &HttpMethod::PATCH => "PATCH", [INFO] [stderr] 34 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 25 | write!(f, "{}", match *self { [INFO] [stderr] 26 | HttpMethod::GET => "GET", [INFO] [stderr] 27 | HttpMethod::POST => "POST", [INFO] [stderr] 28 | HttpMethod::HEAD => "HEAD", [INFO] [stderr] 29 | HttpMethod::OPTIONS => "OPTIONS", [INFO] [stderr] 30 | HttpMethod::PUT => "PUT", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:47:25 [INFO] [stderr] | [INFO] [stderr] 47 | write!(f, "{}", match self { [INFO] [stderr] | _________________________^ [INFO] [stderr] 48 | | &HttpVersion::Http0_9 => "", [INFO] [stderr] 49 | | &HttpVersion::Http1_0 => "HTTP/1.0", [INFO] [stderr] 50 | | &HttpVersion::Http1_1 => "HTTP/1.1", [INFO] [stderr] 51 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 47 | write!(f, "{}", match *self { [INFO] [stderr] 48 | HttpVersion::Http0_9 => "", [INFO] [stderr] 49 | HttpVersion::Http1_0 => "HTTP/1.0", [INFO] [stderr] 50 | HttpVersion::Http1_1 => "HTTP/1.1", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `heads`. [INFO] [stderr] --> src/main.rs:199:14 [INFO] [stderr] | [INFO] [stderr] 199 | for i in 1..heads.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 199 | for in heads.iter().skip(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:200:12 [INFO] [stderr] | [INFO] [stderr] 200 | if heads[i].len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!heads[i].is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:257:21 [INFO] [stderr] | [INFO] [stderr] 257 | sendrecv_data(req, sock); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/main.rs:103:16 [INFO] [stderr] | [INFO] [stderr] 103 | fn set_options(args:&mut env::Args) -> Result { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `verbose` [INFO] [stderr] --> src/main.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | verbose: i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `print_usage` [INFO] [stderr] --> src/main.rs:99:1 [INFO] [stderr] | [INFO] [stderr] 99 | fn print_usage(args:&mut env::Args) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:25:25 [INFO] [stderr] | [INFO] [stderr] 25 | write!(f, "{}", match self { [INFO] [stderr] | _________________________^ [INFO] [stderr] 26 | | &HttpMethod::GET => "GET", [INFO] [stderr] 27 | | &HttpMethod::POST => "POST", [INFO] [stderr] 28 | | &HttpMethod::HEAD => "HEAD", [INFO] [stderr] ... | [INFO] [stderr] 33 | | &HttpMethod::PATCH => "PATCH", [INFO] [stderr] 34 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 25 | write!(f, "{}", match *self { [INFO] [stderr] 26 | HttpMethod::GET => "GET", [INFO] [stderr] 27 | HttpMethod::POST => "POST", [INFO] [stderr] 28 | HttpMethod::HEAD => "HEAD", [INFO] [stderr] 29 | HttpMethod::OPTIONS => "OPTIONS", [INFO] [stderr] 30 | HttpMethod::PUT => "PUT", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:47:25 [INFO] [stderr] | [INFO] [stderr] 47 | write!(f, "{}", match self { [INFO] [stderr] | _________________________^ [INFO] [stderr] 48 | | &HttpVersion::Http0_9 => "", [INFO] [stderr] 49 | | &HttpVersion::Http1_0 => "HTTP/1.0", [INFO] [stderr] 50 | | &HttpVersion::Http1_1 => "HTTP/1.1", [INFO] [stderr] 51 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 47 | write!(f, "{}", match *self { [INFO] [stderr] 48 | HttpVersion::Http0_9 => "", [INFO] [stderr] 49 | HttpVersion::Http1_0 => "HTTP/1.0", [INFO] [stderr] 50 | HttpVersion::Http1_1 => "HTTP/1.1", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `heads`. [INFO] [stderr] --> src/main.rs:199:14 [INFO] [stderr] | [INFO] [stderr] 199 | for i in 1..heads.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 199 | for in heads.iter().skip(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:200:12 [INFO] [stderr] | [INFO] [stderr] 200 | if heads[i].len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!heads[i].is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:257:21 [INFO] [stderr] | [INFO] [stderr] 257 | sendrecv_data(req, sock); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.67s [INFO] running `"docker" "inspect" "365d86009c51051290c74bb16547d5c3aed7e19b558727b9a83612d07807a2a3"` [INFO] running `"docker" "rm" "-f" "365d86009c51051290c74bb16547d5c3aed7e19b558727b9a83612d07807a2a3"` [INFO] [stdout] 365d86009c51051290c74bb16547d5c3aed7e19b558727b9a83612d07807a2a3