[INFO] updating cached repository mukuact/simCAN [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mukuact/simCAN [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mukuact/simCAN" "work/ex/clippy-test-run/sources/stable/gh/mukuact/simCAN"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mukuact/simCAN'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mukuact/simCAN" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mukuact/simCAN"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mukuact/simCAN'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3993886bd93156d270683de256c7d2062dfa879e [INFO] sha for GitHub repo mukuact/simCAN: 3993886bd93156d270683de256c7d2062dfa879e [INFO] validating manifest of mukuact/simCAN on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mukuact/simCAN on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mukuact/simCAN [INFO] finished frobbing mukuact/simCAN [INFO] frobbed toml for mukuact/simCAN written to work/ex/clippy-test-run/sources/stable/gh/mukuact/simCAN/Cargo.toml [INFO] started frobbing mukuact/simCAN [INFO] finished frobbing mukuact/simCAN [INFO] frobbed toml for mukuact/simCAN written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mukuact/simCAN/Cargo.toml [INFO] crate mukuact/simCAN has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mukuact/simCAN against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mukuact/simCAN:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6781153c7f3b5efc8e84c3531a73db87a3852a2d5634e8a514778dbbff26fe9b [INFO] running `"docker" "start" "-a" "6781153c7f3b5efc8e84c3531a73db87a3852a2d5634e8a514778dbbff26fe9b"` [INFO] [stderr] Checking bytes v0.4.8 [INFO] [stderr] Checking simCAN v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/canframe.rs:36:27 [INFO] [stderr] | [INFO] [stderr] 36 | self.frame[0] &= !0x0007E000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0007_E000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/canframe.rs:138:24 [INFO] [stderr] | [INFO] [stderr] 138 | let mask = 0xffffffff >> rocal_cur; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/canframe.rs:149:24 [INFO] [stderr] | [INFO] [stderr] 149 | let mask = 0xffffffff >> rocal_cur; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/canframe.rs:160:24 [INFO] [stderr] | [INFO] [stderr] 160 | let mask = 0xffffffff >> rocal_cur ; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/canframe.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | return Err(prev_bit) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(prev_bit)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/canframe.rs:179:41 [INFO] [stderr] | [INFO] [stderr] 179 | data_length |= (self.frame[0] & 0x0001E000) >> 13; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0001_E000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/canframe.rs:36:27 [INFO] [stderr] | [INFO] [stderr] 36 | self.frame[0] &= !0x0007E000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0007_E000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/canframe.rs:138:24 [INFO] [stderr] | [INFO] [stderr] 138 | let mask = 0xffffffff >> rocal_cur; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/canframe.rs:149:24 [INFO] [stderr] | [INFO] [stderr] 149 | let mask = 0xffffffff >> rocal_cur; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/canframe.rs:160:24 [INFO] [stderr] | [INFO] [stderr] 160 | let mask = 0xffffffff >> rocal_cur ; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/canframe.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | return Err(prev_bit) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(prev_bit)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/canframe.rs:179:41 [INFO] [stderr] | [INFO] [stderr] 179 | data_length |= (self.frame[0] & 0x0001E000) >> 13; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0001_E000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/canframe.rs:298:39 [INFO] [stderr] | [INFO] [stderr] 298 | let own_id = (self.frame[0] & 0x4FF00000) >> 20; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4FF0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/canframe.rs:299:42 [INFO] [stderr] | [INFO] [stderr] 299 | let other_id = (other.frame[0] & 0x4FF00000) >> 20; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4FF0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/bus.rs:19:45 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn send(&mut self, input: CANFrame) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/canframe.rs:298:39 [INFO] [stderr] | [INFO] [stderr] 298 | let own_id = (self.frame[0] & 0x4FF00000) >> 20; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4FF0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/canframe.rs:299:42 [INFO] [stderr] | [INFO] [stderr] 299 | let other_id = (other.frame[0] & 0x4FF00000) >> 20; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4FF0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/canframe.rs:312:41 [INFO] [stderr] | [INFO] [stderr] 312 | assert_eq!(can_frame.view()[0], 0b10000000000100000000000000000000) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1000_0000_0001_0000_0000_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/canframe.rs:318:41 [INFO] [stderr] | [INFO] [stderr] 318 | assert_eq!(can_frame.view()[0], 0b10000110010100000000000000000000) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1000_0110_0101_0000_0000_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/canframe.rs:331:41 [INFO] [stderr] | [INFO] [stderr] 331 | assert_eq!(can_frame.view()[0], 0b10000110010111110000000000000000) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1000_0110_0101_1111_0000_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/canframe.rs:338:41 [INFO] [stderr] | [INFO] [stderr] 338 | assert_eq!(can_frame.view()[0], 0b10000110010111101100000000000000) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1000_0110_0101_1110_1100_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/canframe.rs:345:41 [INFO] [stderr] | [INFO] [stderr] 345 | assert_eq!(can_frame.view()[0], 0b10000110010111101110000000000000); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1000_0110_0101_1110_1110_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/canframe.rs:347:41 [INFO] [stderr] | [INFO] [stderr] 347 | assert_eq!(can_frame.view()[0], 0b10000110010111101010000000000000); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1000_0110_0101_1110_1010_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/canframe.rs:362:41 [INFO] [stderr] | [INFO] [stderr] 362 | assert_eq!(can_frame.view()[0], 0x865F0D0D); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x865F_0D0D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/canframe.rs:363:41 [INFO] [stderr] | [INFO] [stderr] 363 | assert_eq!(can_frame.view()[1], 0xECECACCE); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xECEC_ACCE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/canframe.rs:364:41 [INFO] [stderr] | [INFO] [stderr] 364 | assert_eq!(can_frame.view()[2], 0xACEC2000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xACEC_2000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/canframe.rs:372:41 [INFO] [stderr] | [INFO] [stderr] 372 | assert_eq!(can_frame.view()[0], 0x865ECD0D); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x865E_CD0D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/canframe.rs:373:41 [INFO] [stderr] | [INFO] [stderr] 373 | assert_eq!(can_frame.view()[1], 0xECECACCE); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xECEC_ACCE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/canframe.rs:374:41 [INFO] [stderr] | [INFO] [stderr] 374 | assert_eq!(can_frame.view()[2], 0xA0000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xA000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/canframe.rs:393:41 [INFO] [stderr] | [INFO] [stderr] 393 | assert_eq!(can_frame.view()[0], 0x820F8827); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x820F_8827` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/canframe.rs:394:41 [INFO] [stderr] | [INFO] [stderr] 394 | assert_eq!(can_frame.view()[1], 0xC1041041); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xC104_1041` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/canframe.rs:404:41 [INFO] [stderr] | [INFO] [stderr] 404 | assert_eq!(can_frame.view()[0], 0x820F8C17); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x820F_8C17` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/canframe.rs:405:41 [INFO] [stderr] | [INFO] [stderr] 405 | assert_eq!(can_frame.view()[1], 0xD8DC1041); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xD8DC_1041` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/canframe.rs:406:41 [INFO] [stderr] | [INFO] [stderr] 406 | assert_eq!(can_frame.view()[2], 0x04104104); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0410_4104` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/canframe.rs:417:41 [INFO] [stderr] | [INFO] [stderr] 417 | assert_eq!(can_frame.view()[0], 0x820F8C17); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x820F_8C17` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/canframe.rs:418:41 [INFO] [stderr] | [INFO] [stderr] 418 | assert_eq!(can_frame.view()[1], 0xD8DC1041); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xD8DC_1041` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/canframe.rs:419:41 [INFO] [stderr] | [INFO] [stderr] 419 | assert_eq!(can_frame.view()[2], 0x04104104); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0410_4104` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/bus.rs:19:45 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn send(&mut self, input: CANFrame) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: crate `simCAN` should have a snake case name such as `sim_can` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ecu.rs:29:39 [INFO] [stderr] | [INFO] [stderr] 29 | let bus_frame = bus.recieve().ok_or("Bus is empty".to_string())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Bus is empty".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ecu.rs:49:39 [INFO] [stderr] | [INFO] [stderr] 49 | let bus_frame = bus.recieve().ok_or("Bus is empty".to_string())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Bus is empty".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/canframe.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | sender = sender << 20; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sender <<= 20` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/canframe.rs:69:39 [INFO] [stderr] | [INFO] [stderr] 69 | 0 => self.frame[0] |= (*onebyte as u32) << 5, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(*onebyte)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/canframe.rs:71:38 [INFO] [stderr] | [INFO] [stderr] 71 | self.frame[0] |= onebyte.get_bits(3..8) as u32 ; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(onebyte.get_bits(3..8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/canframe.rs:72:38 [INFO] [stderr] | [INFO] [stderr] 72 | self.frame[1] |= (onebyte.get_bits(0..3) as u32) << 29; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(onebyte.get_bits(0..3))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/canframe.rs:74:39 [INFO] [stderr] | [INFO] [stderr] 74 | 2 => self.frame[1] |= (*onebyte as u32) << 21, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(*onebyte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/canframe.rs:75:39 [INFO] [stderr] | [INFO] [stderr] 75 | 3 => self.frame[1] |= (*onebyte as u32) << 13, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(*onebyte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/canframe.rs:76:39 [INFO] [stderr] | [INFO] [stderr] 76 | 4 => self.frame[1] |= (*onebyte as u32) << 5, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(*onebyte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/canframe.rs:78:38 [INFO] [stderr] | [INFO] [stderr] 78 | self.frame[1] |= onebyte.get_bits(3..8) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(onebyte.get_bits(3..8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/canframe.rs:79:38 [INFO] [stderr] | [INFO] [stderr] 79 | self.frame[2] |= (onebyte.get_bits(0..3) as u32) << 29; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(onebyte.get_bits(0..3))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/canframe.rs:81:39 [INFO] [stderr] | [INFO] [stderr] 81 | 6 => self.frame[2] |= (*onebyte as u32) << 21, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(*onebyte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/canframe.rs:82:39 [INFO] [stderr] | [INFO] [stderr] 82 | 7 => self.frame[2] |= (*onebyte as u32) << 13, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(*onebyte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `array` [INFO] [stderr] --> src/canframe.rs:93:18 [INFO] [stderr] | [INFO] [stderr] 93 | for i in 0..data_len { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 93 | for (i, ) in array.iter_mut().enumerate().take(data_len) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/canframe.rs:166:31 [INFO] [stderr] | [INFO] [stderr] 166 | fn check_bit_change(data: &u32) -> Result { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: crate `simCAN` should have a snake case name such as `sim_can` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ecu.rs:29:39 [INFO] [stderr] | [INFO] [stderr] 29 | let bus_frame = bus.recieve().ok_or("Bus is empty".to_string())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Bus is empty".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ecu.rs:49:39 [INFO] [stderr] | [INFO] [stderr] 49 | let bus_frame = bus.recieve().ok_or("Bus is empty".to_string())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Bus is empty".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/canframe.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | sender = sender << 20; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sender <<= 20` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/canframe.rs:69:39 [INFO] [stderr] | [INFO] [stderr] 69 | 0 => self.frame[0] |= (*onebyte as u32) << 5, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(*onebyte)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/canframe.rs:71:38 [INFO] [stderr] | [INFO] [stderr] 71 | self.frame[0] |= onebyte.get_bits(3..8) as u32 ; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(onebyte.get_bits(3..8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/canframe.rs:72:38 [INFO] [stderr] | [INFO] [stderr] 72 | self.frame[1] |= (onebyte.get_bits(0..3) as u32) << 29; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(onebyte.get_bits(0..3))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/canframe.rs:74:39 [INFO] [stderr] | [INFO] [stderr] 74 | 2 => self.frame[1] |= (*onebyte as u32) << 21, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(*onebyte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/canframe.rs:75:39 [INFO] [stderr] | [INFO] [stderr] 75 | 3 => self.frame[1] |= (*onebyte as u32) << 13, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(*onebyte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/canframe.rs:76:39 [INFO] [stderr] | [INFO] [stderr] 76 | 4 => self.frame[1] |= (*onebyte as u32) << 5, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(*onebyte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/canframe.rs:78:38 [INFO] [stderr] | [INFO] [stderr] 78 | self.frame[1] |= onebyte.get_bits(3..8) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(onebyte.get_bits(3..8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/canframe.rs:79:38 [INFO] [stderr] | [INFO] [stderr] 79 | self.frame[2] |= (onebyte.get_bits(0..3) as u32) << 29; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(onebyte.get_bits(0..3))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/canframe.rs:81:39 [INFO] [stderr] | [INFO] [stderr] 81 | 6 => self.frame[2] |= (*onebyte as u32) << 21, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(*onebyte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/canframe.rs:82:39 [INFO] [stderr] | [INFO] [stderr] 82 | 7 => self.frame[2] |= (*onebyte as u32) << 13, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(*onebyte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `array` [INFO] [stderr] --> src/canframe.rs:93:18 [INFO] [stderr] | [INFO] [stderr] 93 | for i in 0..data_len { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 93 | for (i, ) in array.iter_mut().enumerate().take(data_len) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/canframe.rs:166:31 [INFO] [stderr] | [INFO] [stderr] 166 | fn check_bit_change(data: &u32) -> Result { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/canframe.rs:361:28 [INFO] [stderr] | [INFO] [stderr] 361 | can_frame.set_data("hogefuga".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"hogefuga"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/canframe.rs:371:28 [INFO] [stderr] | [INFO] [stderr] 371 | can_frame.set_data("hogefuga".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"hogefuga"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/canframe.rs:447:28 [INFO] [stderr] | [INFO] [stderr] 447 | can_frame.set_data("hogefuga".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"hogefuga"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/canframe.rs:449:42 [INFO] [stderr] | [INFO] [stderr] 449 | assert_eq!(can_frame.get_data(), "hogefuga".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"hogefuga"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/canframe.rs:456:28 [INFO] [stderr] | [INFO] [stderr] 456 | can_frame.set_data("hogefuga".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"hogefuga"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/canframe.rs:459:42 [INFO] [stderr] | [INFO] [stderr] 459 | assert_eq!(can_frame.get_data(), "hogefuga".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"hogefuga"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: unused import: `simCAN::ecu::ECU` [INFO] [stderr] --> src/main.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use simCAN::ecu::ECU; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `simCAN::ecu::ECU` [INFO] [stderr] --> src/main.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use simCAN::ecu::ECU; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: crate `simCAN` should have a snake case name such as `sim_can` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: crate `simCAN` should have a snake case name such as `sim_can` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.10s [INFO] running `"docker" "inspect" "6781153c7f3b5efc8e84c3531a73db87a3852a2d5634e8a514778dbbff26fe9b"` [INFO] running `"docker" "rm" "-f" "6781153c7f3b5efc8e84c3531a73db87a3852a2d5634e8a514778dbbff26fe9b"` [INFO] [stdout] 6781153c7f3b5efc8e84c3531a73db87a3852a2d5634e8a514778dbbff26fe9b