[INFO] updating cached repository mtn/ent
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/mtn/ent
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/mtn/ent" "work/ex/clippy-test-run/sources/stable/gh/mtn/ent"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mtn/ent'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/mtn/ent" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mtn/ent"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mtn/ent'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 95095681810c18df76a18f11eff44fb9bfbd0d4f
[INFO] sha for GitHub repo mtn/ent: 95095681810c18df76a18f11eff44fb9bfbd0d4f
[INFO] validating manifest of mtn/ent on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of mtn/ent on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing mtn/ent
[INFO] finished frobbing mtn/ent
[INFO] frobbed toml for mtn/ent written to work/ex/clippy-test-run/sources/stable/gh/mtn/ent/Cargo.toml
[INFO] started frobbing mtn/ent
[INFO] finished frobbing mtn/ent
[INFO] frobbed toml for mtn/ent written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mtn/ent/Cargo.toml
[INFO] crate mtn/ent has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting mtn/ent against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mtn/ent:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 67bcdc63b1833f89a9c041884b482bfbd1f821083c5c44cea488a72508f5d3f3
[INFO] running `"docker" "start" "-a" "67bcdc63b1833f89a9c041884b482bfbd1f821083c5c44cea488a72508f5d3f3"`
[INFO] [stderr]     Checking ent v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/watchlist.rs:66:5
[INFO] [stderr]    |
[INFO] [stderr] 66 |     return true
[INFO] [stderr]    |     ^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/watchlist.rs:66:5
[INFO] [stderr]    |
[INFO] [stderr] 66 |     return true
[INFO] [stderr]    |     ^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]  --> src/main.rs:6:9
[INFO] [stderr]   |
[INFO] [stderr] 6 |     let mut in_str = "A ~B ~C DE\nC D ~E";
[INFO] [stderr]   |         ----^^^^^^
[INFO] [stderr]   |         |
[INFO] [stderr]   |         help: remove this `mut`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `update_watchlist`
[INFO] [stderr]   --> src/watchlist.rs:24:1
[INFO] [stderr]    |
[INFO] [stderr] 24 | / fn update_watchlist<'a> (sat_instance: &'a IR, watchlist: &'a mut Watchlist<'a>,
[INFO] [stderr] 25 | |                          false_literal: Variable, assignments: Vec<Option<bool>>,
[INFO] [stderr] 26 | |                          verbose: bool) -> bool {
[INFO] [stderr] 27 | |     // When X is made false, everything watching X needs to watch something else
[INFO] [stderr] ...  |
[INFO] [stderr] 66 | |     return true
[INFO] [stderr] 67 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/ir.rs:49:32
[INFO] [stderr]    |
[INFO] [stderr] 49 |                 let encoding = table.get(var_name).unwrap() << 1 | negated;
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&table[var_name]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/ir.rs:87:44
[INFO] [stderr]    |
[INFO] [stderr] 87 |     pub fn clause_to_string(&self, clause: &Clause) -> String {
[INFO] [stderr]    |                                            ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]   --> src/watchlist.rs:39:30
[INFO] [stderr]    |
[INFO] [stderr] 39 |               let assignment = if (altern & 1) ^ 1 == 0 {
[INFO] [stderr]    |  ______________________________^
[INFO] [stderr] 40 | |                 false
[INFO] [stderr] 41 | |             } else {
[INFO] [stderr] 42 | |                 true
[INFO] [stderr] 43 | |             };
[INFO] [stderr]    | |_____________^ help: you can reduce it to: `!((altern & 1) ^ 1 == 0)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]   --> src/watchlist.rs:51:16
[INFO] [stderr]    |
[INFO] [stderr] 51 |           if let None = alternative {
[INFO] [stderr]    |  _________-      ^^^^
[INFO] [stderr] 52 | |             if verbose {
[INFO] [stderr] 53 | |                 println!("Current watchlist:");
[INFO] [stderr] 54 | |                 watchlist_print(sat_instance, watchlist);
[INFO] [stderr] ...  |
[INFO] [stderr] 59 | |             return false
[INFO] [stderr] 60 | |         }
[INFO] [stderr]    | |_________- help: try this: `if alternative.is_none()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/watchlist.rs:69:52
[INFO] [stderr]    |
[INFO] [stderr] 69 | pub fn watchlist_print<'a> (ir: &'a IR, watchlist: &'a Watchlist) {
[INFO] [stderr]    |                                                    ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]  --> src/main.rs:6:9
[INFO] [stderr]   |
[INFO] [stderr] 6 |     let mut in_str = "A ~B ~C DE\nC D ~E";
[INFO] [stderr]   |         ----^^^^^^
[INFO] [stderr]   |         |
[INFO] [stderr]   |         help: remove this `mut`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `update_watchlist`
[INFO] [stderr]   --> src/watchlist.rs:24:1
[INFO] [stderr]    |
[INFO] [stderr] 24 | / fn update_watchlist<'a> (sat_instance: &'a IR, watchlist: &'a mut Watchlist<'a>,
[INFO] [stderr] 25 | |                          false_literal: Variable, assignments: Vec<Option<bool>>,
[INFO] [stderr] 26 | |                          verbose: bool) -> bool {
[INFO] [stderr] 27 | |     // When X is made false, everything watching X needs to watch something else
[INFO] [stderr] ...  |
[INFO] [stderr] 66 | |     return true
[INFO] [stderr] 67 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/ir.rs:49:32
[INFO] [stderr]    |
[INFO] [stderr] 49 |                 let encoding = table.get(var_name).unwrap() << 1 | negated;
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&table[var_name]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/ir.rs:87:44
[INFO] [stderr]    |
[INFO] [stderr] 87 |     pub fn clause_to_string(&self, clause: &Clause) -> String {
[INFO] [stderr]    |                                            ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]   --> src/watchlist.rs:39:30
[INFO] [stderr]    |
[INFO] [stderr] 39 |               let assignment = if (altern & 1) ^ 1 == 0 {
[INFO] [stderr]    |  ______________________________^
[INFO] [stderr] 40 | |                 false
[INFO] [stderr] 41 | |             } else {
[INFO] [stderr] 42 | |                 true
[INFO] [stderr] 43 | |             };
[INFO] [stderr]    | |_____________^ help: you can reduce it to: `!((altern & 1) ^ 1 == 0)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]   --> src/watchlist.rs:51:16
[INFO] [stderr]    |
[INFO] [stderr] 51 |           if let None = alternative {
[INFO] [stderr]    |  _________-      ^^^^
[INFO] [stderr] 52 | |             if verbose {
[INFO] [stderr] 53 | |                 println!("Current watchlist:");
[INFO] [stderr] 54 | |                 watchlist_print(sat_instance, watchlist);
[INFO] [stderr] ...  |
[INFO] [stderr] 59 | |             return false
[INFO] [stderr] 60 | |         }
[INFO] [stderr]    | |_________- help: try this: `if alternative.is_none()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/watchlist.rs:69:52
[INFO] [stderr]    |
[INFO] [stderr] 69 | pub fn watchlist_print<'a> (ir: &'a IR, watchlist: &'a Watchlist) {
[INFO] [stderr]    |                                                    ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.65s
[INFO] running `"docker" "inspect" "67bcdc63b1833f89a9c041884b482bfbd1f821083c5c44cea488a72508f5d3f3"`
[INFO] running `"docker" "rm" "-f" "67bcdc63b1833f89a9c041884b482bfbd1f821083c5c44cea488a72508f5d3f3"`
[INFO] [stdout] 67bcdc63b1833f89a9c041884b482bfbd1f821083c5c44cea488a72508f5d3f3