[INFO] updating cached repository mtharrison/wasmbooth
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/mtharrison/wasmbooth
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/mtharrison/wasmbooth" "work/ex/clippy-test-run/sources/stable/gh/mtharrison/wasmbooth"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mtharrison/wasmbooth'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/mtharrison/wasmbooth" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mtharrison/wasmbooth"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mtharrison/wasmbooth'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 8abbac52c1675063670f794072146f494e9818ef
[INFO] sha for GitHub repo mtharrison/wasmbooth: 8abbac52c1675063670f794072146f494e9818ef
[INFO] validating manifest of mtharrison/wasmbooth on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of mtharrison/wasmbooth on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing mtharrison/wasmbooth
[INFO] finished frobbing mtharrison/wasmbooth
[INFO] frobbed toml for mtharrison/wasmbooth written to work/ex/clippy-test-run/sources/stable/gh/mtharrison/wasmbooth/Cargo.toml
[INFO] started frobbing mtharrison/wasmbooth
[INFO] finished frobbing mtharrison/wasmbooth
[INFO] frobbed toml for mtharrison/wasmbooth written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mtharrison/wasmbooth/Cargo.toml
[INFO] crate mtharrison/wasmbooth has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting mtharrison/wasmbooth against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mtharrison/wasmbooth:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ff2acfcf10bbeba1c20f896bf5cc3faa76957b5ddcf64316922d7a933544e64c
[INFO] running `"docker" "start" "-a" "ff2acfcf10bbeba1c20f896bf5cc3faa76957b5ddcf64316922d7a933544e64c"`
[INFO] [stderr]     Checking wasmbooth v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/bitflags.rs:15:9
[INFO] [stderr]    |
[INFO] [stderr] 15 |         return (self.num >> i & 1) == 1;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.num >> i & 1) == 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/convolution.rs:44:5
[INFO] [stderr]    |
[INFO] [stderr] 44 |     return accum as u8;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `accum as u8`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/bitflags.rs:15:9
[INFO] [stderr]    |
[INFO] [stderr] 15 |         return (self.num >> i & 1) == 1;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.num >> i & 1) == 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/bitflags.rs:26:35
[INFO] [stderr]    |
[INFO] [stderr] 26 |         let flags = BitFlags::new(0b00000000);
[INFO] [stderr]    |                                   ^^^^^^^^^^ help: consider: `0b0000_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/bitflags.rs:37:35
[INFO] [stderr]    |
[INFO] [stderr] 37 |         let flags = BitFlags::new(0b00001011);
[INFO] [stderr]    |                                   ^^^^^^^^^^ help: consider: `0b0000_1011`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/bitflags.rs:48:35
[INFO] [stderr]    |
[INFO] [stderr] 48 |         let flags = BitFlags::new(0b11111111);
[INFO] [stderr]    |                                   ^^^^^^^^^^ help: consider: `0b1111_1111`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/convolution.rs:44:5
[INFO] [stderr]    |
[INFO] [stderr] 44 |     return accum as u8;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `accum as u8`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/filter.rs:36:31
[INFO] [stderr]    |
[INFO] [stderr] 36 |             image.pixels[j] = image.pixels[i].clone();
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `image.pixels[i]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/filter.rs:48:31
[INFO] [stderr]    |
[INFO] [stderr] 48 |             image.pixels[j] = image.pixels[i].clone();
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `image.pixels[i]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable
[INFO] [stderr]   --> src/filter.rs:60:39
[INFO] [stderr]    |
[INFO] [stderr] 60 |     let mut pixels_copy: Vec<Pixel> = image.pixels.iter().cloned().collect();
[INFO] [stderr]    |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::iter_cloned_collect)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/image.rs:27:28
[INFO] [stderr]    |
[INFO] [stderr] 27 |                 let temp = self.pixels[i].clone();
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.pixels[i]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/pixel.rs:37:21
[INFO] [stderr]    |
[INFO] [stderr] 37 |         let avg = ((self.green as u32 + self.red as u32 + self.blue as u32) / 3) as u8;
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.green)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/pixel.rs:37:41
[INFO] [stderr]    |
[INFO] [stderr] 37 |         let avg = ((self.green as u32 + self.red as u32 + self.blue as u32) / 3) as u8;
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^ help: try: `u32::from(self.red)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/pixel.rs:37:59
[INFO] [stderr]    |
[INFO] [stderr] 37 |         let avg = ((self.green as u32 + self.red as u32 + self.blue as u32) / 3) as u8;
[INFO] [stderr]    |                                                           ^^^^^^^^^^^^^^^^ help: try: `u32::from(self.blue)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/convolution.rs:32:22
[INFO] [stderr]    |
[INFO] [stderr] 32 |             accum += (m1[(i * 3) + j] as f32) * (m2[i][j]);
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(m1[(i * 3) + j])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 28
[INFO] [stderr]   --> src/bitflags.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 | /     fn test_get() {
[INFO] [stderr] 26 | |         let flags = BitFlags::new(0b00000000);
[INFO] [stderr] 27 | |
[INFO] [stderr] 28 | |         assert_eq!(flags.get(0), false);
[INFO] [stderr] ...  |
[INFO] [stderr] 61 | |         assert_eq!(flags.get(10), false);
[INFO] [stderr] 62 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]    = help: you could split it up into multiple smaller functions
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/filter.rs:36:31
[INFO] [stderr]    |
[INFO] [stderr] 36 |             image.pixels[j] = image.pixels[i].clone();
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `image.pixels[i]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/filter.rs:48:31
[INFO] [stderr]    |
[INFO] [stderr] 48 |             image.pixels[j] = image.pixels[i].clone();
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `image.pixels[i]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable
[INFO] [stderr]   --> src/filter.rs:60:39
[INFO] [stderr]    |
[INFO] [stderr] 60 |     let mut pixels_copy: Vec<Pixel> = image.pixels.iter().cloned().collect();
[INFO] [stderr]    |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::iter_cloned_collect)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/image.rs:27:28
[INFO] [stderr]    |
[INFO] [stderr] 27 |                 let temp = self.pixels[i].clone();
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.pixels[i]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/pixel.rs:37:21
[INFO] [stderr]    |
[INFO] [stderr] 37 |         let avg = ((self.green as u32 + self.red as u32 + self.blue as u32) / 3) as u8;
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.green)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/pixel.rs:37:41
[INFO] [stderr]    |
[INFO] [stderr] 37 |         let avg = ((self.green as u32 + self.red as u32 + self.blue as u32) / 3) as u8;
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^ help: try: `u32::from(self.red)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/pixel.rs:37:59
[INFO] [stderr]    |
[INFO] [stderr] 37 |         let avg = ((self.green as u32 + self.red as u32 + self.blue as u32) / 3) as u8;
[INFO] [stderr]    |                                                           ^^^^^^^^^^^^^^^^ help: try: `u32::from(self.blue)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/convolution.rs:32:22
[INFO] [stderr]    |
[INFO] [stderr] 32 |             accum += (m1[(i * 3) + j] as f32) * (m2[i][j]);
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(m1[(i * 3) + j])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.84s
[INFO] running `"docker" "inspect" "ff2acfcf10bbeba1c20f896bf5cc3faa76957b5ddcf64316922d7a933544e64c"`
[INFO] running `"docker" "rm" "-f" "ff2acfcf10bbeba1c20f896bf5cc3faa76957b5ddcf64316922d7a933544e64c"`
[INFO] [stdout] ff2acfcf10bbeba1c20f896bf5cc3faa76957b5ddcf64316922d7a933544e64c