[INFO] updating cached repository msuesskraut/bf-interp [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/msuesskraut/bf-interp [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/msuesskraut/bf-interp" "work/ex/clippy-test-run/sources/stable/gh/msuesskraut/bf-interp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/msuesskraut/bf-interp'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/msuesskraut/bf-interp" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/msuesskraut/bf-interp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/msuesskraut/bf-interp'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fe4613281656d6bb7319dfb7d819fccb5bd64091 [INFO] sha for GitHub repo msuesskraut/bf-interp: fe4613281656d6bb7319dfb7d819fccb5bd64091 [INFO] validating manifest of msuesskraut/bf-interp on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of msuesskraut/bf-interp on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing msuesskraut/bf-interp [INFO] finished frobbing msuesskraut/bf-interp [INFO] frobbed toml for msuesskraut/bf-interp written to work/ex/clippy-test-run/sources/stable/gh/msuesskraut/bf-interp/Cargo.toml [INFO] started frobbing msuesskraut/bf-interp [INFO] finished frobbing msuesskraut/bf-interp [INFO] frobbed toml for msuesskraut/bf-interp written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/msuesskraut/bf-interp/Cargo.toml [INFO] crate msuesskraut/bf-interp has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting msuesskraut/bf-interp against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/msuesskraut/bf-interp:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0fc93c4dccd4c190fab1aff7ba2c65de9e56e82261f00b82fd2c90cd8f64cde6 [INFO] running `"docker" "start" "-a" "0fc93c4dccd4c190fab1aff7ba2c65de9e56e82261f00b82fd2c90cd8f64cde6"` [INFO] [stderr] Checking bf-interp v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:38:15 [INFO] [stderr] | [INFO] [stderr] 38 | Program { instructions: instructions } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instructions` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/opt.rs:68:15 [INFO] [stderr] | [INFO] [stderr] 68 | Program { instructions: instructions } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instructions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:38:15 [INFO] [stderr] | [INFO] [stderr] 38 | Program { instructions: instructions } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instructions` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/opt.rs:68:15 [INFO] [stderr] | [INFO] [stderr] 68 | Program { instructions: instructions } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instructions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `loop_helper::LoopHelper` [INFO] [stderr] --> src/loop_helper.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / pub fn new() -> LoopHelper { [INFO] [stderr] 26 | | LoopHelper { [INFO] [stderr] 27 | | bracket_stack: Vec::new(), [INFO] [stderr] 28 | | relocs: Vec::new(), [INFO] [stderr] 29 | | } [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/interp.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | Err(_) => panic!("Cannot read from stdin"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `loop_helper::LoopHelper` [INFO] [stderr] --> src/loop_helper.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / pub fn new() -> LoopHelper { [INFO] [stderr] 26 | | LoopHelper { [INFO] [stderr] 27 | | bracket_stack: Vec::new(), [INFO] [stderr] 28 | | relocs: Vec::new(), [INFO] [stderr] 29 | | } [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/interp.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | Err(_) => panic!("Cannot read from stdin"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.64s [INFO] running `"docker" "inspect" "0fc93c4dccd4c190fab1aff7ba2c65de9e56e82261f00b82fd2c90cd8f64cde6"` [INFO] running `"docker" "rm" "-f" "0fc93c4dccd4c190fab1aff7ba2c65de9e56e82261f00b82fd2c90cd8f64cde6"` [INFO] [stdout] 0fc93c4dccd4c190fab1aff7ba2c65de9e56e82261f00b82fd2c90cd8f64cde6