[INFO] updating cached repository mrkaspa/rlexer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mrkaspa/rlexer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mrkaspa/rlexer" "work/ex/clippy-test-run/sources/stable/gh/mrkaspa/rlexer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mrkaspa/rlexer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mrkaspa/rlexer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mrkaspa/rlexer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mrkaspa/rlexer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 19db952e7ef183448f9f421546089fc9f7370a0a [INFO] sha for GitHub repo mrkaspa/rlexer: 19db952e7ef183448f9f421546089fc9f7370a0a [INFO] validating manifest of mrkaspa/rlexer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mrkaspa/rlexer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mrkaspa/rlexer [INFO] finished frobbing mrkaspa/rlexer [INFO] frobbed toml for mrkaspa/rlexer written to work/ex/clippy-test-run/sources/stable/gh/mrkaspa/rlexer/Cargo.toml [INFO] started frobbing mrkaspa/rlexer [INFO] finished frobbing mrkaspa/rlexer [INFO] frobbed toml for mrkaspa/rlexer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mrkaspa/rlexer/Cargo.toml [INFO] crate mrkaspa/rlexer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mrkaspa/rlexer against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mrkaspa/rlexer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cc8a4450eaf14ab6594eda498401976daad13c997ab4a59fe07bea2c8b83caa7 [INFO] running `"docker" "start" "-a" "cc8a4450eaf14ab6594eda498401976daad13c997ab4a59fe07bea2c8b83caa7"` [INFO] [stderr] Checking parser v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/parser.rs:109:21 [INFO] [stderr] | [INFO] [stderr] 109 | fn into_keyword(p: &mut Parser) -> NextFnCall { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:124:39 [INFO] [stderr] | [INFO] [stderr] 124 | Some(ref mut stmt) => match stmt { [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 125 | | &mut Statement::InsertStatement { ref mut table, .. } => { [INFO] [stderr] 126 | | *table = table_name.clone(); [INFO] [stderr] 127 | | Ok(Some(NextFn { [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(String::from("Wrong statement type")), [INFO] [stderr] 132 | | }, [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 124 | Some(ref mut stmt) => match *stmt { [INFO] [stderr] 125 | Statement::InsertStatement { ref mut table, .. } => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:149:35 [INFO] [stderr] | [INFO] [stderr] 149 | Some(ref mut stmt) => match stmt { [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 150 | | &mut Statement::InsertStatement { ref mut cols, .. } => { [INFO] [stderr] 151 | | *cols = veci; [INFO] [stderr] 152 | | Ok(Some(NextFn { [INFO] [stderr] ... | [INFO] [stderr] 156 | | _ => Err(String::from("Wrong statement type")), [INFO] [stderr] 157 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 149 | Some(ref mut stmt) => match *stmt { [INFO] [stderr] 150 | Statement::InsertStatement { ref mut cols, .. } => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:177:35 [INFO] [stderr] | [INFO] [stderr] 177 | Some(ref mut stmt) => match stmt { [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 178 | | &mut Statement::InsertStatement { ref mut values, .. } => { [INFO] [stderr] 179 | | *values = veci; [INFO] [stderr] 180 | | Ok(Some(NextFn { call: Self::end })) [INFO] [stderr] 181 | | } [INFO] [stderr] 182 | | _ => Err(String::from("Wrong statement type")), [INFO] [stderr] 183 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 177 | Some(ref mut stmt) => match *stmt { [INFO] [stderr] 178 | Statement::InsertStatement { ref mut values, .. } => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/parser.rs:109:21 [INFO] [stderr] | [INFO] [stderr] 109 | fn into_keyword(p: &mut Parser) -> NextFnCall { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:124:39 [INFO] [stderr] | [INFO] [stderr] 124 | Some(ref mut stmt) => match stmt { [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 125 | | &mut Statement::InsertStatement { ref mut table, .. } => { [INFO] [stderr] 126 | | *table = table_name.clone(); [INFO] [stderr] 127 | | Ok(Some(NextFn { [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(String::from("Wrong statement type")), [INFO] [stderr] 132 | | }, [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 124 | Some(ref mut stmt) => match *stmt { [INFO] [stderr] 125 | Statement::InsertStatement { ref mut table, .. } => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:149:35 [INFO] [stderr] | [INFO] [stderr] 149 | Some(ref mut stmt) => match stmt { [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 150 | | &mut Statement::InsertStatement { ref mut cols, .. } => { [INFO] [stderr] 151 | | *cols = veci; [INFO] [stderr] 152 | | Ok(Some(NextFn { [INFO] [stderr] ... | [INFO] [stderr] 156 | | _ => Err(String::from("Wrong statement type")), [INFO] [stderr] 157 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 149 | Some(ref mut stmt) => match *stmt { [INFO] [stderr] 150 | Statement::InsertStatement { ref mut cols, .. } => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:177:35 [INFO] [stderr] | [INFO] [stderr] 177 | Some(ref mut stmt) => match stmt { [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 178 | | &mut Statement::InsertStatement { ref mut values, .. } => { [INFO] [stderr] 179 | | *values = veci; [INFO] [stderr] 180 | | Ok(Some(NextFn { call: Self::end })) [INFO] [stderr] 181 | | } [INFO] [stderr] 182 | | _ => Err(String::from("Wrong statement type")), [INFO] [stderr] 183 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 177 | Some(ref mut stmt) => match *stmt { [INFO] [stderr] 178 | Statement::InsertStatement { ref mut values, .. } => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.48s [INFO] running `"docker" "inspect" "cc8a4450eaf14ab6594eda498401976daad13c997ab4a59fe07bea2c8b83caa7"` [INFO] running `"docker" "rm" "-f" "cc8a4450eaf14ab6594eda498401976daad13c997ab4a59fe07bea2c8b83caa7"` [INFO] [stdout] cc8a4450eaf14ab6594eda498401976daad13c997ab4a59fe07bea2c8b83caa7