[INFO] updating cached repository mredlek/rs-futures-spmc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mredlek/rs-futures-spmc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mredlek/rs-futures-spmc" "work/ex/clippy-test-run/sources/stable/gh/mredlek/rs-futures-spmc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mredlek/rs-futures-spmc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mredlek/rs-futures-spmc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mredlek/rs-futures-spmc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mredlek/rs-futures-spmc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5a7339eb30dc0f62875885b78129a2c5f5b808de [INFO] sha for GitHub repo mredlek/rs-futures-spmc: 5a7339eb30dc0f62875885b78129a2c5f5b808de [INFO] validating manifest of mredlek/rs-futures-spmc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mredlek/rs-futures-spmc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mredlek/rs-futures-spmc [INFO] finished frobbing mredlek/rs-futures-spmc [INFO] frobbed toml for mredlek/rs-futures-spmc written to work/ex/clippy-test-run/sources/stable/gh/mredlek/rs-futures-spmc/Cargo.toml [INFO] started frobbing mredlek/rs-futures-spmc [INFO] finished frobbing mredlek/rs-futures-spmc [INFO] frobbed toml for mredlek/rs-futures-spmc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mredlek/rs-futures-spmc/Cargo.toml [INFO] crate mredlek/rs-futures-spmc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mredlek/rs-futures-spmc against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mredlek/rs-futures-spmc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0afb444e5823f3d00c2501605b2cdef0c07b188411cf80cf2d4f2161c4522601 [INFO] running `"docker" "start" "-a" "0afb444e5823f3d00c2501605b2cdef0c07b188411cf80cf2d4f2161c4522601"` [INFO] [stderr] Checking rs-futures-spmc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spmc_lockfree.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | slots: slots, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `slots` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spmc_lockfree.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spmc_lockfree.rs:92:85 [INFO] [stderr] | [INFO] [stderr] 92 | let mut newlock = Box::into_raw(Box::new(LocksNode { next: ptr::null_mut(), task: task })); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `task` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spmc_lockfree.rs:390:59 [INFO] [stderr] | [INFO] [stderr] 390 | let sender = Sender { shareddata: shareddata.clone(), data: data }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spmc_lockfree.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | slots: slots, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `slots` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spmc_lockfree.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spmc_lockfree.rs:92:85 [INFO] [stderr] | [INFO] [stderr] 92 | let mut newlock = Box::into_raw(Box::new(LocksNode { next: ptr::null_mut(), task: task })); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `task` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spmc_lockfree.rs:390:59 [INFO] [stderr] | [INFO] [stderr] 390 | let sender = Sender { shareddata: shareddata.clone(), data: data }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/spmc_lockfree.rs:27:43 [INFO] [stderr] | [INFO] [stderr] 27 | slots.push(Slot::new(unsafe { dataptr.offset(index as isize) })) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dataptr.add(index)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/spmc_lockfree.rs:376:27 [INFO] [stderr] | [INFO] [stderr] 376 | readinterest: self.readinterest.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.readinterest` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/spmc_lockfree.rs:27:43 [INFO] [stderr] | [INFO] [stderr] 27 | slots.push(Slot::new(unsafe { dataptr.offset(index as isize) })) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dataptr.add(index)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/spmc_lockfree.rs:376:27 [INFO] [stderr] | [INFO] [stderr] 376 | readinterest: self.readinterest.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.readinterest` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/spmc.rs:130:58 [INFO] [stderr] | [INFO] [stderr] 130 | let checkstream = CheckStream { inner: receiver, last_was_ready: last_was_ready }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `last_was_ready` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.79s [INFO] running `"docker" "inspect" "0afb444e5823f3d00c2501605b2cdef0c07b188411cf80cf2d4f2161c4522601"` [INFO] running `"docker" "rm" "-f" "0afb444e5823f3d00c2501605b2cdef0c07b188411cf80cf2d4f2161c4522601"` [INFO] [stdout] 0afb444e5823f3d00c2501605b2cdef0c07b188411cf80cf2d4f2161c4522601