[INFO] updating cached repository mplaw/TicTacToe [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mplaw/TicTacToe [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mplaw/TicTacToe" "work/ex/clippy-test-run/sources/stable/gh/mplaw/TicTacToe"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mplaw/TicTacToe'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mplaw/TicTacToe" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mplaw/TicTacToe"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mplaw/TicTacToe'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 95e545a188de2d32e0590c414e3e95b448580941 [INFO] sha for GitHub repo mplaw/TicTacToe: 95e545a188de2d32e0590c414e3e95b448580941 [INFO] validating manifest of mplaw/TicTacToe on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mplaw/TicTacToe on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mplaw/TicTacToe [INFO] finished frobbing mplaw/TicTacToe [INFO] frobbed toml for mplaw/TicTacToe written to work/ex/clippy-test-run/sources/stable/gh/mplaw/TicTacToe/Cargo.toml [INFO] started frobbing mplaw/TicTacToe [INFO] finished frobbing mplaw/TicTacToe [INFO] frobbed toml for mplaw/TicTacToe written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mplaw/TicTacToe/Cargo.toml [INFO] crate mplaw/TicTacToe has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mplaw/TicTacToe against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mplaw/TicTacToe:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 59aa9ccedf20c3e45db37fd753844d274cac2e34ee962cac8173002fcb2b2ffe [INFO] running `"docker" "start" "-a" "59aa9ccedf20c3e45db37fd753844d274cac2e34ee962cac8173002fcb2b2ffe"` [INFO] [stderr] Checking tictactoe v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:59:20 [INFO] [stderr] | [INFO] [stderr] 59 | Ok(Point { x: x, y: y }) [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:59:26 [INFO] [stderr] | [INFO] [stderr] 59 | Ok(Point { x: x, y: y }) [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:59:20 [INFO] [stderr] | [INFO] [stderr] 59 | Ok(Point { x: x, y: y }) [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:59:26 [INFO] [stderr] | [INFO] [stderr] 59 | Ok(Point { x: x, y: y }) [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | return if p.x <= 2 && p.y <= 2 { Ok(p.x + 3 * p.y) } else { Err(1) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `if p.x <= 2 && p.y <= 2 { Ok(p.x + 3 * p.y) } else { Err(1) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | return Err(2); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | return if p.x <= 2 && p.y <= 2 { Ok(p.x + 3 * p.y) } else { Err(1) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `if p.x <= 2 && p.y <= 2 { Ok(p.x + 3 * p.y) } else { Err(1) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | return Err(2); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:54:29 [INFO] [stderr] | [INFO] [stderr] 54 | let mut i = s.split(","); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:97:49 [INFO] [stderr] | [INFO] [stderr] 97 | fn set_square(&mut self, p: &Point, square: &Square) -> std::result::Result { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Square` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:114:45 [INFO] [stderr] | [INFO] [stderr] 114 | fn check_for_victory(board: &Board, player: &Square, _point: &Point) -> bool { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Square` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:139:35 [INFO] [stderr] | [INFO] [stderr] 139 | fn turn(board:&mut Board, player: &Square) -> bool { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Square` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | io::stdout().flush().ok().expect("Could not flush stdout."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/main.rs:159:15 [INFO] [stderr] | [INFO] [stderr] 159 | match input.trim().as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `input.trim()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:54:29 [INFO] [stderr] | [INFO] [stderr] 54 | let mut i = s.split(","); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:97:49 [INFO] [stderr] | [INFO] [stderr] 97 | fn set_square(&mut self, p: &Point, square: &Square) -> std::result::Result { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Square` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:114:45 [INFO] [stderr] | [INFO] [stderr] 114 | fn check_for_victory(board: &Board, player: &Square, _point: &Point) -> bool { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Square` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:139:35 [INFO] [stderr] | [INFO] [stderr] 139 | fn turn(board:&mut Board, player: &Square) -> bool { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Square` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | io::stdout().flush().ok().expect("Could not flush stdout."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/main.rs:159:15 [INFO] [stderr] | [INFO] [stderr] 159 | match input.trim().as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `input.trim()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.24s [INFO] running `"docker" "inspect" "59aa9ccedf20c3e45db37fd753844d274cac2e34ee962cac8173002fcb2b2ffe"` [INFO] running `"docker" "rm" "-f" "59aa9ccedf20c3e45db37fd753844d274cac2e34ee962cac8173002fcb2b2ffe"` [INFO] [stdout] 59aa9ccedf20c3e45db37fd753844d274cac2e34ee962cac8173002fcb2b2ffe