[INFO] updating cached repository mpdrescher/huffman-compression [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mpdrescher/huffman-compression [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mpdrescher/huffman-compression" "work/ex/clippy-test-run/sources/stable/gh/mpdrescher/huffman-compression"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mpdrescher/huffman-compression'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mpdrescher/huffman-compression" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mpdrescher/huffman-compression"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mpdrescher/huffman-compression'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f7270fd9505444ab81fa668aac53c656adf94f96 [INFO] sha for GitHub repo mpdrescher/huffman-compression: f7270fd9505444ab81fa668aac53c656adf94f96 [INFO] validating manifest of mpdrescher/huffman-compression on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mpdrescher/huffman-compression on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mpdrescher/huffman-compression [INFO] finished frobbing mpdrescher/huffman-compression [INFO] frobbed toml for mpdrescher/huffman-compression written to work/ex/clippy-test-run/sources/stable/gh/mpdrescher/huffman-compression/Cargo.toml [INFO] started frobbing mpdrescher/huffman-compression [INFO] finished frobbing mpdrescher/huffman-compression [INFO] frobbed toml for mpdrescher/huffman-compression written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mpdrescher/huffman-compression/Cargo.toml [INFO] crate mpdrescher/huffman-compression has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mpdrescher/huffman-compression against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mpdrescher/huffman-compression:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4a8e30868bcf8a1c6ad5646dc805e175ba3ccadd258cf42ac6e7a2b74a58f848 [INFO] running `"docker" "start" "-a" "4a8e30868bcf8a1c6ad5646dc805e175ba3ccadd258cf42ac6e7a2b74a58f848"` [INFO] [stderr] Checking huffman v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datafile.rs:17:4 [INFO] [stderr] | [INFO] [stderr] 17 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datafile.rs:18:4 [INFO] [stderr] | [INFO] [stderr] 18 | path: path [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:190:2 [INFO] [stderr] | [INFO] [stderr] 190 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datafile.rs:17:4 [INFO] [stderr] | [INFO] [stderr] 17 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datafile.rs:18:4 [INFO] [stderr] | [INFO] [stderr] 18 | path: path [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:190:2 [INFO] [stderr] | [INFO] [stderr] 190 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/byteconvert.rs:7:22 [INFO] [stderr] | [INFO] [stderr] 7 | const BYTE_ONE: u8 = 0b00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:16:22 [INFO] [stderr] | [INFO] [stderr] 16 | pub const APP_NAME: &'static str = "huffman"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:206:3 [INFO] [stderr] | [INFO] [stderr] 206 | return str.replace(".comp", ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `str.replace(".comp", "")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:211:6 [INFO] [stderr] | [INFO] [stderr] 211 | return str; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/byteconvert.rs:7:22 [INFO] [stderr] | [INFO] [stderr] 7 | const BYTE_ONE: u8 = 0b00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:16:22 [INFO] [stderr] | [INFO] [stderr] 16 | pub const APP_NAME: &'static str = "huffman"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:206:3 [INFO] [stderr] | [INFO] [stderr] 206 | return str.replace(".comp", ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `str.replace(".comp", "")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:211:6 [INFO] [stderr] | [INFO] [stderr] 211 | return str; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: value assigned to `cur_byte` is never read [INFO] [stderr] --> src/huffmantree.rs:188:11 [INFO] [stderr] | [INFO] [stderr] 188 | let mut cur_byte: u8 = 4; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/huffmantree.rs:20:25 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn from_data(data: &Data) -> HuffmanTree [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/huffmantree.rs:37:6 [INFO] [stderr] | [INFO] [stderr] 37 | if sorted_nodes.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `sorted_nodes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/huffmantree.rs:131:5 [INFO] [stderr] | [INFO] [stderr] 131 | match self.right [INFO] [stderr] | _________________^ [INFO] [stderr] 132 | | { [INFO] [stderr] 133 | | Some(ref v) => { [INFO] [stderr] 134 | | let mut right_path = path.clone(); [INFO] [stderr] ... | [INFO] [stderr] 138 | | None => {} [INFO] [stderr] 139 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 131 | if let Some(ref v) = self.right { [INFO] [stderr] 132 | let mut right_path = path.clone(); [INFO] [stderr] 133 | right_path.push(1); [INFO] [stderr] 134 | v.fill_lookup_map(&mut map, right_path) [INFO] [stderr] 135 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/huffmantree.rs:140:5 [INFO] [stderr] | [INFO] [stderr] 140 | match self.left [INFO] [stderr] | _________________^ [INFO] [stderr] 141 | | { [INFO] [stderr] 142 | | Some(ref v) => { [INFO] [stderr] 143 | | let mut left_path = path; [INFO] [stderr] ... | [INFO] [stderr] 147 | | None => {} [INFO] [stderr] 148 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 140 | if let Some(ref v) = self.left { [INFO] [stderr] 141 | let mut left_path = path; [INFO] [stderr] 142 | left_path.push(0); [INFO] [stderr] 143 | v.fill_lookup_map(&mut map, left_path) [INFO] [stderr] 144 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `byte` is used to index `dist` [INFO] [stderr] --> src/byteweight.rs:33:14 [INFO] [stderr] | [INFO] [stderr] 33 | for byte in 0..256 [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 33 | for (byte, ) in dist.iter().enumerate() [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compression.rs:19:22 [INFO] [stderr] | [INFO] [stderr] 19 | result.append(&mut lookup_map.get(&byte).unwrap().clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&lookup_map[&byte]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/compression.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | let ch = lookup_map.get(&buffer).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*lookup_map.get(&buffer).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compression.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | let ch = lookup_map.get(&buffer).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&lookup_map[&buffer]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/compression.rs:63:16 [INFO] [stderr] | [INFO] [stderr] 63 | result.push(ch.clone()); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `ch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/byteconvert.rs:119:44 [INFO] [stderr] | [INFO] [stderr] 119 | let number = bytesize.pow(irev as u32) * (data_iter.next().unwrap() as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(data_iter.next().unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: value assigned to `cur_byte` is never read [INFO] [stderr] --> src/huffmantree.rs:188:11 [INFO] [stderr] | [INFO] [stderr] 188 | let mut cur_byte: u8 = 4; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:180:5 [INFO] [stderr] | [INFO] [stderr] 180 | if filepaths.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `filepaths.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/huffmantree.rs:20:25 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn from_data(data: &Data) -> HuffmanTree [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/huffmantree.rs:37:6 [INFO] [stderr] | [INFO] [stderr] 37 | if sorted_nodes.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `sorted_nodes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/huffmantree.rs:131:5 [INFO] [stderr] | [INFO] [stderr] 131 | match self.right [INFO] [stderr] | _________________^ [INFO] [stderr] 132 | | { [INFO] [stderr] 133 | | Some(ref v) => { [INFO] [stderr] 134 | | let mut right_path = path.clone(); [INFO] [stderr] ... | [INFO] [stderr] 138 | | None => {} [INFO] [stderr] 139 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 131 | if let Some(ref v) = self.right { [INFO] [stderr] 132 | let mut right_path = path.clone(); [INFO] [stderr] 133 | right_path.push(1); [INFO] [stderr] 134 | v.fill_lookup_map(&mut map, right_path) [INFO] [stderr] 135 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/huffmantree.rs:140:5 [INFO] [stderr] | [INFO] [stderr] 140 | match self.left [INFO] [stderr] | _________________^ [INFO] [stderr] 141 | | { [INFO] [stderr] 142 | | Some(ref v) => { [INFO] [stderr] 143 | | let mut left_path = path; [INFO] [stderr] ... | [INFO] [stderr] 147 | | None => {} [INFO] [stderr] 148 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 140 | if let Some(ref v) = self.left { [INFO] [stderr] 141 | let mut left_path = path; [INFO] [stderr] 142 | left_path.push(0); [INFO] [stderr] 143 | v.fill_lookup_map(&mut map, left_path) [INFO] [stderr] 144 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `byte` is used to index `dist` [INFO] [stderr] --> src/byteweight.rs:33:14 [INFO] [stderr] | [INFO] [stderr] 33 | for byte in 0..256 [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 33 | for (byte, ) in dist.iter().enumerate() [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compression.rs:19:22 [INFO] [stderr] | [INFO] [stderr] 19 | result.append(&mut lookup_map.get(&byte).unwrap().clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&lookup_map[&byte]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/compression.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | let ch = lookup_map.get(&buffer).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*lookup_map.get(&buffer).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compression.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | let ch = lookup_map.get(&buffer).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&lookup_map[&buffer]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/compression.rs:63:16 [INFO] [stderr] | [INFO] [stderr] 63 | result.push(ch.clone()); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `ch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/byteconvert.rs:119:44 [INFO] [stderr] | [INFO] [stderr] 119 | let number = bytesize.pow(irev as u32) * (data_iter.next().unwrap() as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(data_iter.next().unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:180:5 [INFO] [stderr] | [INFO] [stderr] 180 | if filepaths.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `filepaths.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.22s [INFO] running `"docker" "inspect" "4a8e30868bcf8a1c6ad5646dc805e175ba3ccadd258cf42ac6e7a2b74a58f848"` [INFO] running `"docker" "rm" "-f" "4a8e30868bcf8a1c6ad5646dc805e175ba3ccadd258cf42ac6e7a2b74a58f848"` [INFO] [stdout] 4a8e30868bcf8a1c6ad5646dc805e175ba3ccadd258cf42ac6e7a2b74a58f848