[INFO] updating cached repository mpalmer/socketee
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/mpalmer/socketee
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/mpalmer/socketee" "work/ex/clippy-test-run/sources/stable/gh/mpalmer/socketee"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mpalmer/socketee'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/mpalmer/socketee" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mpalmer/socketee"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mpalmer/socketee'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] a8971cb306638e8d4a7246161a05c3ee45a34c10
[INFO] sha for GitHub repo mpalmer/socketee: a8971cb306638e8d4a7246161a05c3ee45a34c10
[INFO] validating manifest of mpalmer/socketee on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of mpalmer/socketee on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing mpalmer/socketee
[INFO] finished frobbing mpalmer/socketee
[INFO] frobbed toml for mpalmer/socketee written to work/ex/clippy-test-run/sources/stable/gh/mpalmer/socketee/Cargo.toml
[INFO] started frobbing mpalmer/socketee
[INFO] finished frobbing mpalmer/socketee
[INFO] frobbed toml for mpalmer/socketee written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mpalmer/socketee/Cargo.toml
[INFO] crate mpalmer/socketee has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting mpalmer/socketee against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mpalmer/socketee:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] d310278bdfae9655c867fe02bd7c01f88cc4ea03437958d0dc36f823f643ca88
[INFO] running `"docker" "start" "-a" "d310278bdfae9655c867fe02bd7c01f88cc4ea03437958d0dc36f823f643ca88"`
[INFO] [stderr]     Checking socketee v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:99:18
[INFO] [stderr]    |
[INFO] [stderr] 99 |         Ok(_) => return Ok(sock),
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(sock)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:101:13
[INFO] [stderr]     |
[INFO] [stderr] 101 |             return Err(format!("Unable to connect to {}: {}", path, e));
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("Unable to connect to {}: {}", path, e))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:99:18
[INFO] [stderr]    |
[INFO] [stderr] 99 |         Ok(_) => return Ok(sock),
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(sock)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:101:13
[INFO] [stderr]     |
[INFO] [stderr] 101 |             return Err(format!("Unable to connect to {}: {}", path, e));
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("Unable to connect to {}: {}", path, e))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lib.rs:61:24
[INFO] [stderr]    |
[INFO] [stderr] 61 | fn setup_srcsock(path: &String) -> Result<UnixDatagram, String> {
[INFO] [stderr]    |                        ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lib.rs:90:24
[INFO] [stderr]    |
[INFO] [stderr] 90 | fn setup_dstsock(path: &String) -> Result<UnixDatagram, String> {
[INFO] [stderr]    |                        ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lib.rs:61:24
[INFO] [stderr]    |
[INFO] [stderr] 61 | fn setup_srcsock(path: &String) -> Result<UnixDatagram, String> {
[INFO] [stderr]    |                        ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lib.rs:90:24
[INFO] [stderr]    |
[INFO] [stderr] 90 | fn setup_dstsock(path: &String) -> Result<UnixDatagram, String> {
[INFO] [stderr]    |                        ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.35s
[INFO] running `"docker" "inspect" "d310278bdfae9655c867fe02bd7c01f88cc4ea03437958d0dc36f823f643ca88"`
[INFO] running `"docker" "rm" "-f" "d310278bdfae9655c867fe02bd7c01f88cc4ea03437958d0dc36f823f643ca88"`
[INFO] [stdout] d310278bdfae9655c867fe02bd7c01f88cc4ea03437958d0dc36f823f643ca88