[INFO] updating cached repository mouri111/meta-text [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mouri111/meta-text [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mouri111/meta-text" "work/ex/clippy-test-run/sources/stable/gh/mouri111/meta-text"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mouri111/meta-text'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mouri111/meta-text" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mouri111/meta-text"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mouri111/meta-text'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ae2c348228393087aed913bc98fa374afa2b246d [INFO] sha for GitHub repo mouri111/meta-text: ae2c348228393087aed913bc98fa374afa2b246d [INFO] validating manifest of mouri111/meta-text on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mouri111/meta-text on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mouri111/meta-text [INFO] finished frobbing mouri111/meta-text [INFO] frobbed toml for mouri111/meta-text written to work/ex/clippy-test-run/sources/stable/gh/mouri111/meta-text/Cargo.toml [INFO] started frobbing mouri111/meta-text [INFO] finished frobbing mouri111/meta-text [INFO] frobbed toml for mouri111/meta-text written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mouri111/meta-text/Cargo.toml [INFO] crate mouri111/meta-text has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mouri111/meta-text against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mouri111/meta-text:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a51ab95c97ae0cb35b22b61549bebee18958a2f05f311312825d36feac3a022e [INFO] running `"docker" "start" "-a" "a51ab95c97ae0cb35b22b61549bebee18958a2f05f311312825d36feac3a022e"` [INFO] [stderr] Checking meta-text v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/parser/mod.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/parser/mod.rs:19:15 [INFO] [stderr] | [INFO] [stderr] 19 | let res = AST::Seq(xs); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/parser/mod.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/parser/mod.rs:19:15 [INFO] [stderr] | [INFO] [stderr] 19 | let res = AST::Seq(xs); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `types::ast::AST` [INFO] [stderr] --> src/types/ast.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> AST { [INFO] [stderr] 14 | | AST::Empty [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | impl Default for types::ast::AST { [INFO] [stderr] 13 | fn default() -> Self { [INFO] [stderr] 14 | Self::new() [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/types/precedence.rs:9:17 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn cont(&self, prec: &Precedence) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/types/precedence.rs:9:30 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn cont(&self, prec: &Precedence) -> bool { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `Precedence` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lexer/mod.rs:23:16 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn lex(ss: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/parser/mod.rs:10:28 [INFO] [stderr] | [INFO] [stderr] 10 | while let Some(head) = iter.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for head in iter { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser/mod.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | / match head { [INFO] [stderr] 12 | | Token::STRING(_) => { [INFO] [stderr] 13 | | xs.push(Box::new(AST::String(head.clone()))); [INFO] [stderr] 14 | | } [INFO] [stderr] 15 | | _ => { [INFO] [stderr] 16 | | } [INFO] [stderr] 17 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let Token::STRING(_) = head { [INFO] [stderr] 12 | xs.push(Box::new(AST::String(head.clone()))); [INFO] [stderr] 13 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/render/mod.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | / match token { [INFO] [stderr] 23 | | Token::STRING(ss) => { [INFO] [stderr] 24 | | let n = ss.len(); [INFO] [stderr] 25 | | let mut exp_buf: Vec = vec![]; [INFO] [stderr] ... | [INFO] [stderr] 55 | | } [INFO] [stderr] 56 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | if let Token::STRING(ss) = token { [INFO] [stderr] 23 | let n = ss.len(); [INFO] [stderr] 24 | let mut exp_buf: Vec = vec![]; [INFO] [stderr] 25 | let mut exp_mode = false; [INFO] [stderr] 26 | for i in 1..n-1 { [INFO] [stderr] 27 | if ss[i] == '{' { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `ss`. [INFO] [stderr] --> src/render/mod.rs:27:30 [INFO] [stderr] | [INFO] [stderr] 27 | for i in 1..n-1 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 27 | for in ss.iter().take(n-1).skip(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `types::ast::AST` [INFO] [stderr] --> src/types/ast.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> AST { [INFO] [stderr] 14 | | AST::Empty [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | impl Default for types::ast::AST { [INFO] [stderr] 13 | fn default() -> Self { [INFO] [stderr] 14 | Self::new() [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/types/precedence.rs:9:17 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn cont(&self, prec: &Precedence) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/types/precedence.rs:9:30 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn cont(&self, prec: &Precedence) -> bool { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `Precedence` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lexer/mod.rs:23:16 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn lex(ss: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/parser/mod.rs:10:28 [INFO] [stderr] | [INFO] [stderr] 10 | while let Some(head) = iter.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for head in iter { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser/mod.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | / match head { [INFO] [stderr] 12 | | Token::STRING(_) => { [INFO] [stderr] 13 | | xs.push(Box::new(AST::String(head.clone()))); [INFO] [stderr] 14 | | } [INFO] [stderr] 15 | | _ => { [INFO] [stderr] 16 | | } [INFO] [stderr] 17 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let Token::STRING(_) = head { [INFO] [stderr] 12 | xs.push(Box::new(AST::String(head.clone()))); [INFO] [stderr] 13 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/render/mod.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | / match token { [INFO] [stderr] 23 | | Token::STRING(ss) => { [INFO] [stderr] 24 | | let n = ss.len(); [INFO] [stderr] 25 | | let mut exp_buf: Vec = vec![]; [INFO] [stderr] ... | [INFO] [stderr] 55 | | } [INFO] [stderr] 56 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | if let Token::STRING(ss) = token { [INFO] [stderr] 23 | let n = ss.len(); [INFO] [stderr] 24 | let mut exp_buf: Vec = vec![]; [INFO] [stderr] 25 | let mut exp_mode = false; [INFO] [stderr] 26 | for i in 1..n-1 { [INFO] [stderr] 27 | if ss[i] == '{' { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `ss`. [INFO] [stderr] --> src/render/mod.rs:27:30 [INFO] [stderr] | [INFO] [stderr] 27 | for i in 1..n-1 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 27 | for in ss.iter().take(n-1).skip(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/bench.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `meta-text`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> tests/test.rs:33:14 [INFO] [stderr] | [INFO] [stderr] 33 | for i in 1..10+1 { [INFO] [stderr] | ^^^^^^^ help: use: `1..=10` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "a51ab95c97ae0cb35b22b61549bebee18958a2f05f311312825d36feac3a022e"` [INFO] running `"docker" "rm" "-f" "a51ab95c97ae0cb35b22b61549bebee18958a2f05f311312825d36feac3a022e"` [INFO] [stdout] a51ab95c97ae0cb35b22b61549bebee18958a2f05f311312825d36feac3a022e