[INFO] updating cached repository mouchtaris/rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mouchtaris/rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mouchtaris/rust" "work/ex/clippy-test-run/sources/stable/gh/mouchtaris/rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mouchtaris/rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mouchtaris/rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mouchtaris/rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mouchtaris/rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b37f1ddb5aa63b7a549c76cbca9ed90b40c915b3 [INFO] sha for GitHub repo mouchtaris/rust: b37f1ddb5aa63b7a549c76cbca9ed90b40c915b3 [INFO] validating manifest of mouchtaris/rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mouchtaris/rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mouchtaris/rust [INFO] finished frobbing mouchtaris/rust [INFO] frobbed toml for mouchtaris/rust written to work/ex/clippy-test-run/sources/stable/gh/mouchtaris/rust/Cargo.toml [INFO] started frobbing mouchtaris/rust [INFO] finished frobbing mouchtaris/rust [INFO] frobbed toml for mouchtaris/rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mouchtaris/rust/Cargo.toml [INFO] crate mouchtaris/rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mouchtaris/rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mouchtaris/rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 14ecff7281f0553ae42be9b9b00736322fda49be0de104cb7ebe033c447d84a3 [INFO] running `"docker" "start" "-a" "14ecff7281f0553ae42be9b9b00736322fda49be0de104cb7ebe033c447d84a3"` [INFO] [stderr] Checking bob v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `::rebind::Rebind` [INFO] [stderr] --> src/main.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use ::rebind::Rebind; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `::pure_point::PurePoint` [INFO] [stderr] --> src/main.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | use ::pure_point::PurePoint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | return Optian::Some(((self.0 + 1, self.1), self.0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Optian::Some(((self.0 + 1, self.1), self.0))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `::rebind::Rebind` [INFO] [stderr] --> src/main.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use ::rebind::Rebind; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `::pure_point::PurePoint` [INFO] [stderr] --> src/main.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | use ::pure_point::PurePoint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | return Optian::Some(((self.0 + 1, self.1), self.0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Optian::Some(((self.0 + 1, self.1), self.0))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/option/flat_map.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | / match self { [INFO] [stderr] 12 | | &Optian::Some(t) => f(t), [INFO] [stderr] 13 | | &Optian::None => Optian::None [INFO] [stderr] 14 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 11 | match *self { [INFO] [stderr] 12 | Optian::Some(t) => f(t), [INFO] [stderr] 13 | Optian::None => Optian::None [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/option/flat_map.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | / match self { [INFO] [stderr] 12 | | &Optian::Some(t) => f(t), [INFO] [stderr] 13 | | &Optian::None => Optian::None [INFO] [stderr] 14 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 11 | match *self { [INFO] [stderr] 12 | Optian::Some(t) => f(t), [INFO] [stderr] 13 | Optian::None => Optian::None [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.80s [INFO] running `"docker" "inspect" "14ecff7281f0553ae42be9b9b00736322fda49be0de104cb7ebe033c447d84a3"` [INFO] running `"docker" "rm" "-f" "14ecff7281f0553ae42be9b9b00736322fda49be0de104cb7ebe033c447d84a3"` [INFO] [stdout] 14ecff7281f0553ae42be9b9b00736322fda49be0de104cb7ebe033c447d84a3